Re: [RFC v1 1/3] Fix path to user gpg-keys

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 26 Feb 2019 14:48:42 +0100
schrieb "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>:

> From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> 
> If the key is fetched from remote (currently http, https),
> use the basename, otherwise, use the absolute path.
> 
> Signed-off-by: Andreas Reichel <andreas.reichel.ext@siemens.com>
> ---
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index
> 234d339..25133be 100644 ---
> a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -40,7 +40,10
> @@ python () { d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
> ${APTKEYRING}") for key in distro_apt_keys.split():
>              url = urlparse(key)
> -            filename = ''.join([wd, url.path])
> +            if "https://" in key or "http://" in key:
> +                filename = os.path.basename(url.path)
> +            else:
> +                filename = ''.join([wd, url.path])

This is just weird. What happens with git, mercurial and bazaar fetches?

>              d.appendVar("SRC_URI", " %s" % key)
>              d.appendVar("APTKEYFILES", " %s" % filename)

In fact we assume that we can guess the filename from the URI to
construct APTKEYFILES. I think a better way to do that would be using
something like:

>>        fetcher = bb.fetch2.Fetch(src_uri, d)
>>        filename = fetcher.localpath()

... not tested just reading bitbake code ;)

Henning

>      if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')):