From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6658246660386193408 X-Received: by 2002:a1c:c704:: with SMTP id x4mr368745wmf.7.1551195214809; Tue, 26 Feb 2019 07:33:34 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:574d:: with SMTP id q13ls1818591wrw.7.gmail; Tue, 26 Feb 2019 07:33:34 -0800 (PST) X-Google-Smtp-Source: AHgI3IbdF6y/P7OucbxTCfOrFC3EMh+uD5caL3sgRpRSOOjSyYfdhDWu/rxEj6jl5bNus87Zt2aj X-Received: by 2002:adf:dece:: with SMTP id i14mr1319937wrn.3.1551195214401; Tue, 26 Feb 2019 07:33:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551195214; cv=none; d=google.com; s=arc-20160816; b=yvvIz22SEPv9INolzSI5L2FqU6ba2cFfhHH+tynabELy4FmH9jDwgcV2JVS5TDsD4c M2tWF1XbVGu3BOHo+MSwooLkiCFM2AZLmtRdtZ0gpVMG/NLul5Bq98ONJfxJafG7dMa5 04JompWdjfBKlSsSihb1E3rZl6ie459Nh+yJu90QgXnrT6cL6Tpe0sass+2oilEyN64C 3d7CXkwzWLZOj1R5NEepldsMYsdO1BEwz9DMRJQRChLgvqqRdQkqTZPnitL+PMCMo+Ux v4p1zWAxqyJEKqCeSKrPwmwLgcNKzMG0oioPa9a8vOxlXDocurjIB4U0sYIpN+UPN6Jt GmiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=wOC/A9TbcfeuRg74jTD3a90+WmNndJyKUouirJevO+8=; b=NC/PqRFZexmKFCPyXmfrHCorWTY0Xw5Yvj7jJfKXoyiEWdcyuFWeVzKwv3tdEC0oVl TmBnpoKvYN+6iE/P+7Q8XPqXV+hIcsRfVVpqP/6eetXZ5tTbERuwd7b3BlJvjaZh5Rtw 2Q+zerGp/gsPX6h+0ORye4fmQkWXD+nAHMh5DrLej0g8SV9EXaKylLAapUocauOFKN2Z wVqHGpLCN1NTU5Cq8N/2Rtzr2scyAUBANSD4/ttomtN5hVS2u151GOs7rL6xwSiwgbUI c38cFLckBDmtzcSm/Xfr1hdDLZfv7fJZZleQLz7dSPif8ofME2/1bgd8sw44Vr0rhXnM DSNQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id t25si562737wmh.2.2019.02.26.07.33.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 07:33:34 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x1QFXX9u011902 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 26 Feb 2019 16:33:34 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.253]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x1QFXWDP005251; Tue, 26 Feb 2019 16:33:32 +0100 Date: Tue, 26 Feb 2019 16:33:33 +0100 From: Henning Schild To: "[ext] Andreas J. Reichel" Cc: Subject: Re: [RFC v1 1/3] Fix path to user gpg-keys Message-ID: <20190226163333.71c91001@md1za8fc.ad001.siemens.net> In-Reply-To: <20190226134844.8632-2-andreas.reichel.ext@siemens.com> References: <20190226134844.8632-1-andreas.reichel.ext@siemens.com> <20190226134844.8632-2-andreas.reichel.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: iWeYClWIX9/v Am Tue, 26 Feb 2019 14:48:42 +0100 schrieb "[ext] Andreas J. Reichel" : > From: Andreas Reichel > > If the key is fetched from remote (currently http, https), > use the basename, otherwise, use the absolute path. > > Signed-off-by: Andreas Reichel > --- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > 234d339..25133be 100644 --- > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -40,7 +40,10 > @@ python () { d.setVar("DEBOOTSTRAP_KEYRING", "--keyring > ${APTKEYRING}") for key in distro_apt_keys.split(): > url = urlparse(key) > - filename = ''.join([wd, url.path]) > + if "https://" in key or "http://" in key: > + filename = os.path.basename(url.path) > + else: > + filename = ''.join([wd, url.path]) This is just weird. What happens with git, mercurial and bazaar fetches? > d.appendVar("SRC_URI", " %s" % key) > d.appendVar("APTKEYFILES", " %s" % filename) In fact we assume that we can guess the filename from the URI to construct APTKEYFILES. I think a better way to do that would be using something like: >> fetcher = bb.fetch2.Fetch(src_uri, d) >> filename = fetcher.localpath() ... not tested just reading bitbake code ;) Henning > if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')):