Re: [RFC v1 2/3] Refactor gpg code to use apt code

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 26 Feb 2019 06:07:38 -0800
schrieb <cedric_hombourger@mentor.com>:

> >
> > diff --git a/meta/classes/isar-bootstrap-helper.bbclass 
> > b/meta/classes/isar-bootstrap-helper.bbclass 
> > index d780b85..df6fbee 100644 
> > --- a/meta/classes/isar-bootstrap-helper.bbclass 
> > +++ b/meta/classes/isar-bootstrap-helper.bbclass 
> > @@ -119,6 +119,14 @@ setup_root_file_system() { 
> >      export LANG=C 
> >      export LANGUAGE=C 
> >      export LC_ALL=C 
> > + 
> > +    if [ -d ${TMPDIR}/aptkeys ]; then 
> > +        for keyfile in ${TMPDIR}/aptkeys/* 
> > +        do 
> > +            cp $keyfile "$ROOTFSDIR"/tmp/$(basename $keyfile) 
> >  
> 
> I have seen repos name their key debian.gpg or some other generic name
> I am concerned that we may get repositories using the same key names
> and only the last key would be added
> Should we do something like:
>
> tmpkey=$(mktemp -p  "$ROOTFSDIR"/tmp)
> cp $keyfile $tmpkey
> sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-key add /tmp/$(basename
> $tmpkey) rm -f   $tmpkey

I think there is no point in doing that, they would already collide in
the DLDIR. You probably want to use ";name=foo" in the SRC_URI.

Henning
 
> +            sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-key add 
> > /tmp/$(basename $keyfile) 
> > +        done 
> > +    fi 
> >  
> 
> 
> >  
>