From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6662306179908108288 X-Received: by 2002:adf:9e4c:: with SMTP id v12mr1341435wre.12.1551196622699; Tue, 26 Feb 2019 07:57:02 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:67c4:: with SMTP id b187ls32068wmc.5.canary-gmail; Tue, 26 Feb 2019 07:57:02 -0800 (PST) X-Google-Smtp-Source: AHgI3IYntYXTILgcN2YZD5ImMSV2JWuep/F3W0mFBnuJlCaqr8KKfOPUceLH54xyz7r6Z/bGhXcu X-Received: by 2002:a1c:c704:: with SMTP id x4mr378350wmf.7.1551196622201; Tue, 26 Feb 2019 07:57:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551196622; cv=none; d=google.com; s=arc-20160816; b=yKbiKtRG+TP+8ScnAK1icr/2RiHQbDbRVGuS0p19nhco2uTUNy/vgtagtdhGLm/UsE G+ftBtRZa0PG3EBOaWZM25N3XFB8UZEvkzJ5E9CzHYr1+y/7VGEP8rDCU7/wQc7DSFf6 x6wAmoaFJOpgZh3775qMF8vF9lXr1DJ6VevcqCbbDY9pgtmV57rAFp7G2TGStUBC1j3+ w5h8zgg8KEsGrLDqhakdaC7h5u3JPjIYOJOOuGmqRjDoe1mq5eiBc558vdG8bizeV5sI P8CHDgJFp5Nn8Vkaqvjx0L187zqXSVJDTYUNUjF2PyQAyHmhaYe9VISCH8fLKNCPzvPW KIIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=6KUn7WkeSfSRb14kd0GWIjlA8W8hYIBDwtLjS3XTT2I=; b=oBBqhmODUeDPw7ddG9egFeKMzDYQpVcSyT5d8HM+IVGfkn2FMtnnT5JyzM2wslUFPl 657rZ0PWmsH0WdDUUaYvvmvQmIpqlWP152kZm1FLVxeLO5X/kIsS0ThJrN8Ix9UhZSto flVPu8b5F1/wlQFleyWoD/dsMKPsVDMn8EwTwEwdXtFRxteBJb5TPtRnXpqs/87ft2eB 6lQMm5T1xlliA9AJLRbPk5leoavJ7HQZsw6ftv5TCmuxrww9MgNZfDfbiyRdH6nWbngQ 2yS/v8Bj7Otj4Qp8cl7Jk6P4GOyurBvqjXUNI+Wl1+Xlu1JCFquBg6GvliL6COQeNdlh 3e1A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id j43si126715wre.2.2019.02.26.07.57.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 07:57:02 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x1QFv1Fk011379 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Feb 2019 16:57:01 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.253]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x1QFv1F3023655; Tue, 26 Feb 2019 16:57:01 +0100 Date: Tue, 26 Feb 2019 16:57:01 +0100 From: Henning Schild To: Cc: isar-users Subject: Re: [RFC v1 2/3] Refactor gpg code to use apt code Message-ID: <20190226165701.4e550d8c@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20190226134844.8632-1-andreas.reichel.ext@siemens.com> <20190226134844.8632-3-andreas.reichel.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: YmDMMNjjDGPW Am Tue, 26 Feb 2019 06:07:38 -0800 schrieb : > > > > diff --git a/meta/classes/isar-bootstrap-helper.bbclass > > b/meta/classes/isar-bootstrap-helper.bbclass > > index d780b85..df6fbee 100644 > > --- a/meta/classes/isar-bootstrap-helper.bbclass > > +++ b/meta/classes/isar-bootstrap-helper.bbclass > > @@ -119,6 +119,14 @@ setup_root_file_system() { > > export LANG=C > > export LANGUAGE=C > > export LC_ALL=C > > + > > + if [ -d ${TMPDIR}/aptkeys ]; then > > + for keyfile in ${TMPDIR}/aptkeys/* > > + do > > + cp $keyfile "$ROOTFSDIR"/tmp/$(basename $keyfile) > > > > I have seen repos name their key debian.gpg or some other generic name > I am concerned that we may get repositories using the same key names > and only the last key would be added > Should we do something like: > > tmpkey=$(mktemp -p "$ROOTFSDIR"/tmp) > cp $keyfile $tmpkey > sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-key add /tmp/$(basename > $tmpkey) rm -f $tmpkey I think there is no point in doing that, they would already collide in the DLDIR. You probably want to use ";name=foo" in the SRC_URI. Henning > + sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-key add > > /tmp/$(basename $keyfile) > > + done > > + fi > > > > > > >