From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6662624591324643328 X-Received: by 2002:a2e:8154:: with SMTP id t20mr112675ljg.7.1551263172027; Wed, 27 Feb 2019 02:26:12 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:9146:: with SMTP id y6ls50262lfj.10.gmail; Wed, 27 Feb 2019 02:26:11 -0800 (PST) X-Google-Smtp-Source: AHgI3IagyWZ7gTOCZPE5EiOZP4pdklSiefP6let7TrkByJt38QJcD6zu0hR8GQlADDcEU1tinMN4 X-Received: by 2002:a19:f703:: with SMTP id z3mr53833lfe.8.1551263171523; Wed, 27 Feb 2019 02:26:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551263171; cv=none; d=google.com; s=arc-20160816; b=vUTZxfxGpaEni8TRp4JU2ClrPrL/PeeVM9XGJv0CDGDyzNFQBJYepQFrCZONLXSf6U DdcP23Gy7qZxA1femJMWSq3wtwCKb8F/lU1IMRytJiqVw/uvVQ1k1WDXfdY7VrkL/Vqu uOndBbwdhQ4Ra2TcsTmVTSxVho1dSDbXUyTWkVbE5ZHJDTsWOZJvoLd+e44/cNLKq51+ SvO8u92yKbYpy7TJ4XAWMYltU2Ri/tE4wspbA/mFMbr+M8gXAhKtayLJh4O4egPHg94H 3aerXuolIBTEA04B9w1BFaZAB+rhWcqTuTlCcMOcqIZqENTfF4a6I5dHEs1Ss/pns18f 6TBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=Zvy5YMfkdNWjADAARRDKlZvLn3EZYGoe8QcPcdj1iSI=; b=JKTLxJ0V+wfXe6iTE/k6miTzm9IIsCGxDAuBV2/eNRtCUDLIOYgihrewyaI3QR4JWk yC/NwUY0NV0obzlK0bp903hdH+cKf/Dg9Gh39QSl9x3LspwkTdHdLiCUqWNy5aJlNMRn M9PAoseZYU7d4nzrTYaibRF1brMS7+Kmvonv5EtxBb0D5yvwwMnggPi2aW8lOg3D1va9 Rf2XgzAcP7zPZeCQbtKnSanVxGvX3poH+FKOjEeSo79YxiBwe15c0zTCLvf1jMJ4nvD2 A1bSDS62m8AUd3fS30fFnOKUwVy4ghjEpnwa/pnyk53XlCbn2CFdJmqtx6m9wJ8CcKwj k6Jg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id q30si666303lfb.3.2019.02.27.02.26.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 02:26:11 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x1RAQAjw027886 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Feb 2019 11:26:10 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.171]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x1RAQ8DY029451; Wed, 27 Feb 2019 11:26:08 +0100 From: Henning Schild To: isar-users@googlegroups.com Cc: Michael Adler , Jan Kiszka , Henning Schild Subject: [PATCH] buildchroot: do not assume group of "builder" to be "builder" Date: Wed, 27 Feb 2019 11:26:06 +0100 Message-Id: <20190227102606.18017-1-henning.schild@siemens.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: /GZ0cx97Q36T From: Henning Schild We try to align the user and group ids of the user running bitbake with the users inside the chroots. If that outside user happens to be in a group that already exists in a fresh installation (i.e. users:100) we will not create a group called "builder" so checking the group name later will fail. Just check that the gid is the gid of "builder" instead of checking that the group name is "builder". Reported-by: Michael Adler Signed-off-by: Henning Schild --- meta/recipes-devtools/buildchroot/files/common.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/recipes-devtools/buildchroot/files/common.sh b/meta/recipes-devtools/buildchroot/files/common.sh index 9e6adbc..01d3c57 100644 --- a/meta/recipes-devtools/buildchroot/files/common.sh +++ b/meta/recipes-devtools/buildchroot/files/common.sh @@ -7,10 +7,10 @@ set -e printenv | grep -q BB_VERBOSE_LOGS && set -x -# assert we are either "root:root" or "builder:builder" -if ([ "$(id -un)" != "builder" ] || [ "$(id -gn)" != "builder" ]) && +# assert we are either "root:root" or "builder:" +if ([ "$(id -un)" != "builder" ] || [ "$(id -g)" != "$(id -g builder)" ]) && ([ "$(id -un)" != "root" ] || [ "$(id -gn)" != "root" ]); then - echo "This script can only be run as root:root or builder:builder!" >&2 + echo "This script can only be run as root:root or builder:!" >&2 echo "(Currently running as $(id -un)($(id -u)):$(id -gn)($(id -g)))" >&2 exit 1 fi -- 2.19.2