Re: [PATCH] dpkg-raw: use date of the most recent file instead of "now"

[Henning Schild <henning.schild@siemens.com>]

On Wed, 27 Feb 2019 10:03:01 +0100
Cedric Hombourger <Cedric_Hombourger@mentor.com> wrote:

> The changelog generated by Isar would use the current date/time
> causing each build to be different. Use the date/time of the
> most recent file to achieve reproducible builds (assuming files
> contained in the payload have the same contents and timestamps).
> In the event where the dpkg-raw package is not shipping any
> files, Isar will default to the current date/time.

Good point!

> Disposition: Submit upstream

That should probably not be here.

> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>  meta/classes/debianize.bbclass | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/debianize.bbclass
> b/meta/classes/debianize.bbclass index 510aebd..90edcdc 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -6,7 +6,12 @@
>  CHANGELOG_V ?= "${PV}"
>  
>  deb_add_changelog() {
> -	date=$( LANG=C date -R )
> +	timestamp=$(find ${D}/ -type f -printf "%T@ %p\n"|grep -v
> ${D}/debian/|sort -n|awk '{print $1 }'|tail -n 1)

Maybe we can clean that up a bit. i.e.

find ... -not -path "${D}/debian/*"

now we can probably adjust the format string to just be the timestamp
and get rid of the awk.

Henning

> +	if [ -n "${timestamp}" ]; then
> +		date=$(LANG=C date -R -d @${timestamp})
> +	else
> +		date=$(LANG=C date -R)
> +	fi
>  	cat <<EOF > ${S}/debian/changelog
>  ${PN} (${CHANGELOG_V}) UNRELEASED; urgency=low
>