From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6662603229503684608 X-Received: by 2002:adf:e412:: with SMTP id g18mr147216wrm.9.1551261619555; Wed, 27 Feb 2019 02:00:19 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:b755:: with SMTP id h82ls194528wmf.9.canary-gmail; Wed, 27 Feb 2019 02:00:19 -0800 (PST) X-Google-Smtp-Source: AHgI3IYrsnkzQHcHLHmmXloaT8NdIF5XScSDc9xc6CUK/rEW03WpaHj0h+4jODqU9oU4yp/FwZ6H X-Received: by 2002:a1c:1a47:: with SMTP id a68mr197562wma.18.1551261619151; Wed, 27 Feb 2019 02:00:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551261619; cv=none; d=google.com; s=arc-20160816; b=gSZPPOQAQabpMX+W9fueZeJLoAadatbu44NgqXZM9BDQCeXCaEWlDM3wn+9uUDVkyL KW8vGadrqn3Cr+aIp7E5+nAzwEmxN1+sGO9wwJjUgcf4WpAaHg8FD2iiewCug+QvPMrq SaHk4/+3ru3E8YprvUVlW85fx85206RoaUCr/eiLK1BO3gCqBgmnLna+NT0/YixMWNa9 kJ0UZD2KXfKDUAXDD2OcAzRbHiiBXLwgd+mAogjG8LhsCMV8trl05CIl8l9fGqIb4JfP VjJFLHpnt6/Z5I2+WjmsFr0ZuhekiaGTWbnYonYYRtKD7xCcU0RxOKxs/rDkfX0ps8hl dljQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=S3YTJwoMNuhSYSl/XJhog/Mtjj5G9nONmBzZuhcos/0=; b=ciHBPRRg+lt+qMfIkd82FX4pJoQOi2VyIU/lMHJKCZodTQKyiA7woEilDhBPbhIa1h 4fydZKV0nmuetp6WZDHn4GZ1mv7T44elLvOoS+0Q9Lso9TL9v491ocPBHgc81o+k/Lob fG9DPVOItvPtT2gXXSiK+v/cZup4sXr5n7Dxrm2vzu/98ZnE6nH0ULswg6BCUK7Xp84Y hipjUdvUys0/VfzRSwpDj92BkqUpmR5xZy9GJGq6egqL+YP+gaXa0XvKS72msDNcPAMB 7mDKUSNdG3iWrFQZWSKU7tA0CGUrnEfRG6NOMO3ToGNUU2IUcz9th3rEO4AV+1LkH50W APoQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id 109si567392wrb.0.2019.02.27.02.00.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 02:00:19 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x1RA0IYl016007 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Feb 2019 11:00:18 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.171]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x1RA0I0Q026400; Wed, 27 Feb 2019 11:00:18 +0100 Date: Wed, 27 Feb 2019 11:00:17 +0100 From: Henning Schild To: Cedric Hombourger Cc: Subject: Re: [PATCH] dpkg-raw: use date of the most recent file instead of "now" Message-ID: <20190227110017.36737bde@md1za8fc.ad001.siemens.net> In-Reply-To: <1551258181-263-1-git-send-email-Cedric_Hombourger@mentor.com> References: <1551258181-263-1-git-send-email-Cedric_Hombourger@mentor.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: GAb+aeV8ZLnc On Wed, 27 Feb 2019 10:03:01 +0100 Cedric Hombourger wrote: > The changelog generated by Isar would use the current date/time > causing each build to be different. Use the date/time of the > most recent file to achieve reproducible builds (assuming files > contained in the payload have the same contents and timestamps). > In the event where the dpkg-raw package is not shipping any > files, Isar will default to the current date/time. Good point! > Disposition: Submit upstream That should probably not be here. > Signed-off-by: Cedric Hombourger > --- > meta/classes/debianize.bbclass | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/debianize.bbclass > b/meta/classes/debianize.bbclass index 510aebd..90edcdc 100644 > --- a/meta/classes/debianize.bbclass > +++ b/meta/classes/debianize.bbclass > @@ -6,7 +6,12 @@ > CHANGELOG_V ?= "${PV}" > > deb_add_changelog() { > - date=$( LANG=C date -R ) > + timestamp=$(find ${D}/ -type f -printf "%T@ %p\n"|grep -v > ${D}/debian/|sort -n|awk '{print $1 }'|tail -n 1) Maybe we can clean that up a bit. i.e. find ... -not -path "${D}/debian/*" now we can probably adjust the format string to just be the timestamp and get rid of the awk. Henning > + if [ -n "${timestamp}" ]; then > + date=$(LANG=C date -R -d @${timestamp}) > + else > + date=$(LANG=C date -R) > + fi > cat < ${S}/debian/changelog > ${PN} (${CHANGELOG_V}) UNRELEASED; urgency=low >