Re: [PATCH v2 0/3] Fixes usage of additional apt keys

[Henning Schild <henning.schild@siemens.com>]

Could you send a list of changes next time, or reply to the reviews.

Otherwise there is no way to tell what you did in response to the
review, which comments you skipped etc.

Henning

Am Wed, 27 Feb 2019 16:18:53 +0100
schrieb "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>:

> From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> 
> If the user does not want to replace the bootstrap source together
> with the key, additional keys did not work.
> 
> This is solved by not replacing the keyring but to add keys to
> /ect/apt/trusted.gpg.d/isar.gpg, where debootstrap and any apt call
> can find it.
> 
> Furthermore, the code to add keys is simplified a lot by not manually
> parsing URIs and guessing about download locations as well as
> not manually handling gpg and giving apt config overrides.
> 
> It is much simpler by using `apt-key` and default apt keyring paths.
> 
> Furthermore, apt-get must not use a given single source list which was
> used from debootstrapping. Otherwise, additional packages are always
> unauthenticated, which is a quite misleading error. Instead, apt-get
> should use all source lists available in the built root.
> 
> Signed-off-by: Andreas Reichel <andreas.reichel.ext@siemens.com>
> 
> Andreas Reichel (3):
>   Fix and simplify apt keyring generation
>   Use all source lists in target root apt
>   Separate apt-key entries from default keyring
> 
>  meta/classes/isar-bootstrap-helper.bbclass    | 17 ++++++--
>  meta/classes/isar-image.bbclass               |  1 +
>  .../isar-bootstrap/isar-bootstrap-host.bb     |  2 +-
>  .../isar-bootstrap/isar-bootstrap.inc         | 39
> +++++++++---------- 4 files changed, 33 insertions(+), 26 deletions(-)
>