From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6662700470316826624 X-Received: by 2002:ac2:4427:: with SMTP id w7mr181800lfl.6.1551284159580; Wed, 27 Feb 2019 08:15:59 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:5c06:: with SMTP id q6ls282983ljb.9.gmail; Wed, 27 Feb 2019 08:15:59 -0800 (PST) X-Google-Smtp-Source: APXvYqwFwuTQsSIaPSCG25ItcQdNoFrjbaBj7F6ZV/1w+EeEj69UKgzRK6kYMIz9a87kY4YHl0fp X-Received: by 2002:a2e:85cd:: with SMTP id h13mr234900ljj.8.1551284159002; Wed, 27 Feb 2019 08:15:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551284158; cv=none; d=google.com; s=arc-20160816; b=vKfJNzjWbqfpfnNwd3ymAPr0F0GWiPk3gc328RRdC76C1v2emEPnRbypl2VhJkj0E+ r8SDkYHMUkfzNtiiEiNXpoW0LeGbgWy7kC9G1d9DFg6wQTKTbNovQFAQP1Z6ihsD3cEe OXEhghRSdZNGciKxTPslaUhsuD0HVn6FkEqHbjp8vrC+QFrwc1StDOhMAQbWJLuUzPVg Of1ObsHGAl+YtzyXX+95PrabneLgGp+xZSS0KecQTKo/YzbOcrOmFtV97Ow4XwyniXlZ 4R17DX620JSUJS+5rCt8YlbahNG7zbnLnplVA7S0BpTjk3MixaGgQhxWVrtt0xy+i/m3 TkSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=ZjbJtYCTCH6qGmfmUb9pxCteA6jrDILmtoLyitI0wJ8=; b=Yca+TeTN2SzkWIgwNI5E3Vnzf776haa2hFqRIWmceUc5odXqVz3x33fXP5Poyed1qV UX031zc0uxYQRcq++X2hi0Gc4Q6quJTKAhvl0MzUhupUmiu8+AWRzj8+VY4dHlxCPqRp Tm6PtMsdyRmqq7r9Q6AynT2uA7AqXyXUppC9M8Pp5IaSnfmnC8Z+mXigJX2yxz1wWYsk rvB3Q6T+8e3MXjOfEMaYK54Vn0M8E5HdBQyNv4q3+CQvly0OxaQSMHV3whPIf9bM3/qB r9LlJ72jNqniZjjtSMIQsV+naiGabf+LTc8whWcKZXygA3+E32qA/XqXi1aZ9tUYeqgp xUeg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id x12si364950ljb.2.2019.02.27.08.15.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 08:15:58 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x1RGFws6014707 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 27 Feb 2019 17:15:58 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.171]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x1RGFwa8013405; Wed, 27 Feb 2019 17:15:58 +0100 Date: Wed, 27 Feb 2019 17:15:56 +0100 From: Henning Schild To: "[ext] Andreas J. Reichel" Cc: Subject: Re: [PATCH v2 0/3] Fixes usage of additional apt keys Message-ID: <20190227171556.53293b32@md1za8fc.ad001.siemens.net> In-Reply-To: <20190227151856.11594-1-andreas.reichel.ext@siemens.com> References: <20190227151856.11594-1-andreas.reichel.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 4X6ALSEWhaKt Could you send a list of changes next time, or reply to the reviews. Otherwise there is no way to tell what you did in response to the review, which comments you skipped etc. Henning Am Wed, 27 Feb 2019 16:18:53 +0100 schrieb "[ext] Andreas J. Reichel" : > From: Andreas Reichel > > If the user does not want to replace the bootstrap source together > with the key, additional keys did not work. > > This is solved by not replacing the keyring but to add keys to > /ect/apt/trusted.gpg.d/isar.gpg, where debootstrap and any apt call > can find it. > > Furthermore, the code to add keys is simplified a lot by not manually > parsing URIs and guessing about download locations as well as > not manually handling gpg and giving apt config overrides. > > It is much simpler by using `apt-key` and default apt keyring paths. > > Furthermore, apt-get must not use a given single source list which was > used from debootstrapping. Otherwise, additional packages are always > unauthenticated, which is a quite misleading error. Instead, apt-get > should use all source lists available in the built root. > > Signed-off-by: Andreas Reichel > > Andreas Reichel (3): > Fix and simplify apt keyring generation > Use all source lists in target root apt > Separate apt-key entries from default keyring > > meta/classes/isar-bootstrap-helper.bbclass | 17 ++++++-- > meta/classes/isar-image.bbclass | 1 + > .../isar-bootstrap/isar-bootstrap-host.bb | 2 +- > .../isar-bootstrap/isar-bootstrap.inc | 39 > +++++++++---------- 4 files changed, 33 insertions(+), 26 deletions(-) >