From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6662700470316826624 X-Received: by 2002:a50:944c:: with SMTP id q12mr560144eda.0.1551431953208; Fri, 01 Mar 2019 01:19:13 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:32c1:: with SMTP id k1ls1703401ejk.9.gmail; Fri, 01 Mar 2019 01:19:12 -0800 (PST) X-Google-Smtp-Source: APXvYqzaLDt0pQU4/KZ96Df010N+GZsGCRuZB/vjG+S2sWHKV/JtPmeL8GjoCN9YHFVjI+mKpr4n X-Received: by 2002:a17:906:584c:: with SMTP id h12mr393619ejs.2.1551431952768; Fri, 01 Mar 2019 01:19:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551431952; cv=none; d=google.com; s=arc-20160816; b=lnkMYjYo8GXoIUifNN+L0IImgKnzE/ozv8dI6VnZx3CsPykD7Fzy3jJJ7ornHRUCXG HYktHCPcxd+FkiTs293w0XQ7hOnjiQE0GlkR3wRLYle0v2LktimQ2cF0pHdWSchEwUPS 6uhUjAokfTote62PfwkIshGuItCBG63D3QchEwf5uIKknEj8mXd+yLCJeatQ93VmIhE4 /DSC7kDUMQI4Nt612ztrVWVyN67U0LmAzNEDKF4zYyhuiMcwslZXABtDn9B/xw+cGZxl QrzTWPnoponKmU7VA5qxXju+3oh///Pv4PGomkBGu3XGbs6UPusUvBwSDvQ6EQWB8VqF XoDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:cc:to:from:date; bh=oZJ2uZkqXEz1V8HuxX1RNCmbWllTDeIvMn90vXfmj7U=; b=F1c5C6VCzxlYEN8QBDLyrLQ7gCUFRKWC1T4+4BpL2nJffEoyXn45YKD3pPF3LMuRLL YL9ihVkRxR9JjVg+pjaCGgDV6wqoCWxNImfTHxZboE3MmWKrB5/CV4EL4vrOq45NeWHb c2Pwimsv9ggWAYcT+Qui6oZWzHXaT72T2TW4K3WebBP/J1xD0WGLeyZUNC/9AzVuCeSz 1CTKXAN7C6+n9Kr48KwbcwOVJ6JQ1fap5SJ4b2qcG31pUI1/I+aKHgaet5oHoIgUHAjO vmNLcFdKYbCycdBb8elPNq9YgBlyCDF8u2ABzUAO94EHaxoHZnTaXA5p8SkH9/UMfKp7 12Tg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id q1si1129507edd.5.2019.03.01.01.19.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 01:19:12 -0800 (PST) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x219JCoa024808 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 1 Mar 2019 10:19:12 +0100 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.17]) by mail1.sbs.de (8.15.2/8.15.2) with SMTP id x219JCv8012468; Fri, 1 Mar 2019 10:19:12 +0100 Date: Fri, 1 Mar 2019 10:17:35 +0100 From: Andreas Reichel To: Henning Schild Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2 0/3] Fixes usage of additional apt keys Message-ID: <20190301091735.GB13010@iiotirae> References: <20190227151856.11594-1-andreas.reichel.ext@siemens.com> <20190227171556.53293b32@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: <20190227171556.53293b32@md1za8fc.ad001.siemens.net> User-Agent: Mutt/1.11.3 (2019-02-01) X-TUID: wMXyzGOr2xlf On Wed, Feb 27, 2019 at 05:15:56PM +0100, Henning Schild wrote: > Could you send a list of changes next time, or reply to the reviews. > > Otherwise there is no way to tell what you did in response to the There is a simple way... read the cover letters. But sure, I will do better next time :) Andreas > review, which comments you skipped etc. > > Henning > > Am Wed, 27 Feb 2019 16:18:53 +0100 > schrieb "[ext] Andreas J. Reichel" : > > > From: Andreas Reichel > > > > If the user does not want to replace the bootstrap source together > > with the key, additional keys did not work. > > > > This is solved by not replacing the keyring but to add keys to > > /ect/apt/trusted.gpg.d/isar.gpg, where debootstrap and any apt call > > can find it. > > > > Furthermore, the code to add keys is simplified a lot by not manually > > parsing URIs and guessing about download locations as well as > > not manually handling gpg and giving apt config overrides. > > > > It is much simpler by using `apt-key` and default apt keyring paths. > > > > Furthermore, apt-get must not use a given single source list which was > > used from debootstrapping. Otherwise, additional packages are always > > unauthenticated, which is a quite misleading error. Instead, apt-get > > should use all source lists available in the built root. > > > > Signed-off-by: Andreas Reichel > > > > Andreas Reichel (3): > > Fix and simplify apt keyring generation > > Use all source lists in target root apt > > Separate apt-key entries from default keyring > > > > meta/classes/isar-bootstrap-helper.bbclass | 17 ++++++-- > > meta/classes/isar-image.bbclass | 1 + > > .../isar-bootstrap/isar-bootstrap-host.bb | 2 +- > > .../isar-bootstrap/isar-bootstrap.inc | 39 > > +++++++++---------- 4 files changed, 33 insertions(+), 26 deletions(-) > > > -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082