Re: [PATCH v2 1/3] Fix and simplify apt keyring generation

[Henning Schild <henning.schild@siemens.com>]

Am Fri, 1 Mar 2019 10:16:50 +0100
schrieb Andreas Reichel <andreas.reichel.ext@siemens.com>:

> On Wed, Feb 27, 2019 at 05:12:42PM +0100, Henning Schild wrote:
> > Am Wed, 27 Feb 2019 16:18:54 +0100
> > schrieb "[ext] Andreas J. Reichel"
> > <andreas.reichel.ext@siemens.com>: 
> > > From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> > > 
> > > +
> > > +    if [ -d ${TMPDIR}/aptkeys ]; then
> > > +        for keyfile in ${TMPDIR}/aptkeys/*
> > > +        do
> > > +            kfn="tmp/$(basename $keyfile)"
> > > +            cp $keyfile "$ROOTFSDIR/$kfn"
> > > +            sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-key add
> > > "/$kfn"  
> > 
> > Would probably be a good idea to work in /tmp/ as well and in a
> > subdir. Try naming your key "root" or "usr" ...
> >   
> I AM working in /tmp/, ... a subdir is not needed since we directly
> work with the file names.
> This is not " a key ", these are arbitrarily many keys and the name of
> the key files don't change between the host, the build and target
> chroots.

I see the "tmp/" is in $kfn, might be more readable to have in the the
cp and apt-key.

Henning

> Andreas
>