From: claudius.heine.ext@siemens.com
To: isar-users@googlegroups.com
Cc: Harald Seiler <hws@denx.de>
Subject: [PATCH v4 5/6] wic: Refactor fakeroot script
Date: Mon, 4 Mar 2019 14:08:00 +0100 [thread overview]
Message-ID: <20190304130801.20628-6-claudius.heine.ext@siemens.com> (raw)
In-Reply-To: <20190304130801.20628-1-claudius.heine.ext@siemens.com>
From: Harald Seiler <hws@denx.de>
Signed-off-by: Harald Seiler <hws@denx.de>
---
scripts/wic_fakeroot | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/scripts/wic_fakeroot b/scripts/wic_fakeroot
index 9e01c38..88a03fa 100755
--- a/scripts/wic_fakeroot
+++ b/scripts/wic_fakeroot
@@ -11,7 +11,6 @@
#
import os
import sys
-import shutil
import subprocess
args = sys.argv
@@ -24,14 +23,12 @@ cmd = args[0]
# i.e. in wics partition.py the "du -ks" fails on
# var/cache/apt/archives/partial
# rootfs/root ...
-assert 'root' == os.environ["USER"]
+assert os.geteuid() == 0, "wic_fakeroot must be run as root!"
# e2fsck <= 1.43.5 returns 1 on non-errors (stretch and before affected)
# treat 1 as safe ... the filesystem was successfully repaired and is OK
if cmd.startswith('fsck.'):
ret = subprocess.call(args)
- if ret == 0 or ret == 1:
- sys.exit(0)
- sys.exit(ret)
+ sys.exit(0 if ret == 1 else ret)
-os.execv(shutil.which(cmd), args)
+os.execvp(cmd, args)
--
2.20.1
next prev parent reply other threads:[~2019-03-04 13:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 13:07 [PATCH v4 0/6] Python refactoring claudius.heine.ext
2019-03-04 13:07 ` [PATCH v4 1/6] Remove all uses of subprocess.call(shell=True) claudius.heine.ext
2019-03-04 13:07 ` [PATCH v4 2/6] isar-bootstrap-helper: get_deb_host_arch: fix decoding claudius.heine.ext
2019-03-04 13:07 ` [PATCH v4 3/6] Use modern python formatting claudius.heine.ext
2019-03-04 13:07 ` [PATCH v4 4/6] image: Remove recursion in get_image_name claudius.heine.ext
2019-03-04 13:08 ` claudius.heine.ext [this message]
2019-03-04 13:08 ` [PATCH v4 6/6] Fix python style claudius.heine.ext
2019-03-04 16:21 ` [PATCH v4 0/6] Python refactoring Claudius Heine
2019-03-11 10:10 ` Maxim Yu. Osipov
2019-03-11 12:22 ` Claudius Heine
2019-03-12 14:56 ` Claudius Heine
2019-03-12 15:26 ` Jan Kiszka
2019-03-12 15:34 ` Claudius Heine
2019-03-12 16:03 ` Jan Kiszka
2019-03-12 16:17 ` Claudius Heine
2019-03-12 22:36 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304130801.20628-6-claudius.heine.ext@siemens.com \
--to=claudius.heine.ext@siemens.com \
--cc=hws@denx.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox