From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6665315482964328448 X-Received: by 2002:a2e:9194:: with SMTP id f20mr372748ljg.21.1551892696017; Wed, 06 Mar 2019 09:18:16 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:2c7:: with SMTP id y68ls333503lje.10.gmail; Wed, 06 Mar 2019 09:18:15 -0800 (PST) X-Google-Smtp-Source: APXvYqwradgvkmLRrWe+HpnSyHWX3WZN+IdoUKZJy90SONBuFXWat0iM7MHenyvdpa3ssXqyWK9z X-Received: by 2002:a2e:800a:: with SMTP id j10mr371348ljg.11.1551892695165; Wed, 06 Mar 2019 09:18:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551892695; cv=none; d=google.com; s=arc-20160816; b=Y06rcPccNaRMduIh4Fwdm27FG51aArguKwyCbrYs6iPUNWp4IVXssIzMLq/DcgEPL+ t5pTFV313oRpTddvmz02cWOEGUp36sUoT5y/wB8PxsUBfyYjrqEqCmrbMAdSzvSWfg9B wsLNFD7MQTyfDVPE0znJkfd7nGKg/ycV46jGjvGOwZexHOfXiHSXtxJM8ibUVFLsBfQN zsqM4zoekY0pkdAD2O/H3We9lzGmd41v2sAEdpf71VfPI63XHVIM22k8e7liFBCT8K0T 2RyZDKGn+0XuXcPQ7IW3C3814Y5nHVkyasBsgFXL7ZSFDhqVbeyDvuSLTxmq+qjTAfaT 1otw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=DDf3PGiuiEK3Hc8+vNom0IGJHee34GjOxQv3HaZQyPM=; b=PNkLvp89LBGmjoKkMCY69AUh2k9qBArlOIyfbZlGGw3pwS1A9t11azXXSRLsnjj3+9 HV6llcencK6DjdX3Xc/7AqdDb6e+uUn73OuLzscm/fB2EccnKAm5RK3s2xyzmBfW/P/H mtEy2lC97DR3rS1ffQ7mQzSt9egh5f+o+Y4qqNev9ggEF3IN7WVr/oG78ZQgIFMI7OY5 +lWyaFlyM93XlpWsT5A50ZQspkNFagp8ph0OjmQYUrvGJ7OnA4rCX0E/gOYzt/6XVEdm EXrsn79eF8RhoGzEZQVxuDraWVa+WumQ218paXcP3rwWLUhGLqcpMQjqTXC2dOvcwBl+ 7A+w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id f20si64555lfc.5.2019.03.06.09.18.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 09:18:14 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x26HIDbR027244 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 6 Mar 2019 18:18:13 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.211]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x26HIC6Q002727; Wed, 6 Mar 2019 18:18:12 +0100 Date: Wed, 6 Mar 2019 18:18:12 +0100 From: Henning Schild To: "[ext] Andreas J. Reichel" Cc: Subject: Re: [PATCH v3 1/6] Revert "isar-bootstrap: Allow to set local keys in DISTRO_APT_KEYS" Message-ID: <20190306181812.5b522bc6@md1za8fc.ad001.siemens.net> In-Reply-To: <20190306162619.826-2-andreas.reichel.ext@siemens.com> References: <20190306162619.826-1-andreas.reichel.ext@siemens.com> <20190306162619.826-2-andreas.reichel.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: yqyLR9AI9eFy I do not see the point of the revert. You are just going back to the way it was broken before. It also does not seem to document what went wrong. Instead of that revert 2/6 needs a more verbose commit message maybe mentioning the previous patches that got it wrong. Henning Am Wed, 6 Mar 2019 17:26:13 +0100 schrieb "[ext] Andreas J. Reichel" : > From: Andreas Reichel > > This reverts commit af983a13b6f4cee5d4af5e5cf6318231e02775c9. > > We do not want to guess where the downloaded file will be. This does > not work anymore if the key is downloaded from remote with a URL. > > Signed-off-by: Andreas Reichel > --- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > 234d339..eb9a9df 100644 --- > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -40,7 +40,7 > @@ python () { d.setVar("DEBOOTSTRAP_KEYRING", "--keyring > ${APTKEYRING}") for key in distro_apt_keys.split(): > url = urlparse(key) > - filename = ''.join([wd, url.path]) > + filename = os.path.basename(url.path) > d.appendVar("SRC_URI", " %s" % key) > d.appendVar("APTKEYFILES", " %s" % filename) > if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')):