From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6665315482964328448 X-Received: by 2002:a19:fc05:: with SMTP id a5mr726895lfi.5.1551950261320; Thu, 07 Mar 2019 01:17:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:92cf:: with SMTP id k15ls602092ljh.6.gmail; Thu, 07 Mar 2019 01:17:40 -0800 (PST) X-Google-Smtp-Source: APXvYqwE0xQmvm6V7EOuhYwNH7W24uaEBB+Ss1SU6BuGLiG/YZ++5bflT1GRNKpoVeKwp48tAfv1 X-Received: by 2002:a2e:800a:: with SMTP id j10mr583633ljg.11.1551950260820; Thu, 07 Mar 2019 01:17:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551950260; cv=none; d=google.com; s=arc-20160816; b=MFNZ6MSkYD+Twtu+I15p1NtXrkCEv52CkjTwjT+dps4Db/4NJtBRbPkY6Viz24ECvb 6cMqdsAEA15TEXXzE48twqge1lEfA0Ydl6jBmw55yx8M8UHKdoQmg2DF+dgEI96HTA0u 7mZHCnTdB3U+lnOb5vKcovFEL/RCtk81IWYm1Lu90UYEr0D1TrMeWApYSfvjtOapdqfA /OBSFbfMczEzgx5vVnx+JGXVCwIAC8xSNEzmNU+IPf7u4nWbe3XzepOTzG+ZHk7d+I+w S5XoIYMWKhTciUx6Sa/jaK5yvtFw4cNHb6ASPFIge5nc1Byr0t/nzRXRkRALm/L3GhI1 Z1Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:cc:to:from:date; bh=G/9bmRtfyT0PCo+Z/1T1jwvNfRMRqhqFy4rE5utNEZM=; b=aQT5p8cDKNghRxh8ABV7WH2ueZ+aYNEOE72mIrdm3jLKw5qIJ1XUqw3xIypVNxZLu+ q/LgS676WWSTw3i/Xn+UIL8oDlLBOJL2s4oynu6Usvv4e2GrvgpZEFwf7EjYT0vFdDH9 h1cbut9wFgNPY9mWwWsAYUQ/iU9yIubHMhy0CUQZGi6lMdxtnmIlPN7bLpyMGmyNWGfx Lb+fqgy5b/w23nqcvcBpk1vzsQ5O0fkvBWzUmMsFvV5I3d9tPKOXGRmTQoQzPsvCY6C+ 9/kFyWqtw8OLS6uCf3DiQJvCPqa6VlsLGK+miaNdnCe2Gpz0i76IMPTTEWWeSvnft03T vLGA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id n21si188607lfl.2.2019.03.07.01.17.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 01:17:40 -0800 (PST) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x279HdFP023373 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 7 Mar 2019 10:17:40 +0100 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.17]) by mail1.sbs.de (8.15.2/8.15.2) with SMTP id x279HduY003000; Thu, 7 Mar 2019 10:17:39 +0100 Date: Thu, 7 Mar 2019 10:15:53 +0100 From: Andreas Reichel To: Henning Schild Cc: isar-users@googlegroups.com Subject: Re: [PATCH v3 1/6] Revert "isar-bootstrap: Allow to set local keys in DISTRO_APT_KEYS" Message-ID: <20190307091553.GC10773@iiotirae> References: <20190306162619.826-1-andreas.reichel.ext@siemens.com> <20190306162619.826-2-andreas.reichel.ext@siemens.com> <20190306181812.5b522bc6@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: <20190306181812.5b522bc6@md1za8fc.ad001.siemens.net> User-Agent: Mutt/1.11.3 (2019-02-01) X-TUID: E1pq+BhQErB9 On Wed, Mar 06, 2019 at 06:18:12PM +0100, Henning Schild wrote: > I do not see the point of the revert. You are just going back to the way > it was broken before. It also does not seem to document what went wrong. > > Instead of that revert 2/6 needs a more verbose commit message maybe > mentioning the previous patches that got it wrong. > Okay I will explain in more detail that it breaks the path... with examples :) > Henning > > Am Wed, 6 Mar 2019 17:26:13 +0100 > schrieb "[ext] Andreas J. Reichel" : > > > From: Andreas Reichel > > > > This reverts commit af983a13b6f4cee5d4af5e5cf6318231e02775c9. > > > > We do not want to guess where the downloaded file will be. This does > > not work anymore if the key is downloaded from remote with a URL. > > > > Signed-off-by: Andreas Reichel > > --- > > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > > 234d339..eb9a9df 100644 --- > > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -40,7 +40,7 > > @@ python () { d.setVar("DEBOOTSTRAP_KEYRING", "--keyring > > ${APTKEYRING}") for key in distro_apt_keys.split(): > > url = urlparse(key) > > - filename = ''.join([wd, url.path]) > > + filename = os.path.basename(url.path) > > d.appendVar("SRC_URI", " %s" % key) > > d.appendVar("APTKEYFILES", " %s" % filename) > > if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')): > -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082