From: Andreas Reichel <andreas.reichel.ext@siemens.com>
To: isar-users@googlegroups.com
Subject: Re: [PATCH v2] meta: refactored flock usage
Date: Tue, 12 Mar 2019 11:16:03 +0100 [thread overview]
Message-ID: <20190312101602.GA6737@iiotirae> (raw)
In-Reply-To: <20190308173820.GA8986@yssyq.m.ilbers.de>
On Fri, Mar 08, 2019 at 06:38:20PM +0100, Baurzhan Ismagulov wrote:
> On Thu, Mar 07, 2019 at 02:23:21PM +0100, Claudius Heine wrote:
> > ping
>
> Maxim will return next week and look at this (IIUC, this is included in
> Andreas's apt-key series) among other things. AFAIK, he wanted to make the
> release first.
>
> With kind regards,
> Baurzhan.
>
Please fix this before the release. The patch from Claudius is a fix.
The code as is without his fix is not maintainable, since we have an extremely
huge area embedded in double quotes which can break everything in between.
All quotes used inside are reversed, since the first double quote CLOSES
instead of OPENS a quoted string. This is bad coding style and should
not go into any release.
> --
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To post to this group, send email to isar-users@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20190308173820.GA8986%40yssyq.m.ilbers.de.
> For more options, visit https://groups.google.com/d/optout.
--
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant
Andreas.Reichel@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082
next prev parent reply other threads:[~2019-03-12 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 12:18 [PATCH] " claudius.heine.ext
2019-02-14 12:50 ` Claudius Heine
2019-02-14 16:08 ` [PATCH v2] " claudius.heine.ext
2019-03-07 13:23 ` Claudius Heine
2019-03-08 17:38 ` Baurzhan Ismagulov
2019-03-09 19:11 ` Claudius Heine
2019-03-12 10:16 ` Andreas Reichel [this message]
2019-03-08 17:49 ` Jan Kiszka
2019-03-09 19:08 ` Claudius Heine
2019-03-12 10:20 ` Jan Kiszka
2019-03-12 10:22 ` Claudius Heine
2019-03-12 13:18 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312101602.GA6737@iiotirae \
--to=andreas.reichel.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox