From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6657829413861720064 X-Received: by 2002:adf:ee89:: with SMTP id b9mr1891296wro.23.1552385866282; Tue, 12 Mar 2019 03:17:46 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:cc03:: with SMTP id f3ls290615wmh.3.canary-gmail; Tue, 12 Mar 2019 03:17:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyS/wIDF8NwUYZFfol+hjBNz3wROcWbg+0MO+/xtLgXByXG3fyh1G3s5nonXuGKYkpho3Wb X-Received: by 2002:a1c:7503:: with SMTP id o3mr204442wmc.9.1552385865843; Tue, 12 Mar 2019 03:17:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552385865; cv=none; d=google.com; s=arc-20160816; b=m4RwMKjA9HAeFFI/PcSPWlXU73NxOczFiaY1Do+D1n8j2qqEYLp+JFI1neO/5Anj17 nakKAIKb0b5+ik0KWT/4xkQ6W03zj9/dfutzyWvhub9QvDmXTAw3ruzbDUbFCKZe2vQ9 GxstYGWhJAJCORbkJVU84E2JS5lLmUqoxBzK8f9BpbkJClQNtXeUCf7jkr14nCTX4Bul 0YAWXJs1e6rYyyggri/q6c4yuWhfldLd47hEUCYSRC5iyrjAr4CrJxeq0UPNCy5Fbjmb 7QqAJHiuw3mTlR0b2rY0/9GQn7kI+18BijCYj8nTIny3xQy/ypXqLgmW4VjVDanDQyA5 C3Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:to:from:date; bh=f4JX9bVyBSB9JhjQKTNya4GRpo2lvypZrdzjTyRWx3A=; b=rfCvlGhez4Tk6blCXEqo47PT9wUN09h9tyKspYhtZrhy4UUcAdVDQzhB3hLTpPVoMp kPs5zQb6YA+y/ff0pZhT2DPh70r9YFHTGW4HOSlnCJgshKbfqlx/9b3PwkPUd2JteaCs pgQItGObCXBtEWfozwsfDOgoTl18Yq8iBA/joR6zxHDAUINPLHTFdiBznvB3zg+cwu6O UnxePri0+SPdYh8p6JMpq6kNOYPU1zpF6oDT985VNwFwZrkngU2OofWuIqqq0i87CdVe IzQSKuQc7VomA8SQ0Z9v/C34c/Ui/39nGt/UpX0HCCYPyrXectXnB5hXG6m2hB0IFwxP AJ/Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id f185si86179wme.1.2019.03.12.03.17.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 03:17:45 -0700 (PDT) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x2CAHjUc000807 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 12 Mar 2019 11:17:45 +0100 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.17]) by mail2.sbs.de (8.15.2/8.15.2) with SMTP id x2CAHjVM014625 for ; Tue, 12 Mar 2019 11:17:45 +0100 Date: Tue, 12 Mar 2019 11:16:03 +0100 From: Andreas Reichel To: isar-users@googlegroups.com Subject: Re: [PATCH v2] meta: refactored flock usage Message-ID: <20190312101602.GA6737@iiotirae> References: <20190214121819.22037-1-claudius.heine.ext@siemens.com> <20190214160805.19980-1-claudius.heine.ext@siemens.com> <74c572da-56cf-6ead-8aef-8f94a89ee45e@siemens.com> <20190308173820.GA8986@yssyq.m.ilbers.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: <20190308173820.GA8986@yssyq.m.ilbers.de> User-Agent: Mutt/1.11.3 (2019-02-01) X-TUID: kgLgtDp/8Kpe On Fri, Mar 08, 2019 at 06:38:20PM +0100, Baurzhan Ismagulov wrote: > On Thu, Mar 07, 2019 at 02:23:21PM +0100, Claudius Heine wrote: > > ping > > Maxim will return next week and look at this (IIUC, this is included in > Andreas's apt-key series) among other things. AFAIK, he wanted to make the > release first. > > With kind regards, > Baurzhan. > Please fix this before the release. The patch from Claudius is a fix. The code as is without his fix is not maintainable, since we have an extremely huge area embedded in double quotes which can break everything in between. All quotes used inside are reversed, since the first double quote CLOSES instead of OPENS a quoted string. This is bad coding style and should not go into any release. > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To post to this group, send email to isar-users@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20190308173820.GA8986%40yssyq.m.ilbers.de. > For more options, visit https://groups.google.com/d/optout. -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082