From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6667603680306397184 X-Received: by 2002:a17:906:6dce:: with SMTP id j14mr460650ejt.4.1552660130585; Fri, 15 Mar 2019 07:28:50 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:6a98:: with SMTP id p24ls1850456ejr.7.gmail; Fri, 15 Mar 2019 07:28:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdcCRtTGlBoUZpRdFQROd0FSfGwp44f/9A38Y1Tp/7vG5kyO3R2efI05+Y2rJYAbhl3i0p X-Received: by 2002:a17:906:7cd6:: with SMTP id h22mr456461ejp.11.1552660130077; Fri, 15 Mar 2019 07:28:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552660130; cv=none; d=google.com; s=arc-20160816; b=HEvA8ISSTP+8j3hH9Kpi2IDZcL3FTuB5Hy0S0wjsw5yWVX23bBkUju/YfPuQgWG4EK 4sp8LSxl1c09J247LYuElEo0Vh6OM4GAKJAZautTl27p+SuXahFYismqLs6zAqDUycg/ T1CKtKcmz7zbdv41npHku8ZHdBtgJP/7PuG9lwdr1ACgKJien623ak9NWWq3mXpvVCEW MmLRen0m8gMDJSkk4eDJqiW+oXZJdAR4KsWm5VFcvt8ybuy/aBRBdOD3beyRmj6Zmqp8 lkLKq/Dhl10w1u9CW0XJbF6DBk7rYIzUK//iVNyakR4EmBVqn5p9dK310TfXUL6BaIdP SEWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:to:from:date; bh=92i3NHDbiy2ahTdsfdrUUeLEhMCKYkB4lwdkoEDQ+kU=; b=WC0TV+JDS0lV1hU916+pYi9bJw8o5mAO4IKTK8VHHIg1xMX7tolz8nIcxBzyRdRWR9 CgysFaH9G+XxEspYKH7JkL66/6yUcia47t8ynEpbdIWMAV5bmmcYRkM5Ya3shrcO2GOP y+jZQe3Gt+ZoS0VZQt6t+Rz/1X3ip101PIZxr6P6SeOGRGWxhsVwhPZ9lzCHo3nW13hJ IamIR3xxMTMx1fgquHva6hUeQX7IstXZCHumiH/Bg50oas/oKXHHvQXYgCKOptT5l1Z0 k3jMtk0jM3O/IHMLlecSv9XSKiPccoL7vwHcMMa3jvB1L1pNlbLNHSH42YPrwtqTTAWY 4d4Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id i10si118891edr.3.2019.03.15.07.28.49 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Mar 2019 07:28:49 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2FESl9o030934 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 15 Mar 2019 15:28:49 +0100 Date: Fri, 15 Mar 2019 15:28:47 +0100 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH 1/2] meta-isar: Separate images per MACHINE Message-ID: <20190315142847.GH16465@yssyq.m.ilbers.de> Mail-Followup-To: isar-users@googlegroups.com References: <20190312202713.18792-1-mosipov@ilbers.de> <7984d051-8bf0-dff1-804d-104ad2a17af7@siemens.com> <91c1cdc1-9e63-7833-1518-e64dd144f102@ilbers.de> <155264550626.9286.14205828919186368830@ardipi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-9 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <155264550626.9286.14205828919186368830@ardipi> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 0t4ozcBIkMv8 Hi all, I ask everyone to use this list for constructive discussion for the benefit of the project. Communication, especially written one, can be frustrating, but it always works when people treat each other with respect. With kind regards, Baurzhan. On Fri, Mar 15, 2019 at 11:25:06AM +0100, Claudius Heine wrote: > Hi Maxim, > > Quoting Maxim Yu. Osipov (2019-03-15 10:02:48) > [...] > > >>> diff --git a/meta-isar/conf/conf-notes.txt > > >>> b/meta-isar/conf/conf-notes.txt > > >>> index 87bd2dc..84049e1 100644 > > >>> --- a/meta-isar/conf/conf-notes.txt > > >>> +++ b/meta-isar/conf/conf-notes.txt > > >>> @@ -1,4 +1,4 @@ > > >>> � Common targets are: > > >>> -��� multiconfig:qemuarm-stretch:isar-image-base > > >>> -��� multiconfig:qemuamd64-stretch:isar-image-base > > >>> -��� multiconfig:rpi-jessie:isar-image-base > > >>> +��� multiconfig:qemuarm-stretch:isar-image-base-qemuarm > > >>> +��� multiconfig:qemuamd64-stretch:isar-image-base-qemuamd64 > > >>> +��� multiconfig:rpi-jessie:isar-image-base-rpi > > > > > > I am not a big fan of having to specify the machine when building a image. > > > > > > Would it be possible to have virtual recipes? > > > > > > IMO all isar-image-base-* would provide a isar-image-base. > > > > Not sure that I got your point. > > OK, let's add two line to isar-image-base.bb > > > > PF .= "-${MACHINE}" > > PROVIDES += "isar-image-base" > > Well that is not what my initial suggestion was. > > If you want to use my initial suggestion and use PROVIDES then of course > you will have to do something like this: > > PN .= "-${MACHINE}" > PROVIDES += "isar-image-base" > > If you use my latest suggestion then you would have something like this: > > PF .= "-${MACHINE}" > WORKDIR .= "-${MACHINE}" > > If you sort of start combining my code then this will not work of > course. > > Please investigate yourself what code you write does. I don't provide copy > paste stuff in reviews, just ideas. You might be lucky if they just work by > copy-pasting, but you might not be and have to think a bit yourself to > make it work. If I would do that, then I would have written the patch > myself. > > [...] > > > >>> --- a/scripts/start_vm > > >>> +++ b/scripts/start_vm > > >>> @@ -1,7 +1,7 @@ > > >>> � #!/bin/sh > > >>> � # > > >>> � # This software is a part of ISAR. > > >>> -# Copyright (C) 2015-2017 ilbers GmbH > > >>> +# Copyright (C) 2015-2019 ilbers GmbH > > >>> � set -e > > >>> @@ -46,7 +46,7 @@ show_help() { > > >>> ����� echo "������������������������� Supported: arm, i386, amd64, > > >>> arm64." > > >>> ����� echo "��� -b, --build BUILD���� set path to build directory." > > >>> ����� echo "��� -d, --distro DISTRO�� set isar Debian distribution." > > >>> -��� echo "������������������������� Supported: jessie, stretch." > > >>> +��� echo "������������������������� Supported: jessie, stretch, buster" > > > > > > Well that change together with the copyright update should be moved in a > > > different patch. It has nothing to do with 'Separate images per MACHINE' > > > IMO. > > > > Well...formally you are right, but in my opinion such "copyright" > > commits just litter the patch queue. > > Having unrelated changes in a commit will make is harder to review, and > litter the git history/blame stuff. So while it might be a small > inconveniece short term (by needing to create and submitt more than one > patch in a queue) it makes the history cleaner for the whole future. > > Cheers, > Claudius