Re: [PATCH v4 6/6] If we use a custom keyring debootstrap may fall to https

[Andreas Reichel <andreas.reichel.ext@siemens.com>]

On Thu, Mar 07, 2019 at 03:54:52PM +0100, Henning Schild wrote:
> Am Thu, 7 Mar 2019 15:23:04 +0100
> schrieb "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>:
> 
> > From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> > 
> > See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891009
> > 
> > @@ -151,6 +158,10 @@ def get_distro_have_https_source(d,
> > is_host=False): return any(source[2].startswith("https://") for
> > source in generate_distro_sources(d, is_host)) 
> >  def get_distro_needs_https_support(d, is_host=False):
> 
> As i said somewhere else. Something like 
> get_distro_overrides
> Could be a nice place to just deal with both in one function. So even
> having that weird implication to https, we have it all in one place.
> 
> Right now we have to such functions depending on keys, otherwise we
> would have two functions returning "https-support"
> 

Maybe it's better to change this in a follow-up patch because this would
change code that has nothing to do with my series. Then we can delete
get_distro_needs_https_support and make one function for all cases.

Andreas
> Henning
> 
> > +    apt_keys = d.getVar("HAVE_CUSTOM_APT_KEYS", False)
> > +    if apt_keys:
> > +        return "https-support"
> > +
> >      if get_distro_have_https_source(d, is_host):
> >          return "https-support"
> >      else:
> 

-- 
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

Andreas.Reichel@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082