From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6665315485307895808 X-Received: by 2002:ac2:4292:: with SMTP id m18mr790919lfh.3.1552903896138; Mon, 18 Mar 2019 03:11:36 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:41c5:: with SMTP id d5ls1440408lfi.1.gmail; Mon, 18 Mar 2019 03:11:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfiPyykVQTo4wBFozz3Nyymzoo2z4bUydU3Be1V+MvJ9P7ZqytatZ0eRMFvftkFGf3VO/m X-Received: by 2002:a19:3809:: with SMTP id f9mr795255lfa.1.1552903895674; Mon, 18 Mar 2019 03:11:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552903895; cv=none; d=google.com; s=arc-20160816; b=Vwy2Hjhnzxe5dzvlhY7eyfJZ3dnPTY8voCpfLhp806AEwBe0kln489eJ70PG9J0N/b W6iFJjH1tOc2fVcvUfzVBJrZH9+MvI10wqFqUjts6Gkpdj46EY+WyEtURAsq1L09lmLQ 6Y/N5CUsxYVRdDGaD+/F/JsSorOAk+Wgz845NHOUAADF3G0rlc6H3s0/cdHne2t5+BTb HF9NRqKvBdLJxk+Lp7NEQ6LkG38DBqoqyjeX1RL9oBjfF51XW6wn2CLH8kvv8arf0cei T+Dh1PkG0oAA3ml1J2F9QdHOVgLM4QchVLo4fZFNXkYT4E3EonI0eHna6pgxmGL/oLF0 NQrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:cc:to:from:date; bh=yaTP7N/+6M08B3VLSUHV/qgV/wR77MBW7qW+kj9xewA=; b=qusjdhSB7x/WHgCBlBf9JMkIEiFuZ3Fxid0mlzKMRmMsYduW5R/UItdeL+cuXGZtI4 Wk6fjAp6B/5aB0ID/KVjD3xMMag8zHpIYsaHUO+j8Py2Re6sp7HOJNqvQ1xN9Vs+oFcI GeL1+lkX+bQdvPeWCfGKmIv9C3NBLJ4EWZ7QnqjIUn/xitFy+R4bPDh4fcwLmy0ErkxM DRzR/qursPMlFFFhuDs02+AbKpHIhbouJu6uhbD+soqQet9lxn5wcl6hOJuJGOw90UPg JXO/jhEGd3o1sS/oA89gefqL0tS1fiup8f0WrF8mdzgcQOCRRg/03biSKjNkj5Hm8ffq MWVw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id v25si118382ljj.5.2019.03.18.03.11.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 03:11:35 -0700 (PDT) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x2IABYgr014110 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 18 Mar 2019 11:11:34 +0100 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.17]) by mail2.sbs.de (8.15.2/8.15.2) with SMTP id x2IABYKv010526; Mon, 18 Mar 2019 11:11:34 +0100 Date: Mon, 18 Mar 2019 11:09:40 +0100 From: Andreas Reichel To: Henning Schild Cc: isar-users@googlegroups.com Subject: Re: [PATCH v4 6/6] If we use a custom keyring debootstrap may fall to https Message-ID: <20190318100940.GA9919@iiotirae> References: <20190307142304.14508-1-andreas.reichel.ext@siemens.com> <20190307142304.14508-7-andreas.reichel.ext@siemens.com> <20190307155452.7bbea360@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: <20190307155452.7bbea360@md1za8fc.ad001.siemens.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-TUID: w/uA2VW/6aok On Thu, Mar 07, 2019 at 03:54:52PM +0100, Henning Schild wrote: > Am Thu, 7 Mar 2019 15:23:04 +0100 > schrieb "[ext] Andreas J. Reichel" : > > > From: Andreas Reichel > > > > See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891009 > > > > @@ -151,6 +158,10 @@ def get_distro_have_https_source(d, > > is_host=False): return any(source[2].startswith("https://") for > > source in generate_distro_sources(d, is_host)) > > def get_distro_needs_https_support(d, is_host=False): > > As i said somewhere else. Something like > get_distro_overrides > Could be a nice place to just deal with both in one function. So even > having that weird implication to https, we have it all in one place. > > Right now we have to such functions depending on keys, otherwise we > would have two functions returning "https-support" > Maybe it's better to change this in a follow-up patch because this would change code that has nothing to do with my series. Then we can delete get_distro_needs_https_support and make one function for all cases. Andreas > Henning > > > + apt_keys = d.getVar("HAVE_CUSTOM_APT_KEYS", False) > > + if apt_keys: > > + return "https-support" > > + > > if get_distro_have_https_source(d, is_host): > > return "https-support" > > else: > -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082