From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6669723628337102848 X-Received: by 2002:ac2:54b6:: with SMTP id w22mr862034lfk.15.1552916045999; Mon, 18 Mar 2019 06:34:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:43af:: with SMTP id t15ls1502999lfl.8.gmail; Mon, 18 Mar 2019 06:34:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxR5Itp5AALKvqZtXeF1focdlBf1g7no02jJ4w8h+wTf5bhgcHs6wgosEXk7u8tqujD5Nr4 X-Received: by 2002:a19:c50d:: with SMTP id w13mr651232lfe.9.1552916045514; Mon, 18 Mar 2019 06:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552916045; cv=none; d=google.com; s=arc-20160816; b=j9qcyfK4655HrvkDphYkPLXy5W/tIJsh2BO09xS3bdfazUgEbw0w8roNa1aNRWvr5U FN7gHC/+OR4nHCQwj108YKuTW5DEZFSIzgucM5CcescJxRqY2csShDHYuCo/eH7r/lfr 5bat6wLIV8xXwCpo4tCK0CjhnEL0Ohl4rhHaaUyqCTlqwfyKlpDXci8U0HZ5v8z68gbJ rB08V6nI/HmQfc5nQmX+XInd9tzt6m+culkxUFCh5muKbQCI2iDvSv6ga+JSDpNMaNpF RPp+aGT0eRasZgiwxuFw0Fx8cCxbu7wxyKvowMpirBtTURQhcxJtK2e5vVEOs3kPE+/H 2j4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=EoGQvh288+X4iVcSrsp3H85E3qYYufGywBZsBHKBBuI=; b=Gxg55+N3Ed5tQioTreRo2egGgLnC8QKKB/CU9yO5HnICSgSKoxDFA9ht/yRkc5nC8R ab0ivjNb9JHKpr8vo5q/wNgT+7YwKqtC4WGwv/mtQncs6XcdrIl7GIC6WggCccXF3kc8 B9SzHIRoNNah6QoBLXu5wVbtXBt/mooNChVn+lVgNeKqwbW6zy4uh6i0mZwJ50lcJGED tNpB9nGcacWn3Tg8DMD02frBvWQrvZssBsfYNOVrrMXdSD8koR5qViGsQlGIwiEQh6r4 JFvDdd9XcUg5yqjNmkbYa4KGCWqkm6YvABySTM9WGiGeTEMktzRGEU8YOvKZp4Hrzbbp Mlmg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id y1si600947lfe.1.2019.03.18.06.34.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 06:34:05 -0700 (PDT) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x2IDY4ow031036 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 18 Mar 2019 14:34:04 +0100 Received: from localhost.localdomain (golem.ppmd.siemens.net [139.25.69.17]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id x2IDY3t9014851; Mon, 18 Mar 2019 14:34:04 +0100 From: "Andreas J. Reichel" To: isar-users@googlegroups.com Cc: Andreas Reichel Subject: [PATCH v5 4/5] Use apt-key to generate apt-keyring Date: Mon, 18 Mar 2019 14:32:03 +0100 Message-Id: <20190318133205.29705-5-andreas.reichel.ext@siemens.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190318133205.29705-1-andreas.reichel.ext@siemens.com> References: <20190318133205.29705-1-andreas.reichel.ext@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: 5j2ZYzy3ArMH From: Andreas Reichel Use apt-key instead of manually calling gpg. Signed-off-by: Andreas Reichel --- meta/classes/isar-bootstrap-helper.bbclass | 2 ++ meta/conf/bitbake.conf | 1 + .../isar-bootstrap/isar-bootstrap.inc | 30 ++++++++++++++----- 3 files changed, 26 insertions(+), 7 deletions(-) diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass index 38d90fb..d80d941 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass +++ b/meta/classes/isar-bootstrap-helper.bbclass @@ -117,6 +117,7 @@ setup_root_file_system() { export LANG=C export LANGUAGE=C export LC_ALL=C + sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-get update \ -o Dir::Etc::sourcelist="sources.list.d/isar-apt.list" \ -o Dir::Etc::sourceparts="-" \ @@ -126,6 +127,7 @@ setup_root_file_system() { sudo -E chroot "$ROOTFSDIR" /usr/bin/dpkg --add-architecture ${DISTRO_ARCH} sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-get update fi + sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-key update sudo -E chroot "$ROOTFSDIR" \ /usr/bin/apt-get ${APT_ARGS} --download-only $PACKAGES \ ${IMAGE_TRANSIENT_PACKAGES} diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 0e521bb..769ec9a 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -62,6 +62,7 @@ DEBDISTRONAME = "isar" # Isar apt repository paths REPO_ISAR_DIR = "${DEPLOY_DIR}/isar-apt/apt" REPO_ISAR_DB_DIR = "${DEPLOY_DIR}/isar-apt/db" +ISARKEYRING = "/etc/apt/trusted.gpg.d/isar.gpg" # Base apt repository paths REPO_BASE_DIR = "${DL_DIR}/base-apt/apt" diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index 1f8f178..f4d8a9b 100644 --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -23,10 +23,9 @@ APTSRCS = "${WORKDIR}/apt-sources" APTSRCS_INIT = "${WORKDIR}/apt-sources-init" BASEAPTSRCS = "${WORKDIR}/base-apt-sources" APTKEYFILES = "" -APTKEYRING = "${WORKDIR}/apt-keyring.gpg" -DEBOOTSTRAP_KEYRING = "" DEPLOY_ISAR_BOOTSTRAP ?= "" DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales" +DISTRO_BOOTSTRAP_BASE_PACKAGES_append_gnupg = ",gnupg2" DISTRO_APT_PREMIRRORS ?= "${@ "http://ftp\.(\S+\.)?debian.org file:///${REPO_BASE_DIR} \n" if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')) else "" }" @@ -43,7 +42,6 @@ python () { if own_pub_key: aptkeys += own_pub_key.split() - d.setVar("DEBOOTSTRAP_KEYRING", "--keyring ${APTKEYRING}") for key in aptkeys: d.appendVar("SRC_URI", " %s" % key) fetcher = bb.fetch2.Fetch([key], d) @@ -158,6 +156,14 @@ def get_distro_needs_https_support(d, is_host=False): else: return "" +def get_distro_needs_gpg_support(d): + apt_keys = d.getVar("HAVE_CUSTOM_APT_KEYS", False) + if apt_keys: + return "gnupg" + return "" + +OVERRIDES_append = ":${@get_distro_needs_gpg_support(d)}" + def get_distro_source(d, is_host): return get_distro_primary_source_entry(d, is_host)[0] @@ -171,13 +177,17 @@ def get_distro_components_argument(d, is_host): else: return "" +APT_KEYS_DIR := "${WORKDIR}/aptkeys" + +do_generate_keyring[cleandirs] = "${APT_KEYS_DIR}" do_generate_keyring[dirs] = "${DL_DIR}" do_generate_keyring[vardeps] += "DISTRO_APT_KEYS" do_generate_keyring() { if [ -n "${@d.getVar("APTKEYFILES", True) or ""}" ]; then + chmod 777 "${APT_KEYS_DIR}" for keyfile in ${@d.getVar("APTKEYFILES", True)}; do - gpg --no-default-keyring --keyring "${APTKEYRING}" \ - --no-tty --homedir "${DL_DIR}" --import "$keyfile" + cp "$keyfile" "${APT_KEYS_DIR}"/"$(basename "$keyfile")" + sudo apt-key --keyring "${ISARKEYRING}" add "$keyfile" done fi } @@ -221,7 +231,6 @@ isar_bootstrap() { if [ ${IS_HOST} ]; then ${DEBOOTSTRAP} $debootstrap_args \ ${@get_distro_components_argument(d, True)} \ - ${DEBOOTSTRAP_KEYRING} \ "${@get_distro_suite(d, True)}" \ "${ROOTFSDIR}" \ "${@get_distro_source(d, True)}" @@ -230,7 +239,6 @@ isar_bootstrap() { "${DEBOOTSTRAP}" $debootstrap_args \ --arch="${DISTRO_ARCH}" \ ${@get_distro_components_argument(d, False)} \ - ${DEBOOTSTRAP_KEYRING} \ "${@get_distro_suite(d, False)}" \ "${ROOTFSDIR}" \ "${@get_distro_source(d, False)}" @@ -259,6 +267,14 @@ isar_bootstrap() { mkdir -p "${ROOTFSDIR}/etc/apt/apt.conf.d" install -v -m644 "${WORKDIR}/isar-apt.conf" \ "${ROOTFSDIR}/etc/apt/apt.conf.d/50isar.conf" + for keyfile in ${APT_KEYS_DIR}/* + do + kfn="$(basename $keyfile)" + cp $keyfile "${ROOTFSDIR}/tmp/$kfn" + sudo -E chroot "${ROOTFSDIR}" /usr/bin/apt-key \ + --keyring ${ISARKEYRING} add "/tmp/$kfn" + rm "${ROOTFSDIR}/tmp/$kfn" + done if [ "${@get_distro_suite(d, True)}" = "stretch" ] && [ "${@get_host_release().split('.')[0]}" -lt "4" ]; then install -v -m644 "${WORKDIR}/isar-apt-fallback.conf" \ -- 2.21.0