From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6669723628337102848 X-Received: by 2002:a7b:c40e:: with SMTP id k14mr239362wmi.12.1552990708816; Tue, 19 Mar 2019 03:18:28 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:b641:: with SMTP id g62ls349113wmf.11.canary-gmail; Tue, 19 Mar 2019 03:18:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxviEyvwzq+HDkgIMH0S3FyAzh+SRIpzGzhADJE4O+gvn73WKn5Lr9YN8kJK6G80SPMsFS2 X-Received: by 2002:a1c:2d86:: with SMTP id t128mr269320wmt.2.1552990708299; Tue, 19 Mar 2019 03:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552990708; cv=none; d=google.com; s=arc-20160816; b=pgIh41LAtTRJ77J8ryFX0z22y7/R/1Ny/vPJVtTrQEfjmLWQ/RuBVM4sk5Vh1mh9u5 YG9x1mXfjehpGsrtpO4pmcX12mhX6XxBFIsxKOgeEVeVO2E8Ftp2e13nZAVwUpHExyNB PUFkHoOOcRhx1xFmZFffPtY3LswAvl3Ok3EP5tL/o23t84RyAe2o+0q/7Cj4eEBYs0qT pZFMgIuLwCdmYRCYE10R7zYQSemvksnOwzpk1cLA4cj03EzguwjYiX56OdNtXgc5iHcR cFZsntSL4Jkw9meCvuiknma8iK4LvO0bEMkbviWj1otjGC6irOjyi1QDuKzwgzYePWJc vIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:cc:to:from:date; bh=qX6JMpsmrEcW4ZweA8O8sQVIYNa+a8gOnOWzD5jO4Dk=; b=jSEibMEdXrg+4FDJyau16iPoui7siH9epdONzpxPF8BTWrn9edTjyw1w5doUEyKVyW 34GRhilyonw3kHRRPW/Ob/IIEjwVhF6ahAowVdEkggPP4vdDA6oY1MaQc/zEJM93TRXA BJsADuf6B/Hd1/w2R/prIc8pZ0jlVsFx/vl3yVCTd7LEyCiHS/Dfi6vOILXuPctL2N5n /mjdPrTVZlCuFQJ6L2UgqEeDhFQ0G9IEIgwvskbx8+J5m7zYneGTy27IeeynPOjuVjHq yLtIeLnuDUx/wtI6Zqbt/AJNaMxqP9WiiNthPj5uoUURy0Tbt67Ak9WPaPm79T4K7Vmz 8VkA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id n5si686289wrj.0.2019.03.19.03.18.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 03:18:28 -0700 (PDT) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x2JAIR7l031275 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Mar 2019 11:18:27 +0100 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.17]) by mail1.sbs.de (8.15.2/8.15.2) with SMTP id x2JAIRhg021888; Tue, 19 Mar 2019 11:18:27 +0100 Date: Tue, 19 Mar 2019 11:16:28 +0100 From: Andreas Reichel To: "Maxim Yu. Osipov" Cc: isar-users@googlegroups.com Subject: Re: [PATCH v5 0/5] Fix usage of additional apt keys and repos Message-ID: <20190319101628.GA19064@iiotirae> References: <20190318133205.29705-1-andreas.reichel.ext@siemens.com> <3969feb6-c01a-d140-a30f-3755319c192f@ilbers.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: <3969feb6-c01a-d140-a30f-3755319c192f@ilbers.de> User-Agent: Mutt/1.11.4 (2019-03-13) X-TUID: nU8EdgjRjVhh On Mon, Mar 18, 2019 at 04:13:19PM +0100, Maxim Yu. Osipov wrote: > Hi Andreas, > > I've applied your series and "fast" CI build (just call > `./scripts/ci_build.sh -q -f' failed. > > See for details > http://isar-build.org:8080/job/isar_mosipov_develop/61/console > > If you need an account on CI build server - just let me know. > Fix - patchset v5 is on the way... - Andreas > Regards, > Maxim. > > > > On 3/18/19 2:31 PM, Andreas J. Reichel wrote: > > From: Andreas Reichel > > > > Diff to v4: > > * don't remove keyring deployed to target rootfs > > so that one can do updates later > > * keys are temporarily held in WORKDIR/aptkeys, not > > TMPDIR/aptkeys > > * variable renamed from APTKEYTMPDIR to APT_KEYS_DIR > > > > Unchanged with reason: > > * function for retreiving override for https is unchanged, > > since renaming this to one global function > > "get_distro_overrides" is better done in a separate patch. > > This patch should concentrate on getting things finally > > working, before changing too much code that is more or less > > a beautification. > > * (Other comments on mailing list) > > * HAVE_CUSTOM_APT_KEYS is used in patch 4, but introduced in > > patch 5, which is okay here, because we check if it exists... > > > > What this series does: > > * Enable/fix possibility of additional apt repos > > * Enable/fix handling of additional apt keys > > * Deduplicate some code > > > > Signed-off-by: Andreas Reichel > > > > Andreas Reichel (5): > > Revert "isar-bootstrap: Allow to set local keys in DISTRO_APT_KEYS" > > Remove duplicate code from apt-keyring generation > > Fix fetched key location in apt-keyring generator > > Use apt-key to generate apt-keyring > > If we use a custom keyring debootstrap may fall to https > > > > .../conf/multiconfig/qemuamd64-buster.conf | 1 - > > .../conf/multiconfig/qemuamd64-jessie.conf | 1 - > > meta/classes/isar-bootstrap-helper.bbclass | 2 + > > meta/conf/bitbake.conf | 1 + > > .../isar-bootstrap/isar-bootstrap.inc | 62 +++++++++++++------ > > 5 files changed, 47 insertions(+), 20 deletions(-) > > > > > -- > Maxim Osipov > ilbers GmbH > Maria-Merian-Str. 8 > 85521 Ottobrunn > Germany > +49 (151) 6517 6917 > mosipov@ilbers.de > http://ilbers.de/ > Commercial register Munich, HRB 214197 > General Manager: Baurzhan Ismagulov -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082