public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: claudius.heine.ext@siemens.com
To: isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe
Date: Wed, 27 Mar 2019 16:41:24 +0100	[thread overview]
Message-ID: <20190327154124.14663-1-claudius.heine.ext@siemens.com> (raw)

From: Claudius Heine <ch@denx.de>

In machines that have not set those variables, it is stil possible that
those classes are parsed. The parsing itself should not fail in that
case, instead those recipes should just be skipped.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/classes/ubi-img.bbclass   | 2 +-
 meta/classes/ubifs-img.bbclass | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass
index f61a940..777b8c4 100644
--- a/meta/classes/ubi-img.bbclass
+++ b/meta/classes/ubi-img.bbclass
@@ -5,7 +5,7 @@
 
 python() {
     if not d.getVar("UBINIZE_ARGS"):
-        bb.fatal("UBINIZE_ARGS must be set")
+        raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
 }
 
 UBINIZE_CFG ??= "ubinize.cfg"
diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
index ed37357..881d2bb 100644
--- a/meta/classes/ubifs-img.bbclass
+++ b/meta/classes/ubifs-img.bbclass
@@ -5,7 +5,7 @@
 
 python() {
     if not d.getVar("MKUBIFS_ARGS"):
-        bb.fatal("MKUBIFS_ARGS must be set")
+        raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
 }
 
 inherit image
-- 
2.20.1


             reply	other threads:[~2019-03-27 15:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 15:41 claudius.heine.ext [this message]
2019-03-27 15:45 ` Maxim Yu. Osipov
2019-03-27 17:10   ` Henning Schild
2019-03-27 17:12     ` Maxim Yu. Osipov
2019-03-28  7:50 ` [PATCH v2] " claudius.heine.ext
2019-04-24  8:48   ` Claudius Heine
2019-04-25  5:50     ` Maxim Yu. Osipov
2019-07-23 15:29       ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190327154124.14663-1-claudius.heine.ext@siemens.com \
    --to=claudius.heine.ext@siemens.com \
    --cc=ch@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox