Re: [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 27 Mar 2019 16:45:08 +0100
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> On 3/27/19 4:41 PM, claudius.heine.ext@siemens.com wrote:
> > From: Claudius Heine <ch@denx.de>
> > 
> > In machines that have not set those variables, it is stil possible
> > that those classes are parsed. The parsing itself should not fail
> > in that case, instead those recipes should just be skipped.  
> 
> Please use spell checker (especially in commit message before
> submitting patches).

Please use _a_ spell checker when being that picky ;).

Henning

> Maxim.
> 
> > Signed-off-by: Claudius Heine <ch@denx.de>
> > ---
> >   meta/classes/ubi-img.bbclass   | 2 +-
> >   meta/classes/ubifs-img.bbclass | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/classes/ubi-img.bbclass
> > b/meta/classes/ubi-img.bbclass index f61a940..777b8c4 100644
> > --- a/meta/classes/ubi-img.bbclass
> > +++ b/meta/classes/ubi-img.bbclass
> > @@ -5,7 +5,7 @@
> >   
> >   python() {
> >       if not d.getVar("UBINIZE_ARGS"):
> > -        bb.fatal("UBINIZE_ARGS must be set")
> > +        raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
> >   }
> >   
> >   UBINIZE_CFG ??= "ubinize.cfg"
> > diff --git a/meta/classes/ubifs-img.bbclass
> > b/meta/classes/ubifs-img.bbclass index ed37357..881d2bb 100644
> > --- a/meta/classes/ubifs-img.bbclass
> > +++ b/meta/classes/ubifs-img.bbclass
> > @@ -5,7 +5,7 @@
> >   
> >   python() {
> >       if not d.getVar("MKUBIFS_ARGS"):
> > -        bb.fatal("MKUBIFS_ARGS must be set")
> > +        raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
> >   }
> >   
> >   inherit image
> >   
> 
>