From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6673096226406137856 X-Received: by 2002:a2e:47d3:: with SMTP id u202mr435210lja.12.1553706630722; Wed, 27 Mar 2019 10:10:30 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:3612:: with SMTP id d18ls2933222lja.8.gmail; Wed, 27 Mar 2019 10:10:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxI9uiqF8wlWNVNMvzy+kEUwlWN2ylRzbX4xqEM4ry59LzquLixkxkiFBfTxtsQ1/Nv2J3A X-Received: by 2002:a2e:2c07:: with SMTP id s7mr261282ljs.17.1553706630212; Wed, 27 Mar 2019 10:10:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553706630; cv=none; d=google.com; s=arc-20160816; b=Fr3EJ1yYDEVKZaBnlitBk6ULHF1bb/QD+k7fJ+BXaC6ET/FxsUMmdz/eeKIGScDbj+ +HhdiBn3J0K95yAP4zF5RD5TR53niz+xEGyWh2Ck3133Ylv2dA1Wp8S9hy1oxYddhkVZ /pZY+RdcRAApMH521Pjoz9tgsUz6eERNT7P662rFIpiVhhpNzlgTOxT/6pgnC8tA7p+m io3IKae+eerFxX53ey4Tft9Lm1kL9d5y445Cqpk3/+DJvtksRlHQUhqfhuP6Ud+fMzZv sC/ImM+7pwgsIXIw5JkOpjuvUNWO0K1b4s5yEIWEO+eKYWDB2VeRGlAbhRfMjs5XbR39 x9mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=iAfA8IYYaYjRWPmpCTnzOjJAVyFcxfqe4TPdPwoVP0k=; b=Z8ZCnxr6KpqKMAg//S7U8E/4APrtWtaXN1AGeVE9px2JPGpPqyx0tMAvY4UXZf11lw a23VmPyVdjhH+mBCafETAxlhXLCZIbhf+rltXl+lEUfLJicZyuJVXK0y8jASM2EROolj wpeadIVg+08/cxXVeeP1SDCCXoCetwUA0txiuryqdlMF+fc4Pt/X/L/cbdRrAOtmg+DL 22EurD5CVyFgxsTSxcSe+d7ulNVrAoIFPf9gEnqbaEo+cAoc0xaeIE8IoboGY5+gZcrA 86D9Ce2QEvDvbpAG9IvX4sHcah3qaNIc5gVeD+hKDfK8Bo/RAUo7Nn8YKTrvLOj/2GTH w+xg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id a22si459779lfl.3.2019.03.27.10.10.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 10:10:30 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x2RHASuk028874 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Mar 2019 18:10:29 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.71]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x2RHARo4004281; Wed, 27 Mar 2019 18:10:27 +0100 Date: Wed, 27 Mar 2019 18:10:27 +0100 From: Henning Schild To: "Maxim Yu. Osipov" Cc: , , Claudius Heine Subject: Re: [PATCH] ubi-img/ubifs-img: change fatal error to skip recipe Message-ID: <20190327181027.78a0b9ca@md1za8fc.ad001.siemens.net> In-Reply-To: <5c5d2c74-6585-1481-0ce4-6be4e898e708@ilbers.de> References: <20190327154124.14663-1-claudius.heine.ext@siemens.com> <5c5d2c74-6585-1481-0ce4-6be4e898e708@ilbers.de> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: c2sBQP9xX9v/ Am Wed, 27 Mar 2019 16:45:08 +0100 schrieb "Maxim Yu. Osipov" : > On 3/27/19 4:41 PM, claudius.heine.ext@siemens.com wrote: > > From: Claudius Heine > > > > In machines that have not set those variables, it is stil possible > > that those classes are parsed. The parsing itself should not fail > > in that case, instead those recipes should just be skipped. > > Please use spell checker (especially in commit message before > submitting patches). Please use _a_ spell checker when being that picky ;). Henning > Maxim. > > > Signed-off-by: Claudius Heine > > --- > > meta/classes/ubi-img.bbclass | 2 +- > > meta/classes/ubifs-img.bbclass | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meta/classes/ubi-img.bbclass > > b/meta/classes/ubi-img.bbclass index f61a940..777b8c4 100644 > > --- a/meta/classes/ubi-img.bbclass > > +++ b/meta/classes/ubi-img.bbclass > > @@ -5,7 +5,7 @@ > > > > python() { > > if not d.getVar("UBINIZE_ARGS"): > > - bb.fatal("UBINIZE_ARGS must be set") > > + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set") > > } > > > > UBINIZE_CFG ??= "ubinize.cfg" > > diff --git a/meta/classes/ubifs-img.bbclass > > b/meta/classes/ubifs-img.bbclass index ed37357..881d2bb 100644 > > --- a/meta/classes/ubifs-img.bbclass > > +++ b/meta/classes/ubifs-img.bbclass > > @@ -5,7 +5,7 @@ > > > > python() { > > if not d.getVar("MKUBIFS_ARGS"): > > - bb.fatal("MKUBIFS_ARGS must be set") > > + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set") > > } > > > > inherit image > > > >