Re: [PATCHv3] dpkg-base: derive "Package" and "Architecture" from .deb in cleanup

[Baurzhan Ismagulov <ibr@radix50.net>]

Hello Henning,

On Thu, Feb 21, 2019 at 04:56:34PM +0100, Henning Schild wrote:
> If
> your recipe created such a package it could never be cleaned because it
> was added to all the archs of the repo, and later cleaned only from one.
> Now if that package changes because you are still working on the recipe,
> adding the package again would cause checksum mismatches for all but the
> current architecture.

IMHO, it's unclear who is "you" in the commit message. I'd suggest to reword in
a more neutral form, e.g.:

-your recipe created such a package it could never be cleaned because it
+a recipe created such a package it could never be cleaned because it
...
-Now if that package changes because you are still working on the recipe,
+Now if that package changes because one is still working on the recipe,


> +            p=$( dpkg-deb --show --showformat '${Package}' ${d} )
> +            a=$( dpkg-deb --show --showformat '${Architecture}' ${d} )

Thanks, this is better than sed.


> +            reprepro -b ${REPO_ISAR_DIR}/${DISTRO} \
> +                     --dbdir ${REPO_ISAR_DB_DIR}/${DISTRO} \
> +                     -C main ${aarg} \
> +                     remove ${DEBDISTRONAME} \
> +                     ${p}

How can one reproduce the problem? I'd like to understand the cause because at
the first glance I'd think an _all.deb package should land in the pool only
once.

In general, subtle stuff like this should ideally be covered with a test case.


With kind regards,
Baurzhan.