From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6659727571892043776 X-Received: by 2002:a2e:975a:: with SMTP id f26mr22588ljj.5.1553771011723; Thu, 28 Mar 2019 04:03:31 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:96ce:: with SMTP id d14ls3241324ljj.5.gmail; Thu, 28 Mar 2019 04:03:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1vQzzvM+sYMAR4abRtzOYiuEWB9AHRESjkGzrkxddiUvEZMlzdnchjhkOKr9QPDTRwyXW X-Received: by 2002:a2e:944f:: with SMTP id o15mr801932ljh.28.1553771011278; Thu, 28 Mar 2019 04:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553771011; cv=none; d=google.com; s=arc-20160816; b=urcfWiUknEFme5S9BwWVMqEK15zmINVhBWNa12GdnW/Nw9zoUC0LgOSLkyDOwEa9aW Ppfzxfl1+o9iGTj3NN7zdXio/efxL+eRk1xPm8EOaXcdyrOrnAOKCgyIwCMr8SYfNkhQ PUJ2up4Y8A3+k7IEPV5rQwveranHBWnXEm8/r2XNF+VtdBtz+5VIQDNmme3vw/OZhauG BKd68wiJaWWCWFyqW25YCvZU7Vv8EtiWSIcfM5Q8DGDRSn3kAIiXlNbhN0WHS9Rc3151 pFQV2EkR6lHPyzq7nBr+09aTxpvPcbNDZ22ec5VL483n0K4ONac2S5wca6GfwCHlOeXn dBrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=6/j+PSSTF/0ja4AhR2MVDMr0pvIMHVR82EU5JNIM1IY=; b=KnTkWEQRFmfuvXSbTVFu21m5NVUcIyr3yOtXoXBE2WfOXGDtoCnOuTEThuoavMMfaH 0bo/2r3HIbBqhg1+k2gciuPzPU/aSBlTPfMsEimyCMdds3t6FZSkAB2vSiHExlfD2PIQ Kmyu3aKqt5emBv2Jx0NIor+6Nd036NX64kz59kqxJEMz93ZFr9x8twKOhS4a89g3VSRN 3dQQSwYTuiCvQYI360DtK/VFX3+dmERuh3yIAKaxNZJOJ03pPDg1VNCQs5BsAqmhtQY8 Sc3SIpUWS0b01+u57pRu8ZzYjonlxo0XEF+kR0Aj4DPiLBchhOc9ZkEBNL3qbtlaZ/r8 eNUQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id v89si267642lje.4.2019.03.28.04.03.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 04:03:31 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2SB3SnM005195 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 28 Mar 2019 12:03:30 +0100 Date: Thu, 28 Mar 2019 12:03:28 +0100 From: Baurzhan Ismagulov To: isar-users Subject: Re: [PATCHv3] dpkg-base: derive "Package" and "Architecture" from .deb in cleanup Message-ID: <20190328110328.GG1437@yssyq.m.ilbers.de> Mail-Followup-To: isar-users References: <20190221155634.20706-1-henning.schild@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190221155634.20706-1-henning.schild@siemens.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: Kb4t4svT4eDx Hello Henning, On Thu, Feb 21, 2019 at 04:56:34PM +0100, Henning Schild wrote: > If > your recipe created such a package it could never be cleaned because it > was added to all the archs of the repo, and later cleaned only from one. > Now if that package changes because you are still working on the recipe, > adding the package again would cause checksum mismatches for all but the > current architecture. IMHO, it's unclear who is "you" in the commit message. I'd suggest to reword in a more neutral form, e.g.: -your recipe created such a package it could never be cleaned because it +a recipe created such a package it could never be cleaned because it ... -Now if that package changes because you are still working on the recipe, +Now if that package changes because one is still working on the recipe, > + p=$( dpkg-deb --show --showformat '${Package}' ${d} ) > + a=$( dpkg-deb --show --showformat '${Architecture}' ${d} ) Thanks, this is better than sed. > + reprepro -b ${REPO_ISAR_DIR}/${DISTRO} \ > + --dbdir ${REPO_ISAR_DB_DIR}/${DISTRO} \ > + -C main ${aarg} \ > + remove ${DEBDISTRONAME} \ > + ${p} How can one reproduce the problem? I'd like to understand the cause because at the first glance I'd think an _all.deb package should land in the pool only once. In general, subtle stuff like this should ideally be covered with a test case. With kind regards, Baurzhan.