From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6675671320760418304 X-Received: by 2002:ac2:568f:: with SMTP id 15mr780199lfr.7.1555440541122; Tue, 16 Apr 2019 11:49:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:5bc1:: with SMTP id m62ls878623lje.2.gmail; Tue, 16 Apr 2019 11:49:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwelzGqRSekvMwglszNE49J3SPvx0nns48gnCx0K1tk5qdi/t/OFlehVAuwIXkRyZO/kUBh X-Received: by 2002:a2e:2c07:: with SMTP id s7mr4257228ljs.17.1555440540519; Tue, 16 Apr 2019 11:49:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555440540; cv=none; d=google.com; s=arc-20160816; b=SbeKvHR6B2EoPC3blRgwcfXr7ReO6BwcXh6KpqJ6U/cQWHXbQh8zqiVhhkAuq+tv30 H4++OHQeYSdqySZXN6cEhfmvhyouEZdeQkdctdhnBKjnEhneyB3t7ATOsRyQnLST3cXw uBuPkrWMplk9GALvokwbewoEduHF2H1VdOTsBebw+CYWI/DIJLuBywLCFNyI3q7yF+Fz ZprSEVxuGjdjhrOH4LqUpGCfQ/DXUPXL+qg4usb0ww99TVQUCndxieFUopCqjHll96gu SvP/y2NhkgPrj1H9/22RgOAc91SRCIrLvbat6nxGYJstUR1jKtzsMjDD1kugbjd8Apd/ Qo+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=ATKyOvCAexac7lrDcVe0XAVomqKNSc19I+biYnx/UW8=; b=Sa/btk7UsJIsRISJvwaJVUbH+gXICbFRvCvw5nHAhE6KFXG35qH0Zq0bmyeUyTkk8t XkA6QVE0ebQyFzeLZ43wc0J0Rz/iWp6QY4wj9H9cGVrcnx6sXekDeNPlI+SKpRe+L1R6 f6ck2hUzrSsQ30vMm2+wV5v8y63pwt60mzRlLyldNP7yHAKfN7aKQZgbFiRz3EQkSR2S WgDwxoDwXbDU60Q5eodCpyj6BQUaKg4jqtK7IUMnXLECIuhj9Yk0T8Z0VldWJPZAN8p8 mKaxbLozAyDBU7IaSBgEZqBXK+Ku92x/Jn5KR0983RBrcXzTVoSNqDb+E2b+lzfPUMwa fjOw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id f16si469267lfh.3.2019.04.16.11.49.00 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 11:49:00 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (dslb-084-061-174-254.084.061.pools.vodafone-ip.de [84.61.174.254]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x3GImw6G002181 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Apr 2019 20:48:59 +0200 Date: Tue, 16 Apr 2019 20:48:53 +0200 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH v2] testsuite: Initial Avocado test implementation Message-ID: <20190416184853.GB2115@yssyq.m.ilbers.de> Mail-Followup-To: isar-users@googlegroups.com References: <20190403141407.17694-1-ibr@radix50.net> <7079e446-fe4b-5d87-9e44-c3d4ad50ba57@ilbers.de> <20190416103427.2ab226de@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416103427.2ab226de@md1za8fc.ad001.siemens.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: cHQbExax3/uL On Tue, Apr 16, 2019 at 10:34:27AM +0200, Henning Schild wrote: > I would suggest to remove that again and feed it back to reviewing. The > content is hardly reviewed because the first round was lacking basic > things like a commit message. The commit message issue was commented upon and addressed. Questions were answered. If you have further feedback, we'd like to discuss it. I don't see any point in moving backwards. > > > + parser.add_argument('-d', '--distro', choices=['jessie', > > > 'stretch'], help='set isar Debian distribution.', default='stretch') > > When rewriting we should take the chance and call these guys "suites" > not "distros". According to e.g. sources.list(5), "The distribution is generally a suite name like stable or testing or a codename like stretch or buster". I agree that the existing code uses distro and suite interchangably. Our users work with codenames, since suites change with time. So, I think "suite" would not be appropriate for this particular case. I also tend to call it "distro", it happens to apply 99% of the time and is much more intuitive for non-Debian people. So, in this case I'd support "distro", although it might not be absolutely correct in some rare cases. > > > + output_file = '/tmp/vm_boot_test.log' > > > + if os.path.exists(output_file): > > > + os.remove(output_file) > > Do these tests run in parrallel? If so we need a file for every run. > Even if not "tempfile" might be the way to go. I agree, tempfile is better even without concurrency. We'll provide a patch. With kind regards, Baurzhan.