[PATCH v4 0/9] Cleanup rootfs creation

[PATCH v4 0/9] Cleanup rootfs creation

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Hi,

so after some debugging 'fast' build now succeeds:
http://isar-build.org:8080/job/isar_claudius_ilbers_fast_ci/15/

I needed a patch that removes the DISTRO_APT_KEYS from the isar-bootstrap-host
as well as some fixes to the paths when cross-compiling. Also raspbian only
supports debian-stretch as HOST_DISTRO.

Well the lessons learned from this is that the 'standard' CI build does not
test cross-compiling as I would have assumed and that there is a 'fast' CI
build configuration that tests this.

Also some investigation into why rpi-stretch:isar-bootstrap-host accepted a
keyring with the raspberry pi keys for building a ordinary debian stretch
rootfs at some point needs to happen. There might be a task ordering issue
hidden there.

regards,
Claudius

P.S. The 'standard' CI build for this is still running. I got 
'E: Couldn't download packages: libpam0g' while bootstraping, which
sound like a issue that might be fixed by restarting the build. Maybe using
an apt-cacher as proxy might help?


changes from v3:
 - added patch for isar-bootstrap-host
 - fixed HOST_DISTRO for raspbian-stretch
 - fixed cross-compiling paths

changes from v2:
 - replaced 'ROOTFS_ARCH' with 'HOST_ARCH' in sdkchroot.bb to avoid
   populate_sdk issue

changes from v1:
 - fixed typo in commit message

Claudius Heine (9):
  isar-bootstrap-host: disable DISTRO_APT_KEYS usage
  isar-bootstrap-helper: move 'HOST_ARCH' and 'HOST_DISTRO' to
    base.bbclass
  move 'HOST_DISTRO_APT_SOURCES' from bootstrap-helper to isar-bootstrap
  buildchroot.bbclass: only cross build if HOST_ARCH != DISTRO_ARCH
  isar-bootstrap/buildchroot/sdkchroot: refactor PF and WORKDIR
  bitbake.conf: remove unneeded and differently used variables
  image.bbclass: make IMAGE_ROOTFS overwritable
  bitbake.conf: set default QEMU_ARCH variables
  buildchroot/configscript: make creation of builder uid/gid idempotent

 meta-isar/conf/multiconfig/rpi-stretch.conf    |  1 +
 meta/classes/base.bbclass                      |  9 +++++++++
 meta/classes/buildchroot.bbclass               |  2 +-
 meta/classes/image-sdk-extension.bbclass       |  2 +-
 meta/classes/image.bbclass                     |  2 +-
 meta/classes/isar-bootstrap-helper.bbclass     | 18 ++----------------
 meta/conf/bitbake.conf                         | 13 ++++++++-----
 .../isar-bootstrap/isar-bootstrap-host.bb      | 13 +++++--------
 .../isar-bootstrap/isar-bootstrap-target.bb    |  6 +-----
 .../isar-bootstrap/isar-bootstrap.inc          |  1 +
 .../buildchroot/buildchroot-host.bb            |  4 ++--
 .../buildchroot/buildchroot.inc                |  3 +--
 .../buildchroot/files/configscript.sh          |  4 ++--
 meta/recipes-devtools/sdkchroot/sdkchroot.bb   |  5 ++---
 14 files changed, 37 insertions(+), 46 deletions(-)

-- 
2.20.1

[PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

isar-bootstrap-host only supports bootstrapping Debian root file
systems. Therefore deactivate any DISTRO_APT_KEYS from other
distributions.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
index 08b068f..3e96281 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
@@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
 ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
 
 require isar-bootstrap.inc
+# We only build debian host buildchroot environments
+DISTRO_APT_KEYS = ""
 inherit isar-bootstrap-helper
 
 do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
-- 
2.20.1

[PATCH v4 2/9] isar-bootstrap-helper: move 'HOST_ARCH' and 'HOST_DISTRO' to base.bbclass

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

This also sets the 'HOST_DISTRO' to 'DISTRO' per default. (jessie
support was dropped.)

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta-isar/conf/multiconfig/rpi-stretch.conf |  1 +
 meta/classes/base.bbclass                   |  9 +++++++++
 meta/classes/isar-bootstrap-helper.bbclass  | 12 ------------
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/meta-isar/conf/multiconfig/rpi-stretch.conf b/meta-isar/conf/multiconfig/rpi-stretch.conf
index ec1f71d..f3fac38 100644
--- a/meta-isar/conf/multiconfig/rpi-stretch.conf
+++ b/meta-isar/conf/multiconfig/rpi-stretch.conf
@@ -12,6 +12,7 @@ MACHINE ?= "rpi"
 # This sets the default distribution configuration:
 DISTRO ?= "raspbian-stretch"
 DISTRO_ARCH ?= "armhf"
+HOST_DISTRO ?= "debian-stretch"
 
 KERNEL_NAME ?= "rpi-rpfv"
 
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 9a1837f..ca80bf8 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -20,6 +20,15 @@
 
 THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
 
+def get_deb_host_arch():
+    import subprocess
+    host_arch = subprocess.check_output(
+        ["dpkg", "--print-architecture"]
+    ).decode('utf-8').strip()
+    return host_arch
+HOST_ARCH ??= "${@get_deb_host_arch()}"
+HOST_DISTRO ??= "${DISTRO}"
+
 die() {
 	bbfatal "$*"
 }
diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index 38d90fb..59c447b 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -7,18 +7,6 @@
 
 IMAGE_TRANSIENT_PACKAGES ??= ""
 
-def get_deb_host_arch():
-    import subprocess
-    host_arch = subprocess.check_output(
-        ["dpkg", "--print-architecture"]
-    ).decode('utf-8').strip()
-    return host_arch
-
-#Debian Distribution for SDK host
-HOST_DISTRO ?= "debian-stretch"
-#Determine SDK host architecture if not explicitly set
-HOST_ARCH ?= "${@get_deb_host_arch()}"
-
 HOST_DISTRO_APT_SOURCES += "conf/distro/${HOST_DISTRO}.list"
 
 def reverse_bb_array(d, varname):
-- 
2.20.1

[PATCH v4 3/9] move 'HOST_DISTRO_APT_SOURCES' from bootstrap-helper to isar-bootstrap

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

This variable is only used in 'isar-bootstrap-host.bb' and mentioned in
'isar-bootstrap.inc'. So it does not make sense to have it available
anywhere else.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/classes/isar-bootstrap-helper.bbclass          | 2 --
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index 59c447b..0d77929 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -7,8 +7,6 @@
 
 IMAGE_TRANSIENT_PACKAGES ??= ""
 
-HOST_DISTRO_APT_SOURCES += "conf/distro/${HOST_DISTRO}.list"
-
 def reverse_bb_array(d, varname):
     array = d.getVar(varname, True)
     if array is None:
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index c1b571a..0ec2e2b 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -27,6 +27,7 @@ APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
 DEBOOTSTRAP_KEYRING = ""
 DEPLOY_ISAR_BOOTSTRAP ?= ""
 DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales"
+HOST_DISTRO_APT_SOURCES += "conf/distro/${HOST_DISTRO}.list"
 
 DISTRO_APT_PREMIRRORS ?= "${@ "http://ftp\.(\S+\.)?debian.org  file:///${REPO_BASE_DIR} \n" if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')) else "" }"
 
-- 
2.20.1

[PATCH v4 4/9] buildchroot.bbclass: only cross build if HOST_ARCH != DISTRO_ARCH

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/classes/buildchroot.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass
index 1a87bf4..ea1538a 100644
--- a/meta/classes/buildchroot.bbclass
+++ b/meta/classes/buildchroot.bbclass
@@ -8,7 +8,7 @@ ISAR_CROSS_COMPILE ??= "0"
 # Add dependency from the correct buildchroot: host or target
 python __anonymous() {
     mode = d.getVar('ISAR_CROSS_COMPILE', True)
-    if mode == "0":
+    if mode == "0" or d.getVar('HOST_ARCH') == d.getVar('DISTRO_ARCH'):
         dep = "buildchroot-target:do_build"
         rootfs = d.getVar('BUILDCHROOT_TARGET_DIR', True)
     else:
-- 
2.20.1

[PATCH v4 5/9] isar-bootstrap/buildchroot/sdkchroot: refactor PF and WORKDIR

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Each of those are dependent on both HOST_ARCH and DISTRO_ARCH, so the
stamps etc. should not be shared.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/classes/image-sdk-extension.bbclass              |  2 +-
 meta/classes/isar-bootstrap-helper.bbclass            |  4 ++--
 meta/conf/bitbake.conf                                |  4 ++--
 .../isar-bootstrap/isar-bootstrap-host.bb             | 11 +++--------
 .../isar-bootstrap/isar-bootstrap-target.bb           |  6 +-----
 meta/recipes-devtools/buildchroot/buildchroot-host.bb |  4 ++--
 meta/recipes-devtools/buildchroot/buildchroot.inc     |  3 +--
 meta/recipes-devtools/sdkchroot/sdkchroot.bb          |  5 ++---
 8 files changed, 14 insertions(+), 25 deletions(-)

diff --git a/meta/classes/image-sdk-extension.bbclass b/meta/classes/image-sdk-extension.bbclass
index 1838080..8df3ed1 100644
--- a/meta/classes/image-sdk-extension.bbclass
+++ b/meta/classes/image-sdk-extension.bbclass
@@ -5,7 +5,7 @@
 #
 # This class extends the image.bbclass to supply the creation of a sdk
 
-SDKCHROOT_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/sdkchroot-${HOST_DISTRO}-${HOST_ARCH}"
+SDKCHROOT_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/sdkchroot-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}"
 
 do_populate_sdk[stamp-extra-info] = "${DISTRO}-${MACHINE}"
 do_populate_sdk[depends] = "sdkchroot:do_build"
diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index 0d77929..8612be2 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -52,8 +52,8 @@ setup_root_file_system() {
         --clean) CLEAN=1 ;;
         --copyisarapt) COPYISARAPT=1 ;;
         --fstab) FSTAB=$2; shift ;;
-        --host-arch) ROOTFS_ARCH=${HOST_ARCH} ;;
-        --host-distro) ROOTFS_DISTRO=${HOST_DISTRO} ;;
+        --host-arch) ROOTFS_ARCH="$2-$ROOTFS_ARCH"; shift ;;
+        --host-distro) ROOTFS_DISTRO="$2"; shift ;;
         --keep-apt-cache) KEEP_APT_CACHE=1 ;;
         -*) bbfatal "$0: invalid option specified: $1" ;;
         *) break ;;
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 0e521bb..9eb14ac 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -50,8 +50,8 @@ DEPLOY_DIR_BOOTSTRAP = "${DEPLOY_DIR}/bootstrap"
 DEPLOY_DIR_IMAGE = "${DEPLOY_DIR}/images/${MACHINE}"
 DL_DIR ?= "${TOPDIR}/downloads"
 SSTATE_DIR ?= "${TMPDIR}/sstate-cache"
-BUILDCHROOT_HOST_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot-host/rootfs"
-BUILDCHROOT_TARGET_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot-target/rootfs"
+BUILDCHROOT_HOST_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot-host-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}/rootfs"
+BUILDCHROOT_TARGET_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/buildchroot-target-${DISTRO}-${DISTRO_ARCH}/rootfs"
 CACHE = "${TMPDIR}/cache"
 
 OVERRIDES = "${DISTRO_ARCH}:${MACHINE}:${DISTRO}:forcevariable"
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
index 3e96281..2e2e6d1 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
@@ -6,19 +6,15 @@
 # SPDX-License-Identifier: MIT
 
 Description = "Minimal host Debian root file system"
+PF = "${PN}-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}"
 
-WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}-${HOST_DISTRO}-${HOST_ARCH}"
-DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
-ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
+DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}"
+ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}.lock"
 
 require isar-bootstrap.inc
 # We only build debian host buildchroot environments
 DISTRO_APT_KEYS = ""
-inherit isar-bootstrap-helper
 
-do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
-
-do_apt_config_prepare[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 do_apt_config_prepare[dirs] = "${WORKDIR}"
 do_apt_config_prepare[vardeps] += "\
                                    APTPREFS \
@@ -49,7 +45,6 @@ addtask apt_config_prepare before do_bootstrap after do_unpack
 
 OVERRIDES_append = ":${@get_distro_needs_https_support(d, True)}"
 
-do_bootstrap[stamp-extra-info] = "${HOST_DISTRO}-${HOST_ARCH}"
 do_bootstrap[vardeps] += "HOST_DISTRO_APT_SOURCES"
 do_bootstrap() {
     isar_bootstrap --host
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
index 79f3e34..552a317 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
@@ -6,16 +6,13 @@
 # SPDX-License-Identifier: MIT
 
 Description = "Minimal target Debian root file system"
+PF = "${PN}-${DISTRO}-${DISTRO_ARCH}"
 
-WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
 DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${DISTRO}-${DISTRO_ARCH}"
 ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${DISTRO}-${DISTRO_ARCH}.lock"
 
 require isar-bootstrap.inc
 
-do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
-
-do_apt_config_prepare[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 do_apt_config_prepare[dirs] = "${WORKDIR}"
 do_apt_config_prepare[vardeps] += "\
                                    APTPREFS \
@@ -44,7 +41,6 @@ addtask apt_config_prepare before do_bootstrap after do_unpack
 
 OVERRIDES_append = ":${@get_distro_needs_https_support(d, False)}"
 
-do_bootstrap[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 do_bootstrap[vardeps] += "DISTRO_APT_SOURCES"
 do_bootstrap() {
     isar_bootstrap
diff --git a/meta/recipes-devtools/buildchroot/buildchroot-host.bb b/meta/recipes-devtools/buildchroot/buildchroot-host.bb
index c8c10c0..12a1fdf 100644
--- a/meta/recipes-devtools/buildchroot/buildchroot-host.bb
+++ b/meta/recipes-devtools/buildchroot/buildchroot-host.bb
@@ -6,6 +6,7 @@
 DESCRIPTION = "Isar development filesystem for host"
 
 require buildchroot.inc
+PF = "${PN}-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}"
 
 BUILDCHROOT_PREINSTALL ?= "make \
                            debhelper \
@@ -26,6 +27,5 @@ BUILDCHROOT_PREINSTALL_append_armhf += "binutils-arm-linux-gnueabihf \
 BUILDCHROOT_PREINSTALL_append_arm64 += "binutils-aarch64-linux-gnu \
                                         crossbuild-essential-arm64"
 
-
-PARAMS = "--host-arch --host-distro"
+PARAMS = "--host-arch '${HOST_ARCH}' --host-distro '${HOST_DISTRO}'"
 do_build[depends] = "isar-apt:do_cache_config isar-bootstrap-host:do_bootstrap"
diff --git a/meta/recipes-devtools/buildchroot/buildchroot.inc b/meta/recipes-devtools/buildchroot/buildchroot.inc
index 764bc5e..cdb4c07 100644
--- a/meta/recipes-devtools/buildchroot/buildchroot.inc
+++ b/meta/recipes-devtools/buildchroot/buildchroot.inc
@@ -12,13 +12,12 @@ SRC_URI = "file://configscript.sh \
            file://common.sh \
            file://deps.sh"
 PV = "1.0"
+PF = "${PN}-${DISTRO}-${DISTRO_ARCH}"
 
 inherit isar-bootstrap-helper
 
-WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
 BUILDCHROOT_DIR = "${WORKDIR}/rootfs"
 
-do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 do_build[root_cleandirs] = "${BUILDCHROOT_DIR} \
                             ${BUILDCHROOT_DIR}/isar-apt \
                             ${BUILDCHROOT_DIR}/downloads \
diff --git a/meta/recipes-devtools/sdkchroot/sdkchroot.bb b/meta/recipes-devtools/sdkchroot/sdkchroot.bb
index 895a454..49aeb47 100644
--- a/meta/recipes-devtools/sdkchroot/sdkchroot.bb
+++ b/meta/recipes-devtools/sdkchroot/sdkchroot.bb
@@ -14,6 +14,7 @@ SRC_URI = " \
 PV = "0.1"
 
 inherit isar-bootstrap-helper
+PF = "${PN}-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}"
 
 SDKCHROOT_PREINSTALL := "debhelper \
                            autotools-dev \
@@ -25,11 +26,9 @@ SDKCHROOT_PREINSTALL := "debhelper \
                            devscripts \
                            equivs"
 
-WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}-${HOST_DISTRO}-${HOST_ARCH}"
 S = "${WORKDIR}/rootfs"
 
 do_build[dirs] = "${DEPLOY_DIR_IMAGE}"
-do_build[stamp-extra-info] = "${HOST_DISTRO}-${HOST_ARCH}"
 do_build[root_cleandirs] = "${S} \
                             ${S}/isar-apt"
 
@@ -50,7 +49,7 @@ do_build() {
         packages="${SDKCHROOT_PREINSTALL} crossbuild-essential-${DISTRO_ARCH}"
     fi
 
-    setup_root_file_system --copyisarapt --host-arch --host-distro "${S}" $packages
+    setup_root_file_system --copyisarapt --host-arch '${HOST_ARCH}' --host-distro '${HOST_DISTRO}' "${S}" $packages
 
     # Configure root filesystem
     sudo install -m 644 ${WORKDIR}/README.sdk ${S}
-- 
2.20.1

[PATCH v4 6/9] bitbake.conf: remove unneeded and differently used variables

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

IMAGE_CMD and TARGET_ARCH are not used in Isar or any bitbake code.

IMAGE_ROOTFS is used as the directory where image recipes store their
root file system. Pointing that to a global path like '${TMPDIR}/rootfs'
does not make sense for Isar.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/conf/bitbake.conf | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 9eb14ac..dda7bf1 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -26,8 +26,6 @@ DEPLOY_DIR = "${TMPDIR}/deploy"
 FILESPATH = "${FILE_DIRNAME}/${PF}:${FILE_DIRNAME}/${P}:${FILE_DIRNAME}/${PN}:${FILE_DIRNAME}/files:${FILE_DIRNAME}"
 FILE_DIRNAME = "${@os.path.dirname(d.getVar('FILE', False))}"
 GITDIR = "${DL_DIR}/git"
-IMAGE_CMD = "_NO_DEFINED_IMAGE_TYPES_"
-IMAGE_ROOTFS = "${TMPDIR}/rootfs"
 P = "${PN}-${PV}"
 PF = "${PN}-${PV}-${PR}"
 PN = "${@bb.parse.BBHandler.vars_from_file(d.getVar('FILE', False),d)[0] or 'defaultpkgname'}"
@@ -39,7 +37,6 @@ SRC_URI = "file://${FILE}"
 STAMP = "${TMPDIR}/stamps/${PF}"
 SVNDIR = "${DL_DIR}/svn"
 T = "${WORKDIR}/temp"
-TARGET_ARCH = "${BUILD_ARCH}"
 TMPDIR = "${TOPDIR}/tmp"
 PERSISTENT_DIR = "${TMPDIR}/cache"
 GITPKGV = "${@bb.fetch2.get_srcrev(d, 'gitpkgv_revision')}"
-- 
2.20.1

[PATCH v4 7/9] image.bbclass: make IMAGE_ROOTFS overwritable

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

This way recipes that inherit image.bbclass can set this path
themselves. This was previously not possible, because the bitbake.conf
set this variable with '='.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index f9a3052..6881d37 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -5,7 +5,7 @@ PF = "${PN}-${DISTRO}-${MACHINE}"
 
 IMAGE_INSTALL ?= ""
 IMAGE_TYPE    ?= "ext4-img"
-IMAGE_ROOTFS   = "${WORKDIR}/rootfs"
+IMAGE_ROOTFS ?= "${WORKDIR}/rootfs"
 
 IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME", True)) if d.getVar("KERNEL_NAME", True) else ""}"
 
-- 
2.20.1

[PATCH v4 8/9] bitbake.conf: set default QEMU_ARCH variables

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/conf/bitbake.conf | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index dda7bf1..be9c3a8 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -53,6 +53,12 @@ CACHE = "${TMPDIR}/cache"
 
 OVERRIDES = "${DISTRO_ARCH}:${MACHINE}:${DISTRO}:forcevariable"
 
+# Setting default QEMU_ARCH variables for different DISTRO_ARCH:
+QEMU_ARCH_amd64 = "x86_64"
+QEMU_ARCH_i386 = "i386"
+QEMU_ARCH_armhf = "arm"
+QEMU_ARCH_arm64 = "aarch64"
+
 # Codename of the repository created by the caching class
 DEBDISTRONAME = "isar"
 
-- 
2.20.1

[PATCH v4 9/9] buildchroot/configscript: make creation of builder uid/gid idempotent

[claudius.heine.ext]

From: Claudius Heine <ch@denx.de>

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/recipes-devtools/buildchroot/files/configscript.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/buildchroot/files/configscript.sh b/meta/recipes-devtools/buildchroot/files/configscript.sh
index 25a21ef..c4d8cf8 100644
--- a/meta/recipes-devtools/buildchroot/files/configscript.sh
+++ b/meta/recipes-devtools/buildchroot/files/configscript.sh
@@ -10,6 +10,6 @@ locales locales/locales_to_be_generated multiselect en_US.UTF-8 UTF-8
 locales locales/default_environment_locale select en_US.UTF-8
 END
 
-groupadd --system builder -o --gid $2
-useradd --system -o --uid $1 --gid builder --no-create-home --home /home/builder --no-user-group --comment "Isar buildchroot build user" builder
+grep -q "builder:x:$2" /etc/group || groupadd -f --system builder -o --gid $2
+grep -q "builder:x:$1" /etc/passwd || useradd --system -o --uid $1 --gid builder --no-create-home --home /home/builder --no-user-group --comment "Isar buildchroot build user" builder
 chown -R builder:builder /home/builder
-- 
2.20.1

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Maxim Yu. Osipov]

On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> isar-bootstrap-host only supports bootstrapping Debian root file
> systems. Therefore deactivate any DISTRO_APT_KEYS from other
> distributions.
> 
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>   meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> index 08b068f..3e96281 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>   ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>   
>   require isar-bootstrap.inc
> +# We only build debian host buildchroot environments
> +DISTRO_APT_KEYS = ""

 From the first glance this modification limits functionality.
It looks like a hack and I would suggest to avoid this modification.

Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to 
avoid confusion between target and host apt keys.


Maxim.



>   inherit isar-bootstrap-helper
>   
>   do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Claudius Heine]

[-- Attachment #1: Type: text/plain, Size: 2924 bytes --]

Hi Maxim,

Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> > From: Claudius Heine <ch@denx.de>
> > 
> > isar-bootstrap-host only supports bootstrapping Debian root file
> > systems. Therefore deactivate any DISTRO_APT_KEYS from other
> > distributions.
> > 
> > Signed-off-by: Claudius Heine <ch@denx.de>
> > ---
> >   meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > index 08b068f..3e96281 100644
> > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
> >   ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
> >   
> >   require isar-bootstrap.inc
> > +# We only build debian host buildchroot environments
> > +DISTRO_APT_KEYS = ""
> 
>  From the first glance this modification limits functionality.
> It looks like a hack and I would suggest to avoid this modification.

Well it is a fix and that limited functionality was already present but
just implicit, hidden behind some bug and the cleanup just made it
appear.

> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to 
> avoid confusion between target and host apt keys.

Good idea. But that would be a new feature/improvement.

Also thanks for looking at the code!

Claudius

> 
> 
> Maxim.
> 
> 
> 
> >   inherit isar-bootstrap-helper
> >   
> >   do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> > 
> 
> 
> -- 
> Maxim Osipov
> ilbers GmbH
> Maria-Merian-Str. 8
> 85521 Ottobrunn
> Germany
> +49 (151) 6517 6917
> mosipov@ilbers.de
> http://ilbers.de/
> Commercial register Munich, HRB 214197
> General Manager: Baurzhan Ismagulov
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To post to this group, send email to isar-users@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de.
> For more options, visit https://groups.google.com/d/optout.

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlzCtQwACgkQEXPLGZgI
sVPbFBAAkU6wWKvx56TEGQ/INClJLSlHec9QbPesSbjfHb9AxW79UUwj3ZtYfhUo
IAU3LA3GXI7E7eDrqKmrTE2DDFH7vuWFc310AFdXMkeCfg1w+f1GVOIuqmw5rVOs
YTnpKs9q1h6PzySPkrtM7QBei4Dc/GHHmJpAUvWGUWgxwzOans9PMNr4nwPeNAZs
4aR4QQkXLMiBxELN0pI4ua42IQonkhMDHH2JuV3SUpOYKtiiKU89fK3witMRN/Ln
fTDhcs6S2qAPZJson1mRx01PECnfmP/n/930uflgxmTVZNyOqML3/UIyt5J+cV8e
/OxtwtYBeD7YNJaAHRXd0F+vOtCteBQEfMsro4pjG1bx2svEvoQ6fU6nCtopSZtT
OGYAEtP3zbdxDPwfmoiDUDFpfxLwlvoAACafRNSWBN5Q8rvQZd6Vna81nxyQXeUD
WpqPitrr93sFGvCGffVkX6JADwkPp0vgxtmFJ1hhCQPIWRcuQdoU0It945Hf7TOf
OnZuczIamokDkBx7RfvI/6D/WX6E0WHkAS8ZHdb0uTkFIlIpQ2xPyChQGv5AuTC1
nnGzzcjizD+marwruDg+rMQ4NfIWWVuIP2nRlZD7cmVNDN12ndM4nxuwVVXhIPDF
S5IDtchIkU0Djo3OvozeejEpyFI70zsgW9Lxv0mzbJIjwlbTEF8=
=8wKQ
-----END PGP SIGNATURE-----

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Maxim Yu. Osipov]

Hi Claudius, Andreas,

@Andreas
Your input is very welcome at this topic as you were busy with all this 
APT keys stuff.

On 4/26/19 9:36 AM, Claudius Heine wrote:
> Hi Maxim,
> 
> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>> distributions.
>>>
>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>> ---
>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> index 08b068f..3e96281 100644
>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>    ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>    
>>>    require isar-bootstrap.inc
>>> +# We only build debian host buildchroot environments
>>> +DISTRO_APT_KEYS = ""
>>
>>   From the first glance this modification limits functionality.
>> It looks like a hack and I would suggest to avoid this modification.
> 
> Well it is a fix and that limited functionality was already present but
> just implicit, hidden behind some bug and the cleanup just made it
> appear.


Could you please point to this hidden, implicit place where mentioned 
bug persists?

I've looked under meta/recipes-core/isar-bootstrap/

It seems that keyring stuff is quite symmetrical (in terms of host/target):

isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring *
isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] = 
"${DISTRO}-${DISTRO_ARCH}"
isar-bootstrap-host.bb:addtask bootstrap before do_build after 
do_generate_keyring
isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = ""
isar-bootstrap.inc:        d.setVar("DEBOOTSTRAP_KEYRING", "--keyring 
${APTKEYRING}")
isar-bootstrap.inc:            d.setVar("DEBOOTSTRAP_KEYRING", 
"--keyring ${APTKEYRING}")
isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}"
isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS"
isar-bootstrap.inc:do_generate_keyring() {
isar-bootstrap.inc:           gpg --no-default-keyring --keyring 
"${APTKEYRING}" \
isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack
isar-bootstrap.inc:                               ${DEBOOTSTRAP_KEYRING} \
isar-bootstrap.inc: 
${DEBOOTSTRAP_KEYRING} \
isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] = 
"${DISTRO}-${DISTRO_ARCH}"
isar-bootstrap-target.bb:addtask bootstrap before do_build after 
do_generate_keyring
isar/meta/recipes-core/isar-bootstrap$


And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc) 
differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing 
regarding

             if [ ${IS_HOST} ]; then
                 ${DEBOOTSTRAP} $debootstrap_args \
                                ${@get_distro_components_argument(d, 
True)} \
                                ${DEBOOTSTRAP_KEYRING} \
                                "${@get_distro_suite(d, True)}" \
                                "${ROOTFSDIR}" \
                                "${@get_distro_source(d, True)}"

             else
                  "${DEBOOTSTRAP}" $debootstrap_args \
                                   --arch="${DISTRO_ARCH}" \
                                   ${@get_distro_components_argument(d, 
False)} \
                                   ${DEBOOTSTRAP_KEYRING} \
                                   "${@get_distro_suite(d, False)}" \
                                   "${ROOTFSDIR}" \
                                   "${@get_distro_source(d, False)}"
             fi




> 
>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>> avoid confusion between target and host apt keys.
> 
> Good idea. But that would be a new feature/improvement.

Yes. But your series is also improvement, isn't?

I need more arguments for introduction of this limitation.

Maxim.

> Also thanks for looking at the code!
> 
> Claudius
> 
>>
>>
>> Maxim.
>>
>>
>>
>>>    inherit isar-bootstrap-helper
>>>    
>>>    do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>>>
>>
>>
>> -- 
>> Maxim Osipov
>> ilbers GmbH
>> Maria-Merian-Str. 8
>> 85521 Ottobrunn
>> Germany
>> +49 (151) 6517 6917
>> mosipov@ilbers.de
>> http://ilbers.de/
>> Commercial register Munich, HRB 214197
>> General Manager: Baurzhan Ismagulov
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups "isar-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
>> To post to this group, send email to isar-users@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de.
>> For more options, visit https://groups.google.com/d/optout.
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
> 
>             PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
>                               Keyserver: hkp://pool.sks-keyservers.net
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Claudius Heine]

[-- Attachment #1: Type: text/plain, Size: 4067 bytes --]

Quoting Maxim Yu. Osipov (2019-04-26 10:41:16)
> Hi Claudius, Andreas,
> 
> @Andreas
> Your input is very welcome at this topic as you were busy with all this 
> APT keys stuff.
> 
> On 4/26/19 9:36 AM, Claudius Heine wrote:
> > Hi Maxim,
> > 
> > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
> >> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> >>> From: Claudius Heine <ch@denx.de>
> >>>
> >>> isar-bootstrap-host only supports bootstrapping Debian root file
> >>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
> >>> distributions.
> >>>
> >>> Signed-off-by: Claudius Heine <ch@denx.de>
> >>> ---
> >>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> >>>    1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> >>> index 08b068f..3e96281 100644
> >>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> >>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> >>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
> >>>    ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
> >>>    
> >>>    require isar-bootstrap.inc
> >>> +# We only build debian host buildchroot environments
> >>> +DISTRO_APT_KEYS = ""
> >>
> >>   From the first glance this modification limits functionality.
> >> It looks like a hack and I would suggest to avoid this modification.
> > 
> > Well it is a fix and that limited functionality was already present but
> > just implicit, hidden behind some bug and the cleanup just made it
> > appear.
> 
> 
> Could you please point to this hidden, implicit place where mentioned 
> bug persists?

The HOST_DISTRO is set to 'debian-stretch' in
isar-bootstrap-helper.bbclass (included by isar-bootstrap-host.bb)
results in isar-bootstap-host only bootstrapping debian-stretch
repositories, since the 'HOST_DISTRO_APT_SOURCES' (set in
isar-bootstrap.inc) variable only points to 'debian-stretch.list'.

Yes that is quite a mess of spaghetti code, which this patch set is
trying to sort out somewhat and also probably why this patch set now
reveals some hidden bugs or limitations like this.

A patch later in this patch series sets 'HOST_DISTRO' to 'DISTRO' per
default. But that only opens the possibility to use other debian
versions (buster) for buildchroot-host, not allowing non-debian distros.
So the implicit limitation is somewhat loosened with this patch series.

> And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc) 
> differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing 
> regarding

Well 'isar-bootstrap-host' does contain some issues that needs fixing but
this is not in scope of this patch series, which focuses mainly on
the rootfs creation process and only secondary on the isar-bootstrap*
stuff.

> >> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
> >> avoid confusion between target and host apt keys.
> > 
> > Good idea. But that would be a new feature/improvement.
> 
> Yes. But your series is also improvement, isn't?

With that reasoning you could also say that my patch series should fix
every issue in existence because that might be an 'improvement'.

Fixing the world is not in scope of this patch set.

> I need more arguments for introduction of this limitation.

Again, that limitation is already present. I don't get why you are
often so sure of yourself, especially about code you have not written
or worked with intensively.

Claudius

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlzC39sACgkQEXPLGZgI
sVM/lg//XmkmaozLfqJGtO7wVVzu/o8DBe8on1k99BcTQRLZyg1uOwlYt8fSFGFw
3m6t5Gkmbjp8UoVQ4c24Pd3FDrX96HZppenfg+oZT3Gz6hsQ7K1xQ6cgcJ9Zdhjm
ByfLoT2Zc3SymYnXNxPkR0GMD7F8moAnrxmq+DueXTAGJ2INDCUg+su6KxTCApoN
A6Cw/YJ1/LwnVbJuJfx43GsVkuYOaQlZ/b0YTzQ2J2U2AuxEiOrF7IX+jq9CasUQ
+36rCppcl363TYLrtvHq2ybpIBh+Zfc9d3PdNPjAY6YQVxqUH4pQ4+gPsp/hjjGC
l0BsJyxnMmoSnczOfSFC5nWjvE9by65SvoOfkRHiLLUM55ByelpLuyFsCLV2B5vH
TCkxaH6MiWNYJ731GsOMzcSPk4Ncx88edbC221YBS4RQUxp5Kggi+yIVsg718T3M
DpxaU8AbBVNGRMWHRmxpSNi6Q1zkhaOFAMWb3F6iJjeNqW/pslUMOsLGJEFhehfg
gqzkPWLr+dhsHiHGmuo7Kc99RRBduseAwLuuFdGLa0luqjn5N35z2bSWFyXT/pJi
5aDS+v4DQjgcY2CO89jiQcWhJP5zn4i1FcXHjbkGsiQayBbQubmGuDn24OHFwOhT
4QmheXhBpiJYIyH2TKiahIMbHo6xH+n3pxz4YdiUqj3yLOBHeH8=
=3D5v
-----END PGP SIGNATURE-----

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Claudius Heine]

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

Quoting Claudius Heine (2019-04-26 12:39:27)
> Quoting Maxim Yu. Osipov (2019-04-26 10:41:16)
> > I need more arguments for introduction of this limitation.
> 
> Again, that limitation is already present. I don't get why you are
> often so sure of yourself, especially about code you have not written
> or worked with intensively.

Ok sorry, I take that back. You have written and worked with this code.
I thought that was written mostly by Alex.

Claudius

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlzC4UcACgkQEXPLGZgI
sVPnXw/+PR/47KyXyEqlFxonzOlqfubs5TFP88HYzBhwOf1BsqTT+O4Ene0VrhX4
Yz8tIhuHR30dixDaKxrgZPq2dqccMKYtt67M7AYHTUPpIrSeD3Z6b1xDBB9b5CHY
XBTmPTog/RJPiyFVcdHfJcbQjlVoiwK29N+Id07SapBKZMtpDWy4bOCtf8tUi7M/
PoM+y8qxLyU18AbqhwEbHar0uaT2KUVQcl481iq/vvdYZHQCqIMxmFKQ/SWjjitX
kl4BWly0SatfqfH1U2YO75a+cPwLUWDzVRJtk2e9blDLadgMgzxRvjKecxnd/XBL
gttMcCVWhDkK+9o7fXJjMNJom+vR2HgIMkjWCImsQ2aaYckkS7hDB8a6NP2UJvUZ
6Vf3mKFjfMqQJsXv9W3IIJpT7Ozn1zs4iF627LsKWQoWFUXvRMzl7MhLYP2Jo/N9
n7W1NqRkQu4LGjpteOB+7iC0lUqPTJQtXEBHOIKsFwKZ9DNrUZIIqxc1aMaArzq1
+fQyUCmjjInJlKNPQgvahnsd+1wkKQqEhwm/lFhI3CBqMCHZ7JhXZdiGOqxuSBV2
AxHiZnnH41Hh8G/eyrik9bnIimZZwJlre1WX4vB5v6sahvQBKDIBNGQF0VRUzTLB
v2fR4Ayj7/rK8KG7a55aQQXPHBgtW3NlA4XSv1Rj3D6MG3YW4ww=
=yxww
-----END PGP SIGNATURE-----

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Maxim Yu. Osipov]

On 4/26/19 12:45 PM, Claudius Heine wrote:
> Quoting Claudius Heine (2019-04-26 12:39:27)
>> Quoting Maxim Yu. Osipov (2019-04-26 10:41:16)
>>> I need more arguments for introduction of this limitation.
>>
>> Again, that limitation is already present. I don't get why you are
>> often so sure of yourself, especially about code you have not written
>> or worked with intensively.

I suggest you to choose the correct words before writing such kind of 
sentences. I'm not a boy and you are not my mentor.

> Ok sorry, I take that back. You have written and worked with this code.
> I thought that was written mostly by Alex.

It doesn't matter if this my code or not.

I'm quite tired from this offensive style of communication - I consider 
such style as misbehavior. I hope that was my last warning to you.

Maxim.

> Claudius
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
> 
>             PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
>                               Keyserver: hkp://pool.sks-keyservers.net
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Jan Kiszka]

On 26.04.19 09:36, Claudius Heine wrote:
> Hi Maxim,
> 
> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>> distributions.
>>>
>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>> ---
>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> index 08b068f..3e96281 100644
>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>    ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>    
>>>    require isar-bootstrap.inc
>>> +# We only build debian host buildchroot environments
>>> +DISTRO_APT_KEYS = ""
>>
>>   From the first glance this modification limits functionality.
>> It looks like a hack and I would suggest to avoid this modification.
> 
> Well it is a fix and that limited functionality was already present but
> just implicit, hidden behind some bug and the cleanup just made it
> appear.
> 
>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>> avoid confusion between target and host apt keys.
> 
> Good idea. But that would be a new feature/improvement.
> 

If that is just about adding and documenting another variable, let's not discuss 
about when and who because just doing that will already be faster, even if it's 
a "drive-by" improvement /wrt this patchset.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Jan Kiszka]

On 26.04.19 13:22, Maxim Yu. Osipov wrote:
> On 4/26/19 12:45 PM, Claudius Heine wrote:
>> Quoting Claudius Heine (2019-04-26 12:39:27)
>>> Quoting Maxim Yu. Osipov (2019-04-26 10:41:16)
>>>> I need more arguments for introduction of this limitation.
>>>
>>> Again, that limitation is already present. I don't get why you are
>>> often so sure of yourself, especially about code you have not written
>>> or worked with intensively.
> 
> I suggest you to choose the correct words before writing such kind of sentences. 
> I'm not a boy and you are not my mentor.
> 
>> Ok sorry, I take that back. You have written and worked with this code.
>> I thought that was written mostly by Alex.
> 
> It doesn't matter if this my code or not.
> 
> I'm quite tired from this offensive style of communication - I consider such 
> style as misbehavior. I hope that was my last warning to you.
> 

In general, I would appreciate when everyone focuses more again on understanding 
the issues we still have in code base and tooling, rather then discussing about 
where they came from, who to blame and who should therefore fix them. And the 
result needs to be understandable for the core contributors - and ideally not 
only for them.

Of course, if there is evidence that a particular way of working is inefficient, 
a way of designing is causing problems too often, please make that transparent, 
with facts.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Jan Kiszka]

On 26.04.19 13:31, [ext] Jan Kiszka wrote:
> On 26.04.19 09:36, Claudius Heine wrote:
>> Hi Maxim,
>>
>> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>>> From: Claudius Heine <ch@denx.de>
>>>>
>>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>>> distributions.
>>>>
>>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>>> ---
>>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb 
>>>> b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> index 08b068f..3e96281 100644
>>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = 
>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>>    ISAR_BOOTSTRAP_LOCK = 
>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>>    require isar-bootstrap.inc
>>>> +# We only build debian host buildchroot environments
>>>> +DISTRO_APT_KEYS = ""
>>>
>>>   From the first glance this modification limits functionality.
>>> It looks like a hack and I would suggest to avoid this modification.
>>
>> Well it is a fix and that limited functionality was already present but
>> just implicit, hidden behind some bug and the cleanup just made it
>> appear.
>>
>>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>>> avoid confusion between target and host apt keys.
>>
>> Good idea. But that would be a new feature/improvement.
>>
> 
> If that is just about adding and documenting another variable, let's not discuss 
> about when and who because just doing that will already be faster, even if it's 
> a "drive-by" improvement /wrt this patchset.
> 

OTOH, I don't get the problem yet from just reading the commit message: Wasn't 
DISTRO_APT_KEYS designed to be a superset of all needed keys? We are appending 
raspbian to it when using that distro. So, we are at least missing the reasoning 
here why that model didn't work and cannot be made working for the host/target 
case. And then we can refer to that when introducing split key sets.

Thanks,
Jan


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Andreas Reichel]

On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote:
> Hi Claudius, Andreas,
> 
> @Andreas
> Your input is very welcome at this topic as you were busy with all this APT
> keys stuff.
> 

Thank you. Well in my eyes, Claudius delivers important changes to Isar
which improve code quality and the build steps as a whole. Also as I
know him, he is never ever interested in any personal "affairs" whatsoever,
which I also learnt from his reviews on my code. He has a sharp mind and
always tries to get out the best of the code up to his knowledge and
techniques. Furthermore, if he may sometimes sound direct or even
annoying to some - this is merely a personal question of how one focuses
on mails. I also did not understand everything he criticized on my code
in the beginning - but after I understood him, it was always great
improvement. So, Maxim, I beg that you do not take anything personal on
any mail, regarding any words or writing style but just focus on the
code as I always try - which always helps to go on further with the
project and to improve it. That's my input.

Andreas

> On 4/26/19 9:36 AM, Claudius Heine wrote:
> > Hi Maxim,
> > 
> > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
> > > On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> > > > From: Claudius Heine <ch@denx.de>
> > > > 
> > > > isar-bootstrap-host only supports bootstrapping Debian root file
> > > > systems. Therefore deactivate any DISTRO_APT_KEYS from other
> > > > distributions.
> > > > 
> > > > Signed-off-by: Claudius Heine <ch@denx.de>
> > > > ---
> > > >    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> > > >    1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > index 08b068f..3e96281 100644
> > > > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
> > > >    ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
> > > >    require isar-bootstrap.inc
> > > > +# We only build debian host buildchroot environments
> > > > +DISTRO_APT_KEYS = ""
> > > 
> > >   From the first glance this modification limits functionality.
> > > It looks like a hack and I would suggest to avoid this modification.
> > 
> > Well it is a fix and that limited functionality was already present but
> > just implicit, hidden behind some bug and the cleanup just made it
> > appear.
> 
> 
> Could you please point to this hidden, implicit place where mentioned bug
> persists?
> 
> I've looked under meta/recipes-core/isar-bootstrap/
> 
> It seems that keyring stuff is quite symmetrical (in terms of host/target):
> 
> isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring *
> isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] =
> "${DISTRO}-${DISTRO_ARCH}"
> isar-bootstrap-host.bb:addtask bootstrap before do_build after
> do_generate_keyring
> isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
> isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = ""
> isar-bootstrap.inc:        d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
> ${APTKEYRING}")
> isar-bootstrap.inc:            d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
> ${APTKEYRING}")
> isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}"
> isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS"
> isar-bootstrap.inc:do_generate_keyring() {
> isar-bootstrap.inc:           gpg --no-default-keyring --keyring
> "${APTKEYRING}" \
> isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack
> isar-bootstrap.inc:                               ${DEBOOTSTRAP_KEYRING} \
> isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \
> isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] =
> "${DISTRO}-${DISTRO_ARCH}"
> isar-bootstrap-target.bb:addtask bootstrap before do_build after
> do_generate_keyring
> isar/meta/recipes-core/isar-bootstrap$
> 
> 
> And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc)
> differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing
> regarding
> 
>             if [ ${IS_HOST} ]; then
>                 ${DEBOOTSTRAP} $debootstrap_args \
>                                ${@get_distro_components_argument(d, True)} \
>                                ${DEBOOTSTRAP_KEYRING} \
>                                "${@get_distro_suite(d, True)}" \
>                                "${ROOTFSDIR}" \
>                                "${@get_distro_source(d, True)}"
> 
>             else
>                  "${DEBOOTSTRAP}" $debootstrap_args \
>                                   --arch="${DISTRO_ARCH}" \
>                                   ${@get_distro_components_argument(d,
> False)} \
>                                   ${DEBOOTSTRAP_KEYRING} \
>                                   "${@get_distro_suite(d, False)}" \
>                                   "${ROOTFSDIR}" \
>                                   "${@get_distro_source(d, False)}"
>             fi
> 
> 
> 
> 
> > 
> > > Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
> > > avoid confusion between target and host apt keys.
> > 
> > Good idea. But that would be a new feature/improvement.
> 
> Yes. But your series is also improvement, isn't?
> 
> I need more arguments for introduction of this limitation.
> 
> Maxim.
> 
> > Also thanks for looking at the code!
> > 
> > Claudius
> > 
> > > 
> > > 
> > > Maxim.
> > > 
> > > 
> > > 
> > > >    inherit isar-bootstrap-helper
> > > >    do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> > > > 
> > > 
> > > 
> > > -- 
> > > Maxim Osipov
> > > ilbers GmbH
> > > Maria-Merian-Str. 8
> > > 85521 Ottobrunn
> > > Germany
> > > +49 (151) 6517 6917
> > > mosipov@ilbers.de
> > > http://ilbers.de/
> > > Commercial register Munich, HRB 214197
> > > General Manager: Baurzhan Ismagulov
> > > 
> > > -- 
> > > You received this message because you are subscribed to the Google Groups "isar-users" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> > > To post to this group, send email to isar-users@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de.
> > > For more options, visit https://groups.google.com/d/optout.
> > 
> > --
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
> > 
> >             PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
> >                               Keyserver: hkp://pool.sks-keyservers.net
> > 
> 
> 
> -- 
> Maxim Osipov
> ilbers GmbH
> Maria-Merian-Str. 8
> 85521 Ottobrunn
> Germany
> +49 (151) 6517 6917
> mosipov@ilbers.de
> http://ilbers.de/
> Commercial register Munich, HRB 214197
> General Manager: Baurzhan Ismagulov

-- 
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

Andreas.Reichel@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Maxim Yu. Osipov]

On 4/30/19 12:34 PM, Andreas Reichel wrote:
> On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote:
>> Hi Claudius, Andreas,
>>
>> @Andreas
>> Your input is very welcome at this topic as you were busy with all this APT
>> keys stuff.
>>
> 
> Thank you. Well in my eyes, Claudius delivers important changes to Isar
> which improve code quality and the build steps as a whole. Also as I
> know him, he is never ever interested in any personal "affairs" whatsoever,
> which I also learnt from his reviews on my code. He has a sharp mind and
> always tries to get out the best of the code up to his knowledge and
> techniques. Furthermore, if he may sometimes sound direct or even
> annoying to some - this is merely a personal question of how one focuses
> on mails. I also did not understand everything he criticized on my code
> in the beginning - but after I understood him, it was always great
> improvement. So, Maxim, I beg that you do not take anything personal on
> any mail, regarding any words or writing style but just focus on the
> code as I always try - which always helps to go on further with the
> project and to improve it. That's my input.
> 
> Andreas

I would prefer to focus on technical aspects of the modification under 
review. Are you OK with this modification?

Regards,
Maxim.

>> On 4/26/19 9:36 AM, Claudius Heine wrote:
>>> Hi Maxim,
>>>
>>> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>>>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>>>> From: Claudius Heine <ch@denx.de>
>>>>>
>>>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>>>> distributions.
>>>>>
>>>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>>>> ---
>>>>>     meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>>>     1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> index 08b068f..3e96281 100644
>>>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>>>     ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>>>     require isar-bootstrap.inc
>>>>> +# We only build debian host buildchroot environments
>>>>> +DISTRO_APT_KEYS = ""
>>>>
>>>>    From the first glance this modification limits functionality.
>>>> It looks like a hack and I would suggest to avoid this modification.
>>>
>>> Well it is a fix and that limited functionality was already present but
>>> just implicit, hidden behind some bug and the cleanup just made it
>>> appear.
>>
>>
>> Could you please point to this hidden, implicit place where mentioned bug
>> persists?
>>
>> I've looked under meta/recipes-core/isar-bootstrap/
>>
>> It seems that keyring stuff is quite symmetrical (in terms of host/target):
>>
>> isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring *
>> isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] =
>> "${DISTRO}-${DISTRO_ARCH}"
>> isar-bootstrap-host.bb:addtask bootstrap before do_build after
>> do_generate_keyring
>> isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
>> isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = ""
>> isar-bootstrap.inc:        d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
>> ${APTKEYRING}")
>> isar-bootstrap.inc:            d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
>> ${APTKEYRING}")
>> isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}"
>> isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS"
>> isar-bootstrap.inc:do_generate_keyring() {
>> isar-bootstrap.inc:           gpg --no-default-keyring --keyring
>> "${APTKEYRING}" \
>> isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack
>> isar-bootstrap.inc:                               ${DEBOOTSTRAP_KEYRING} \
>> isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \
>> isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] =
>> "${DISTRO}-${DISTRO_ARCH}"
>> isar-bootstrap-target.bb:addtask bootstrap before do_build after
>> do_generate_keyring
>> isar/meta/recipes-core/isar-bootstrap$
>>
>>
>> And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc)
>> differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing
>> regarding
>>
>>              if [ ${IS_HOST} ]; then
>>                  ${DEBOOTSTRAP} $debootstrap_args \
>>                                 ${@get_distro_components_argument(d, True)} \
>>                                 ${DEBOOTSTRAP_KEYRING} \
>>                                 "${@get_distro_suite(d, True)}" \
>>                                 "${ROOTFSDIR}" \
>>                                 "${@get_distro_source(d, True)}"
>>
>>              else
>>                   "${DEBOOTSTRAP}" $debootstrap_args \
>>                                    --arch="${DISTRO_ARCH}" \
>>                                    ${@get_distro_components_argument(d,
>> False)} \
>>                                    ${DEBOOTSTRAP_KEYRING} \
>>                                    "${@get_distro_suite(d, False)}" \
>>                                    "${ROOTFSDIR}" \
>>                                    "${@get_distro_source(d, False)}"
>>              fi
>>
>>
>>
>>
>>>
>>>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>>>> avoid confusion between target and host apt keys.
>>>
>>> Good idea. But that would be a new feature/improvement.
>>
>> Yes. But your series is also improvement, isn't?
>>
>> I need more arguments for introduction of this limitation.
>>
>> Maxim.
>>
>>> Also thanks for looking at the code!
>>>
>>> Claudius
>>>
>>>>
>>>>
>>>> Maxim.
>>>>
>>>>
>>>>
>>>>>     inherit isar-bootstrap-helper
>>>>>     do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>>>>>
>>>>
>>>>
>>>> -- 
>>>> Maxim Osipov
>>>> ilbers GmbH
>>>> Maria-Merian-Str. 8
>>>> 85521 Ottobrunn
>>>> Germany
>>>> +49 (151) 6517 6917
>>>> mosipov@ilbers.de
>>>> http://ilbers.de/
>>>> Commercial register Munich, HRB 214197
>>>> General Manager: Baurzhan Ismagulov
>>>>
>>>> -- 
>>>> You received this message because you are subscribed to the Google Groups "isar-users" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
>>>> To post to this group, send email to isar-users@googlegroups.com.
>>>> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>> --
>>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
>>>
>>>              PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
>>>                                Keyserver: hkp://pool.sks-keyservers.net
>>>
>>
>>
>> -- 
>> Maxim Osipov
>> ilbers GmbH
>> Maria-Merian-Str. 8
>> 85521 Ottobrunn
>> Germany
>> +49 (151) 6517 6917
>> mosipov@ilbers.de
>> http://ilbers.de/
>> Commercial register Munich, HRB 214197
>> General Manager: Baurzhan Ismagulov
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Andreas Reichel]

On Tue, Apr 30, 2019 at 04:30:46PM +0300, Maxim Yu. Osipov wrote:
> On 4/30/19 12:34 PM, Andreas Reichel wrote:
> > On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote:
> > > Hi Claudius, Andreas,
> > > 
> > > @Andreas
> > > Your input is very welcome at this topic as you were busy with all this APT
> > > keys stuff.
> > > 
> > 
> > Thank you. Well in my eyes, Claudius delivers important changes to Isar
> > which improve code quality and the build steps as a whole. Also as I
> > know him, he is never ever interested in any personal "affairs" whatsoever,
> > which I also learnt from his reviews on my code. He has a sharp mind and
> > always tries to get out the best of the code up to his knowledge and
> > techniques. Furthermore, if he may sometimes sound direct or even
> > annoying to some - this is merely a personal question of how one focuses
> > on mails. I also did not understand everything he criticized on my code
> > in the beginning - but after I understood him, it was always great
> > improvement. So, Maxim, I beg that you do not take anything personal on
> > any mail, regarding any words or writing style but just focus on the
> > code as I always try - which always helps to go on further with the
> > project and to improve it. That's my input.
> > 
> > Andreas
> 
> I would prefer to focus on technical aspects of the modification under
> review. Are you OK with this modification?
> 
I am OK with these.

However I want MY patch series (version 9) merged before this one,
because it is now very well reviewed and weeks old.
And please don't argue with failed CI now. Investigating, understanding
and fixing CI is a different topic and out of my scope.

Regards,
Andreas

> Regards,
> Maxim.
> 
> > > On 4/26/19 9:36 AM, Claudius Heine wrote:
> > > > Hi Maxim,
> > > > 
> > > > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
> > > > > On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> > > > > > From: Claudius Heine <ch@denx.de>
> > > > > > 
> > > > > > isar-bootstrap-host only supports bootstrapping Debian root file
> > > > > > systems. Therefore deactivate any DISTRO_APT_KEYS from other
> > > > > > distributions.
> > > > > > 
> > > > > > Signed-off-by: Claudius Heine <ch@denx.de>
> > > > > > ---
> > > > > >     meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> > > > > >     1 file changed, 2 insertions(+)
> > > > > > 
> > > > > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > > > index 08b068f..3e96281 100644
> > > > > > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > > > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > > > @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
> > > > > >     ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
> > > > > >     require isar-bootstrap.inc
> > > > > > +# We only build debian host buildchroot environments
> > > > > > +DISTRO_APT_KEYS = ""
> > > > > 
> > > > >    From the first glance this modification limits functionality.
> > > > > It looks like a hack and I would suggest to avoid this modification.
> > > > 
> > > > Well it is a fix and that limited functionality was already present but
> > > > just implicit, hidden behind some bug and the cleanup just made it
> > > > appear.
> > > 
> > > 
> > > Could you please point to this hidden, implicit place where mentioned bug
> > > persists?
> > > 
> > > I've looked under meta/recipes-core/isar-bootstrap/
> > > 
> > > It seems that keyring stuff is quite symmetrical (in terms of host/target):
> > > 
> > > isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring *
> > > isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] =
> > > "${DISTRO}-${DISTRO_ARCH}"
> > > isar-bootstrap-host.bb:addtask bootstrap before do_build after
> > > do_generate_keyring
> > > isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
> > > isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = ""
> > > isar-bootstrap.inc:        d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
> > > ${APTKEYRING}")
> > > isar-bootstrap.inc:            d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
> > > ${APTKEYRING}")
> > > isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}"
> > > isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS"
> > > isar-bootstrap.inc:do_generate_keyring() {
> > > isar-bootstrap.inc:           gpg --no-default-keyring --keyring
> > > "${APTKEYRING}" \
> > > isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack
> > > isar-bootstrap.inc:                               ${DEBOOTSTRAP_KEYRING} \
> > > isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \
> > > isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] =
> > > "${DISTRO}-${DISTRO_ARCH}"
> > > isar-bootstrap-target.bb:addtask bootstrap before do_build after
> > > do_generate_keyring
> > > isar/meta/recipes-core/isar-bootstrap$
> > > 
> > > 
> > > And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc)
> > > differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing
> > > regarding
> > > 
> > >              if [ ${IS_HOST} ]; then
> > >                  ${DEBOOTSTRAP} $debootstrap_args \
> > >                                 ${@get_distro_components_argument(d, True)} \
> > >                                 ${DEBOOTSTRAP_KEYRING} \
> > >                                 "${@get_distro_suite(d, True)}" \
> > >                                 "${ROOTFSDIR}" \
> > >                                 "${@get_distro_source(d, True)}"
> > > 
> > >              else
> > >                   "${DEBOOTSTRAP}" $debootstrap_args \
> > >                                    --arch="${DISTRO_ARCH}" \
> > >                                    ${@get_distro_components_argument(d,
> > > False)} \
> > >                                    ${DEBOOTSTRAP_KEYRING} \
> > >                                    "${@get_distro_suite(d, False)}" \
> > >                                    "${ROOTFSDIR}" \
> > >                                    "${@get_distro_source(d, False)}"
> > >              fi
> > > 
> > > 
> > > 
> > > 
> > > > 
> > > > > Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
> > > > > avoid confusion between target and host apt keys.
> > > > 
> > > > Good idea. But that would be a new feature/improvement.
> > > 
> > > Yes. But your series is also improvement, isn't?
> > > 
> > > I need more arguments for introduction of this limitation.
> > > 
> > > Maxim.
> > > 
> > > > Also thanks for looking at the code!
> > > > 
> > > > Claudius
> > > > 
> > > > > 
> > > > > 
> > > > > Maxim.
> > > > > 
> > > > > 
> > > > > 
> > > > > >     inherit isar-bootstrap-helper
> > > > > >     do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> > > > > > 
> > > > > 
> > > > > 
> > > > > -- 
> > > > > Maxim Osipov
> > > > > ilbers GmbH
> > > > > Maria-Merian-Str. 8
> > > > > 85521 Ottobrunn
> > > > > Germany
> > > > > +49 (151) 6517 6917
> > > > > mosipov@ilbers.de
> > > > > http://ilbers.de/
> > > > > Commercial register Munich, HRB 214197
> > > > > General Manager: Baurzhan Ismagulov
> > > > > 
> > > > > -- 
> > > > > You received this message because you are subscribed to the Google Groups "isar-users" group.
> > > > > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> > > > > To post to this group, send email to isar-users@googlegroups.com.
> > > > > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de.
> > > > > For more options, visit https://groups.google.com/d/optout.
> > > > 
> > > > --
> > > > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > > > Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
> > > > 
> > > >              PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
> > > >                                Keyserver: hkp://pool.sks-keyservers.net
> > > > 
> > > 
> > > 
> > > -- 
> > > Maxim Osipov
> > > ilbers GmbH
> > > Maria-Merian-Str. 8
> > > 85521 Ottobrunn
> > > Germany
> > > +49 (151) 6517 6917
> > > mosipov@ilbers.de
> > > http://ilbers.de/
> > > Commercial register Munich, HRB 214197
> > > General Manager: Baurzhan Ismagulov
> > 
> 
> 
> -- 
> Maxim Osipov
> ilbers GmbH
> Maria-Merian-Str. 8
> 85521 Ottobrunn
> Germany
> +49 (151) 6517 6917
> mosipov@ilbers.de
> http://ilbers.de/
> Commercial register Munich, HRB 214197
> General Manager: Baurzhan Ismagulov

-- 
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

Andreas.Reichel@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Jan Kiszka]

On 30.04.19 17:22, Andreas Reichel wrote:
> On Tue, Apr 30, 2019 at 04:30:46PM +0300, Maxim Yu. Osipov wrote:
>> On 4/30/19 12:34 PM, Andreas Reichel wrote:
>>> On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote:
>>>> Hi Claudius, Andreas,
>>>>
>>>> @Andreas
>>>> Your input is very welcome at this topic as you were busy with all this APT
>>>> keys stuff.
>>>>
>>>
>>> Thank you. Well in my eyes, Claudius delivers important changes to Isar
>>> which improve code quality and the build steps as a whole. Also as I
>>> know him, he is never ever interested in any personal "affairs" whatsoever,
>>> which I also learnt from his reviews on my code. He has a sharp mind and
>>> always tries to get out the best of the code up to his knowledge and
>>> techniques. Furthermore, if he may sometimes sound direct or even
>>> annoying to some - this is merely a personal question of how one focuses
>>> on mails. I also did not understand everything he criticized on my code
>>> in the beginning - but after I understood him, it was always great
>>> improvement. So, Maxim, I beg that you do not take anything personal on
>>> any mail, regarding any words or writing style but just focus on the
>>> code as I always try - which always helps to go on further with the
>>> project and to improve it. That's my input.
>>>
>>> Andreas
>>
>> I would prefer to focus on technical aspects of the modification under
>> review. Are you OK with this modification?
>>
> I am OK with these.
> 
> However I want MY patch series (version 9) merged before this one,
> because it is now very well reviewed and weeks old.
> And please don't argue with failed CI now. Investigating, understanding
> and fixing CI is a different topic and out of my scope.

So, to state this differently: You observation is that current next or master 
does not reliably build in Isar upstream CI, right? Then this issue would be of 
topmost priority to understand and resolve.

Andreas, Henning, Claudius, do we have current references to upstream CI build 
with that behaviour, even if that was sporadic?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Maxim Yu. Osipov]

On 4/30/19 6:22 PM, Andreas Reichel wrote:
> On Tue, Apr 30, 2019 at 04:30:46PM +0300, Maxim Yu. Osipov wrote:
>> On 4/30/19 12:34 PM, Andreas Reichel wrote:
>>> On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote:
>>>> Hi Claudius, Andreas,
>>>>
>>>> @Andreas
>>>> Your input is very welcome at this topic as you were busy with all this APT
>>>> keys stuff.
>>>>
>>>
>>> Thank you. Well in my eyes, Claudius delivers important changes to Isar
>>> which improve code quality and the build steps as a whole. Also as I
>>> know him, he is never ever interested in any personal "affairs" whatsoever,
>>> which I also learnt from his reviews on my code. He has a sharp mind and
>>> always tries to get out the best of the code up to his knowledge and
>>> techniques. Furthermore, if he may sometimes sound direct or even
>>> annoying to some - this is merely a personal question of how one focuses
>>> on mails. I also did not understand everything he criticized on my code
>>> in the beginning - but after I understood him, it was always great
>>> improvement. So, Maxim, I beg that you do not take anything personal on
>>> any mail, regarding any words or writing style but just focus on the
>>> code as I always try - which always helps to go on further with the
>>> project and to improve it. That's my input.
>>>
>>> Andreas
>>
>> I would prefer to focus on technical aspects of the modification under
>> review. Are you OK with this modification?
>>
> I am OK with these.
> 
> However I want MY patch series (version 9) merged before this one,
> because it is now very well reviewed and weeks old.
> And please don't argue with failed CI now. Investigating, understanding
> and fixing CI is a different topic and out of my scope.

I'll not merge your v9 series - more than one week ago I pointed you to 
the problematic test case  which is easily reproducible (see forwarded 
email below):

So I expect your feedback/next version of series fixing mentioned problem.


-------- Forwarded Message --------
Subject: Re: [PATCH v9 0/5] Fix usage of additional apt keys and repos
Date: Mon, 22 Apr 2019 14:22:24 +0200
From: Maxim Yu. Osipov <mosipov@ilbers.de>
Organization: ilbers GmbH
To: Andreas J. Reichel <andreas.reichel.ext@siemens.com>, 
isar-users@googlegroups.com

Hi Andreas,

I've tested your series (with the docker use-case example you described 
in last patch in series). It works as described in the default case - 
without local apt caching enabled.

I've tested it with with signed local apt caching feature enabled.

The first stage - creation of local repo passed OK -

bitbake -c cache_base_repo multiconfig:qemuarm64-stretch:isar-image-base

But on the second stage the build failed (see log below).

I've double checked 'signed local apt caching feature' works fine in the 
current 'next'.

My local.conf is attached for convenience.

Regards,
Maxim.


> 
> Regards,
> Andreas
> 
>> Regards,
>> Maxim.
>>
>>>> On 4/26/19 9:36 AM, Claudius Heine wrote:
>>>>> Hi Maxim,
>>>>>
>>>>> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>>>>>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>>>>>> From: Claudius Heine <ch@denx.de>
>>>>>>>
>>>>>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>>>>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>>>>>> distributions.
>>>>>>>
>>>>>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>>>>>> ---
>>>>>>>      meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>>>>>      1 file changed, 2 insertions(+)
>>>>>>>
>>>>>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>>>> index 08b068f..3e96281 100644
>>>>>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>>>>>      ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>>>>>      require isar-bootstrap.inc
>>>>>>> +# We only build debian host buildchroot environments
>>>>>>> +DISTRO_APT_KEYS = ""
>>>>>>
>>>>>>     From the first glance this modification limits functionality.
>>>>>> It looks like a hack and I would suggest to avoid this modification.
>>>>>
>>>>> Well it is a fix and that limited functionality was already present but
>>>>> just implicit, hidden behind some bug and the cleanup just made it
>>>>> appear.
>>>>
>>>>
>>>> Could you please point to this hidden, implicit place where mentioned bug
>>>> persists?
>>>>
>>>> I've looked under meta/recipes-core/isar-bootstrap/
>>>>
>>>> It seems that keyring stuff is quite symmetrical (in terms of host/target):
>>>>
>>>> isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring *
>>>> isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] =
>>>> "${DISTRO}-${DISTRO_ARCH}"
>>>> isar-bootstrap-host.bb:addtask bootstrap before do_build after
>>>> do_generate_keyring
>>>> isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
>>>> isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = ""
>>>> isar-bootstrap.inc:        d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
>>>> ${APTKEYRING}")
>>>> isar-bootstrap.inc:            d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
>>>> ${APTKEYRING}")
>>>> isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}"
>>>> isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS"
>>>> isar-bootstrap.inc:do_generate_keyring() {
>>>> isar-bootstrap.inc:           gpg --no-default-keyring --keyring
>>>> "${APTKEYRING}" \
>>>> isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack
>>>> isar-bootstrap.inc:                               ${DEBOOTSTRAP_KEYRING} \
>>>> isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \
>>>> isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] =
>>>> "${DISTRO}-${DISTRO_ARCH}"
>>>> isar-bootstrap-target.bb:addtask bootstrap before do_build after
>>>> do_generate_keyring
>>>> isar/meta/recipes-core/isar-bootstrap$
>>>>
>>>>
>>>> And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc)
>>>> differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing
>>>> regarding
>>>>
>>>>               if [ ${IS_HOST} ]; then
>>>>                   ${DEBOOTSTRAP} $debootstrap_args \
>>>>                                  ${@get_distro_components_argument(d, True)} \
>>>>                                  ${DEBOOTSTRAP_KEYRING} \
>>>>                                  "${@get_distro_suite(d, True)}" \
>>>>                                  "${ROOTFSDIR}" \
>>>>                                  "${@get_distro_source(d, True)}"
>>>>
>>>>               else
>>>>                    "${DEBOOTSTRAP}" $debootstrap_args \
>>>>                                     --arch="${DISTRO_ARCH}" \
>>>>                                     ${@get_distro_components_argument(d,
>>>> False)} \
>>>>                                     ${DEBOOTSTRAP_KEYRING} \
>>>>                                     "${@get_distro_suite(d, False)}" \
>>>>                                     "${ROOTFSDIR}" \
>>>>                                     "${@get_distro_source(d, False)}"
>>>>               fi
>>>>
>>>>
>>>>
>>>>
>>>>>
>>>>>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>>>>>> avoid confusion between target and host apt keys.
>>>>>
>>>>> Good idea. But that would be a new feature/improvement.
>>>>
>>>> Yes. But your series is also improvement, isn't?
>>>>
>>>> I need more arguments for introduction of this limitation.
>>>>
>>>> Maxim.
>>>>
>>>>> Also thanks for looking at the code!
>>>>>
>>>>> Claudius
>>>>>
>>>>>>
>>>>>>
>>>>>> Maxim.
>>>>>>
>>>>>>
>>>>>>
>>>>>>>      inherit isar-bootstrap-helper
>>>>>>>      do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>>>>>>>
>>>>>>
>>>>>>
>>>>>> -- 
>>>>>> Maxim Osipov
>>>>>> ilbers GmbH
>>>>>> Maria-Merian-Str. 8
>>>>>> 85521 Ottobrunn
>>>>>> Germany
>>>>>> +49 (151) 6517 6917
>>>>>> mosipov@ilbers.de
>>>>>> http://ilbers.de/
>>>>>> Commercial register Munich, HRB 214197
>>>>>> General Manager: Baurzhan Ismagulov
>>>>>>
>>>>>> -- 
>>>>>> You received this message because you are subscribed to the Google Groups "isar-users" group.
>>>>>> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
>>>>>> To post to this group, send email to isar-users@googlegroups.com.
>>>>>> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de.
>>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>>
>>>>> --
>>>>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>>>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>>>> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
>>>>>
>>>>>               PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
>>>>>                                 Keyserver: hkp://pool.sks-keyservers.net
>>>>>
>>>>
>>>>
>>>> -- 
>>>> Maxim Osipov
>>>> ilbers GmbH
>>>> Maria-Merian-Str. 8
>>>> 85521 Ottobrunn
>>>> Germany
>>>> +49 (151) 6517 6917
>>>> mosipov@ilbers.de
>>>> http://ilbers.de/
>>>> Commercial register Munich, HRB 214197
>>>> General Manager: Baurzhan Ismagulov
>>>
>>
>>
>> -- 
>> Maxim Osipov
>> ilbers GmbH
>> Maria-Merian-Str. 8
>> 85521 Ottobrunn
>> Germany
>> +49 (151) 6517 6917
>> mosipov@ilbers.de
>> http://ilbers.de/
>> Commercial register Munich, HRB 214197
>> General Manager: Baurzhan Ismagulov
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Andreas Reichel]

On Tue, Apr 30, 2019 at 06:46:33PM +0300, Maxim Yu. Osipov wrote:
> On 4/30/19 6:22 PM, Andreas Reichel wrote:
> > On Tue, Apr 30, 2019 at 04:30:46PM +0300, Maxim Yu. Osipov wrote:
> > > On 4/30/19 12:34 PM, Andreas Reichel wrote:
> > > > On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote:
> > > > > Hi Claudius, Andreas,
> > > > > 
> > > > > @Andreas
> > > > > Your input is very welcome at this topic as you were busy with all this APT
> > > > > keys stuff.
> > > > > 
> > > > 
> > > > Thank you. Well in my eyes, Claudius delivers important changes to Isar
> > > > which improve code quality and the build steps as a whole. Also as I
> > > > know him, he is never ever interested in any personal "affairs" whatsoever,
> > > > which I also learnt from his reviews on my code. He has a sharp mind and
> > > > always tries to get out the best of the code up to his knowledge and
> > > > techniques. Furthermore, if he may sometimes sound direct or even
> > > > annoying to some - this is merely a personal question of how one focuses
> > > > on mails. I also did not understand everything he criticized on my code
> > > > in the beginning - but after I understood him, it was always great
> > > > improvement. So, Maxim, I beg that you do not take anything personal on
> > > > any mail, regarding any words or writing style but just focus on the
> > > > code as I always try - which always helps to go on further with the
> > > > project and to improve it. That's my input.
> > > > 
> > > > Andreas
> > > 
> > > I would prefer to focus on technical aspects of the modification under
> > > review. Are you OK with this modification?
> > > 
> > I am OK with these.
> > 
> > However I want MY patch series (version 9) merged before this one,
> > because it is now very well reviewed and weeks old.
> > And please don't argue with failed CI now. Investigating, understanding
> > and fixing CI is a different topic and out of my scope.
> 
> I'll not merge your v9 series - more than one week ago I pointed you to the
> problematic test case  which is easily reproducible (see forwarded email
> below):
> 
> So I expect your feedback/next version of series fixing mentioned problem.
> 
Sorry I overlooked that problem. I just sent the fix with v10.

> 
> -------- Forwarded Message --------
> Subject: Re: [PATCH v9 0/5] Fix usage of additional apt keys and repos
> Date: Mon, 22 Apr 2019 14:22:24 +0200
> From: Maxim Yu. Osipov <mosipov@ilbers.de>
> Organization: ilbers GmbH
> To: Andreas J. Reichel <andreas.reichel.ext@siemens.com>,
> isar-users@googlegroups.com
> 
> Hi Andreas,
> 
> I've tested your series (with the docker use-case example you described in
> last patch in series). It works as described in the default case - without
> local apt caching enabled.
> 
> I've tested it with with signed local apt caching feature enabled.
> 
> The first stage - creation of local repo passed OK -
> 
> bitbake -c cache_base_repo multiconfig:qemuarm64-stretch:isar-image-base
> 
> But on the second stage the build failed (see log below).
> 
> I've double checked 'signed local apt caching feature' works fine in the
> current 'next'.
> 
> My local.conf is attached for convenience.
> 
> Regards,
> Maxim.
> 
> 
> > 
> > Regards,
> > Andreas
> > 
> > > Regards,
> > > Maxim.
> > > 
> > > > > On 4/26/19 9:36 AM, Claudius Heine wrote:
> > > > > > Hi Maxim,
> > > > > > 
> > > > > > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
> > > > > > > On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> > > > > > > > From: Claudius Heine <ch@denx.de>
> > > > > > > > 
> > > > > > > > isar-bootstrap-host only supports bootstrapping Debian root file
> > > > > > > > systems. Therefore deactivate any DISTRO_APT_KEYS from other
> > > > > > > > distributions.
> > > > > > > > 
> > > > > > > > Signed-off-by: Claudius Heine <ch@denx.de>
> > > > > > > > ---
> > > > > > > >      meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> > > > > > > >      1 file changed, 2 insertions(+)
> > > > > > > > 
> > > > > > > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > > > > > index 08b068f..3e96281 100644
> > > > > > > > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > > > > > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > > > > > > > @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
> > > > > > > >      ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
> > > > > > > >      require isar-bootstrap.inc
> > > > > > > > +# We only build debian host buildchroot environments
> > > > > > > > +DISTRO_APT_KEYS = ""
> > > > > > > 
> > > > > > >     From the first glance this modification limits functionality.
> > > > > > > It looks like a hack and I would suggest to avoid this modification.
> > > > > > 
> > > > > > Well it is a fix and that limited functionality was already present but
> > > > > > just implicit, hidden behind some bug and the cleanup just made it
> > > > > > appear.
> > > > > 
> > > > > 
> > > > > Could you please point to this hidden, implicit place where mentioned bug
> > > > > persists?
> > > > > 
> > > > > I've looked under meta/recipes-core/isar-bootstrap/
> > > > > 
> > > > > It seems that keyring stuff is quite symmetrical (in terms of host/target):
> > > > > 
> > > > > isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring *
> > > > > isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] =
> > > > > "${DISTRO}-${DISTRO_ARCH}"
> > > > > isar-bootstrap-host.bb:addtask bootstrap before do_build after
> > > > > do_generate_keyring
> > > > > isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
> > > > > isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = ""
> > > > > isar-bootstrap.inc:        d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
> > > > > ${APTKEYRING}")
> > > > > isar-bootstrap.inc:            d.setVar("DEBOOTSTRAP_KEYRING", "--keyring
> > > > > ${APTKEYRING}")
> > > > > isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}"
> > > > > isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS"
> > > > > isar-bootstrap.inc:do_generate_keyring() {
> > > > > isar-bootstrap.inc:           gpg --no-default-keyring --keyring
> > > > > "${APTKEYRING}" \
> > > > > isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack
> > > > > isar-bootstrap.inc:                               ${DEBOOTSTRAP_KEYRING} \
> > > > > isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \
> > > > > isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] =
> > > > > "${DISTRO}-${DISTRO_ARCH}"
> > > > > isar-bootstrap-target.bb:addtask bootstrap before do_build after
> > > > > do_generate_keyring
> > > > > isar/meta/recipes-core/isar-bootstrap$
> > > > > 
> > > > > 
> > > > > And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc)
> > > > > differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing
> > > > > regarding
> > > > > 
> > > > >               if [ ${IS_HOST} ]; then
> > > > >                   ${DEBOOTSTRAP} $debootstrap_args \
> > > > >                                  ${@get_distro_components_argument(d, True)} \
> > > > >                                  ${DEBOOTSTRAP_KEYRING} \
> > > > >                                  "${@get_distro_suite(d, True)}" \
> > > > >                                  "${ROOTFSDIR}" \
> > > > >                                  "${@get_distro_source(d, True)}"
> > > > > 
> > > > >               else
> > > > >                    "${DEBOOTSTRAP}" $debootstrap_args \
> > > > >                                     --arch="${DISTRO_ARCH}" \
> > > > >                                     ${@get_distro_components_argument(d,
> > > > > False)} \
> > > > >                                     ${DEBOOTSTRAP_KEYRING} \
> > > > >                                     "${@get_distro_suite(d, False)}" \
> > > > >                                     "${ROOTFSDIR}" \
> > > > >                                     "${@get_distro_source(d, False)}"
> > > > >               fi
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > > 
> > > > > > > Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
> > > > > > > avoid confusion between target and host apt keys.
> > > > > > 
> > > > > > Good idea. But that would be a new feature/improvement.
> > > > > 
> > > > > Yes. But your series is also improvement, isn't?
> > > > > 
> > > > > I need more arguments for introduction of this limitation.
> > > > > 
> > > > > Maxim.
> > > > > 
> > > > > > Also thanks for looking at the code!
> > > > > > 
> > > > > > Claudius
> > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > Maxim.
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > >      inherit isar-bootstrap-helper
> > > > > > > >      do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> > > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > -- 
> > > > > > > Maxim Osipov
> > > > > > > ilbers GmbH
> > > > > > > Maria-Merian-Str. 8
> > > > > > > 85521 Ottobrunn
> > > > > > > Germany
> > > > > > > +49 (151) 6517 6917
> > > > > > > mosipov@ilbers.de
> > > > > > > http://ilbers.de/
> > > > > > > Commercial register Munich, HRB 214197
> > > > > > > General Manager: Baurzhan Ismagulov
> > > > > > > 
> > > > > > > -- 
> > > > > > > You received this message because you are subscribed to the Google Groups "isar-users" group.
> > > > > > > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> > > > > > > To post to this group, send email to isar-users@googlegroups.com.
> > > > > > > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de.
> > > > > > > For more options, visit https://groups.google.com/d/optout.
> > > > > > 
> > > > > > --
> > > > > > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > > > > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > > > > > Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
> > > > > > 
> > > > > >               PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
> > > > > >                                 Keyserver: hkp://pool.sks-keyservers.net
> > > > > > 
> > > > > 
> > > > > 
> > > > > -- 
> > > > > Maxim Osipov
> > > > > ilbers GmbH
> > > > > Maria-Merian-Str. 8
> > > > > 85521 Ottobrunn
> > > > > Germany
> > > > > +49 (151) 6517 6917
> > > > > mosipov@ilbers.de
> > > > > http://ilbers.de/
> > > > > Commercial register Munich, HRB 214197
> > > > > General Manager: Baurzhan Ismagulov
> > > > 
> > > 
> > > 
> > > -- 
> > > Maxim Osipov
> > > ilbers GmbH
> > > Maria-Merian-Str. 8
> > > 85521 Ottobrunn
> > > Germany
> > > +49 (151) 6517 6917
> > > mosipov@ilbers.de
> > > http://ilbers.de/
> > > Commercial register Munich, HRB 214197
> > > General Manager: Baurzhan Ismagulov
> > 
> 
> 
> -- 
> Maxim Osipov
> ilbers GmbH
> Maria-Merian-Str. 8
> 85521 Ottobrunn
> Germany
> +49 (151) 6517 6917
> mosipov@ilbers.de
> http://ilbers.de/
> Commercial register Munich, HRB 214197
> General Manager: Baurzhan Ismagulov

-- 
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

Andreas.Reichel@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082

Fwd: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Maxim Yu. Osipov]

Hi Claudius,

Any feedback on Jan's question (see below)?

I've applied v10 series "Fix usage of additional apt keys and repos" 
from Andreas, this results that your v4 series "Cleanup rootfs creation" 
has to be rebased. I can rebase it - no problem - but all pending 
questions should be answered first.

Regards,
Maxim.

-------- Forwarded Message --------
Subject: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS 
usage
Date: Fri, 26 Apr 2019 13:50:50 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Claudius Heine <ch@denx.de>, Maxim Yu. Osipov <mosipov@ilbers.de>, 
claudius.heine.ext@siemens.com, isar-users@googlegroups.com

On 26.04.19 13:31, [ext] Jan Kiszka wrote:
> On 26.04.19 09:36, Claudius Heine wrote:
>> Hi Maxim,
>>
>> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>>> From: Claudius Heine <ch@denx.de>
>>>>
>>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>>> distributions.
>>>>
>>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>>> ---
>>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb 
>>>> b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> index 08b068f..3e96281 100644
>>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = 
>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>>    ISAR_BOOTSTRAP_LOCK = 
>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>>    require isar-bootstrap.inc
>>>> +# We only build debian host buildchroot environments
>>>> +DISTRO_APT_KEYS = ""
>>>
>>>   From the first glance this modification limits functionality.
>>> It looks like a hack and I would suggest to avoid this modification.
>>
>> Well it is a fix and that limited functionality was already present but
>> just implicit, hidden behind some bug and the cleanup just made it
>> appear.
>>
>>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>>> avoid confusion between target and host apt keys.
>>
>> Good idea. But that would be a new feature/improvement.
>>
> 
> If that is just about adding and documenting another variable, let's not discuss 
> about when and who because just doing that will already be faster, even if it's 
> a "drive-by" improvement /wrt this patchset.
> 

OTOH, I don't get the problem yet from just reading the commit message: 
Wasn't DISTRO_APT_KEYS designed to be a superset of all needed keys? We 
are appending raspbian to it when using that distro. So, we are at least 
missing the reasoning here why that model didn't work and cannot be made 
working for the host/target case. And then we can refer to that when 
introducing split key sets.

Thanks,
Jan


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Claudius Heine]

Hi Jan,

On 26/04/2019 13.50, Jan Kiszka wrote:
> On 26.04.19 13:31, [ext] Jan Kiszka wrote:
>> On 26.04.19 09:36, Claudius Heine wrote:
>>> Hi Maxim,
>>>
>>> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
>>>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
>>>>> From: Claudius Heine <ch@denx.de>
>>>>>
>>>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
>>>>> distributions.
>>>>>
>>>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>>>> ---
>>>>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>>>    1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git 
>>>>> a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb 
>>>>> b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> index 08b068f..3e96281 100644
>>>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = 
>>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>>>    ISAR_BOOTSTRAP_LOCK = 
>>>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>>>    require isar-bootstrap.inc
>>>>> +# We only build debian host buildchroot environments
>>>>> +DISTRO_APT_KEYS = ""
>>>>
>>>>   From the first glance this modification limits functionality.
>>>> It looks like a hack and I would suggest to avoid this modification.
>>>
>>> Well it is a fix and that limited functionality was already present but
>>> just implicit, hidden behind some bug and the cleanup just made it
>>> appear.
>>>
>>>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
>>>> avoid confusion between target and host apt keys.
>>>
>>> Good idea. But that would be a new feature/improvement.
>>>
>>
>> If that is just about adding and documenting another variable, let's 
>> not discuss about when and who because just doing that will already be 
>> faster, even if it's a "drive-by" improvement /wrt this patchset.
>>
> 
> OTOH, I don't get the problem yet from just reading the commit message: 
> Wasn't DISTRO_APT_KEYS designed to be a superset of all needed keys?

DISTRO_APT_KEYS is only used for distros that aren't Debian, because 
debootstrap uses the keys of the host distro (Debian) per default. 
THIRD_PARTY_APT_KEYS is for the keys of other third party repositories 
that are not used to bootstrap from.

We currently only support raspbian as a non-debian distribution and 
before this patchset only 'debian-stretch' as buildchroot-host.
After this patchset we support all Debian versions we currently support 
for the target for the buildchroot-host as well. Since raspbian does not 
supply packages that can be used for a buildchroot-host environment, it 
makes sense to just use the Debian host keys for bootstrapping the 
buildchroot-host rootfs in general.

If at one point we want to support other non-debian apt/dpkg based 
distributions like ubuntu, that can be used for the target as well as 
the host root file system, then it makes sense to allow specifying 
additional keys for the buildchroot-host as well. Until that time 
however this fix is enough to go forward.

regards,
Claudius

> We 
> are appending raspbian to it when using that distro. So, we are at least 
> missing the reasoning here why that model didn't work and cannot be made 
> working for the host/target case. And then we can refer to that when 
> introducing split key sets.
> 
> Thanks,
> Jan
> 
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Claudius Heine]

small errata:

On 14/05/2019 13.32, Claudius Heine wrote:

>>
>> OTOH, I don't get the problem yet from just reading the commit 
>> message: Wasn't DISTRO_APT_KEYS designed to be a superset of all 
>> needed keys?
> 
> DISTRO_APT_KEYS is only used for distros that aren't Debian, because 
> debootstrap uses the keys of the host distro (Debian) per default.

DISTRO_APT_KEYS was renamed by Andreas new patchset and is now called 
DISTRO_BOOTSTRAP_KEYS.

> THIRD_PARTY_APT_KEYS is for the keys of other third party repositories 
> that are not used to bootstrap from.
> 
> We currently only support raspbian as a non-debian distribution and 
> before this patchset only 'debian-stretch' as buildchroot-host.
> After this patchset we support all Debian versions we currently support 
> for the target for the buildchroot-host as well. Since raspbian does not 
> supply packages that can be used for a buildchroot-host environment, it 
> makes sense to just use the Debian host keys for bootstrapping the 
> buildchroot-host rootfs in general.
> 
> If at one point we want to support other non-debian apt/dpkg based 
> distributions like ubuntu, that can be used for the target as well as 
> the host root file system, then it makes sense to allow specifying 
> additional keys for the buildchroot-host as well. Until that time 
> however this fix is enough to go forward.
> 
> regards,
> Claudius
> 
>> We are appending raspbian to it when using that distro. So, we are at 
>> least missing the reasoning here why that model didn't work and cannot 
>> be made working for the host/target case. And then we can refer to 
>> that when introducing split key sets.
>>
>> Thanks,
>> Jan
>>
>>
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de