From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6683827867816558592 X-Received: by 2002:a5d:4852:: with SMTP id n18mr7416387wrs.304.1556637768212; Tue, 30 Apr 2019 08:22:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:9696:: with SMTP id y144ls973141wmd.2.gmail; Tue, 30 Apr 2019 08:22:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqx90SD7Ft7+FzGo4GeLaz4toN3HsaF7PZ/YK42LPu1XXfl7PZDuQ9Bojg3flt977umGrHPf X-Received: by 2002:a1c:9ec7:: with SMTP id h190mr3695318wme.105.1556637767711; Tue, 30 Apr 2019 08:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556637767; cv=none; d=google.com; s=arc-20160816; b=GVnenBcDotnBzOtWvSfUfUvSWiIxWY8xvsNnDpx+W69Yq6aVSPcApevX2m//fGnrvp UcyOHBS00ra1yjvYIcR95GxSEf98n/p/zLPYyHXjoshvvHOud8+H9sFToKGlMSPsHmxm Y8ZXVBb7L3W2YxcA/MnFHRtfynqbp7/U7wY8TmY8L7bldZehOxS4weUhVC/qGn/xv4JC pKwhwyIpKmG+clI/FEiYqwbJBrm4LQfbwoVQjlmDER5Okfd4/Cmzh5L3UAWa8Ax+L/MY U6QsZWksh+kxd3yUqlldmIFlUWtFu+4y4Jhdg6ugwBcm+6MeyKtZIjX1Z32/df+1623Q x/nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:cc:to:from:date; bh=fsqFKSIfN/QkVEq13hiv7KYs7hoSN5rNWqqK3OEmfJ0=; b=yi7pV/LRW1dH7nV2UKEnh9PkDIHHjTELcmQi7QoL0aYz8/djhmEIHBr+kesyTYmSVB QRLuwDfGIuSGHEtmd+QQtqy2hep9E5m5FVRNTd4da6KSxvDPkz7U5k57TKPxPnyVzdc1 ds25WWcIKB7Xedd4xdL8gar9nco1k8fCdO+IuHfyJteE702K2LxxGo8eNSR+jWtfoWt+ LfCST8/xJVvSPuSaZMwI7yi43Q5nFFjsEiLhsmYxlsIuY0YtRwcnCloJ7Z7JAHDZZYiZ ZvssXaGlgjUK6ML5T5HnLiSc+rDf+BiTtBGoIqm3ohdJtQIeBPjL9U7WAGVt+lOo+bXx KUpQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id 4si104469wmd.1.2019.04.30.08.22.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 08:22:47 -0700 (PDT) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x3UFMkA4007857 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Apr 2019 17:22:46 +0200 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.122]) by mail2.sbs.de (8.15.2/8.15.2) with SMTP id x3UFMkwp013156; Tue, 30 Apr 2019 17:22:46 +0200 Date: Tue, 30 Apr 2019 17:22:46 +0200 From: Andreas Reichel To: "Maxim Yu. Osipov" Cc: Claudius Heine , claudius.heine.ext@siemens.com, isar-users@googlegroups.com, jan.kiszka@siemens.com Subject: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage Message-ID: <20190430152246.GA13521@iiotirae> References: <20190425134450.13443-1-claudius.heine.ext@siemens.com> <20190425134450.13443-2-claudius.heine.ext@siemens.com> <155626421155.10914.2537647574220599237@ardipi> <89e6b417-265c-b1a6-b151-0938fed5d462@ilbers.de> <20190430093405.GA14335@iiotirae> <70eae983-d513-9ed9-5c54-cc6218a9af3f@ilbers.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: <70eae983-d513-9ed9-5c54-cc6218a9af3f@ilbers.de> User-Agent: Mutt/1.11.4 (2019-03-13) X-TUID: 7n3glyndKiUz On Tue, Apr 30, 2019 at 04:30:46PM +0300, Maxim Yu. Osipov wrote: > On 4/30/19 12:34 PM, Andreas Reichel wrote: > > On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote: > > > Hi Claudius, Andreas, > > > > > > @Andreas > > > Your input is very welcome at this topic as you were busy with all this APT > > > keys stuff. > > > > > > > Thank you. Well in my eyes, Claudius delivers important changes to Isar > > which improve code quality and the build steps as a whole. Also as I > > know him, he is never ever interested in any personal "affairs" whatsoever, > > which I also learnt from his reviews on my code. He has a sharp mind and > > always tries to get out the best of the code up to his knowledge and > > techniques. Furthermore, if he may sometimes sound direct or even > > annoying to some - this is merely a personal question of how one focuses > > on mails. I also did not understand everything he criticized on my code > > in the beginning - but after I understood him, it was always great > > improvement. So, Maxim, I beg that you do not take anything personal on > > any mail, regarding any words or writing style but just focus on the > > code as I always try - which always helps to go on further with the > > project and to improve it. That's my input. > > > > Andreas > > I would prefer to focus on technical aspects of the modification under > review. Are you OK with this modification? > I am OK with these. However I want MY patch series (version 9) merged before this one, because it is now very well reviewed and weeks old. And please don't argue with failed CI now. Investigating, understanding and fixing CI is a different topic and out of my scope. Regards, Andreas > Regards, > Maxim. > > > > On 4/26/19 9:36 AM, Claudius Heine wrote: > > > > Hi Maxim, > > > > > > > > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59) > > > > > On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote: > > > > > > From: Claudius Heine > > > > > > > > > > > > isar-bootstrap-host only supports bootstrapping Debian root file > > > > > > systems. Therefore deactivate any DISTRO_APT_KEYS from other > > > > > > distributions. > > > > > > > > > > > > Signed-off-by: Claudius Heine > > > > > > --- > > > > > > meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++ > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > > > > > > index 08b068f..3e96281 100644 > > > > > > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > > > > > > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > > > > > > @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}" > > > > > > ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock" > > > > > > require isar-bootstrap.inc > > > > > > +# We only build debian host buildchroot environments > > > > > > +DISTRO_APT_KEYS = "" > > > > > > > > > > From the first glance this modification limits functionality. > > > > > It looks like a hack and I would suggest to avoid this modification. > > > > > > > > Well it is a fix and that limited functionality was already present but > > > > just implicit, hidden behind some bug and the cleanup just made it > > > > appear. > > > > > > > > > Could you please point to this hidden, implicit place where mentioned bug > > > persists? > > > > > > I've looked under meta/recipes-core/isar-bootstrap/ > > > > > > It seems that keyring stuff is quite symmetrical (in terms of host/target): > > > > > > isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring * > > > isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] = > > > "${DISTRO}-${DISTRO_ARCH}" > > > isar-bootstrap-host.bb:addtask bootstrap before do_build after > > > do_generate_keyring > > > isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg" > > > isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = "" > > > isar-bootstrap.inc: d.setVar("DEBOOTSTRAP_KEYRING", "--keyring > > > ${APTKEYRING}") > > > isar-bootstrap.inc: d.setVar("DEBOOTSTRAP_KEYRING", "--keyring > > > ${APTKEYRING}") > > > isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}" > > > isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS" > > > isar-bootstrap.inc:do_generate_keyring() { > > > isar-bootstrap.inc: gpg --no-default-keyring --keyring > > > "${APTKEYRING}" \ > > > isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack > > > isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \ > > > isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \ > > > isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] = > > > "${DISTRO}-${DISTRO_ARCH}" > > > isar-bootstrap-target.bb:addtask bootstrap before do_build after > > > do_generate_keyring > > > isar/meta/recipes-core/isar-bootstrap$ > > > > > > > > > And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc) > > > differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing > > > regarding > > > > > > if [ ${IS_HOST} ]; then > > > ${DEBOOTSTRAP} $debootstrap_args \ > > > ${@get_distro_components_argument(d, True)} \ > > > ${DEBOOTSTRAP_KEYRING} \ > > > "${@get_distro_suite(d, True)}" \ > > > "${ROOTFSDIR}" \ > > > "${@get_distro_source(d, True)}" > > > > > > else > > > "${DEBOOTSTRAP}" $debootstrap_args \ > > > --arch="${DISTRO_ARCH}" \ > > > ${@get_distro_components_argument(d, > > > False)} \ > > > ${DEBOOTSTRAP_KEYRING} \ > > > "${@get_distro_suite(d, False)}" \ > > > "${ROOTFSDIR}" \ > > > "${@get_distro_source(d, False)}" > > > fi > > > > > > > > > > > > > > > > > > > > > Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to > > > > > avoid confusion between target and host apt keys. > > > > > > > > Good idea. But that would be a new feature/improvement. > > > > > > Yes. But your series is also improvement, isn't? > > > > > > I need more arguments for introduction of this limitation. > > > > > > Maxim. > > > > > > > Also thanks for looking at the code! > > > > > > > > Claudius > > > > > > > > > > > > > > > > > > > Maxim. > > > > > > > > > > > > > > > > > > > > > inherit isar-bootstrap-helper > > > > > > do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > > > > > > > > > > > > > > > > > > > > -- > > > > > Maxim Osipov > > > > > ilbers GmbH > > > > > Maria-Merian-Str. 8 > > > > > 85521 Ottobrunn > > > > > Germany > > > > > +49 (151) 6517 6917 > > > > > mosipov@ilbers.de > > > > > http://ilbers.de/ > > > > > Commercial register Munich, HRB 214197 > > > > > General Manager: Baurzhan Ismagulov > > > > > > > > > > -- > > > > > You received this message because you are subscribed to the Google Groups "isar-users" group. > > > > > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > > > > > To post to this group, send email to isar-users@googlegroups.com. > > > > > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de. > > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > -- > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > > > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > > > > Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de > > > > > > > > PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 > > > > Keyserver: hkp://pool.sks-keyservers.net > > > > > > > > > > > > > -- > > > Maxim Osipov > > > ilbers GmbH > > > Maria-Merian-Str. 8 > > > 85521 Ottobrunn > > > Germany > > > +49 (151) 6517 6917 > > > mosipov@ilbers.de > > > http://ilbers.de/ > > > Commercial register Munich, HRB 214197 > > > General Manager: Baurzhan Ismagulov > > > > > -- > Maxim Osipov > ilbers GmbH > Maria-Merian-Str. 8 > 85521 Ottobrunn > Germany > +49 (151) 6517 6917 > mosipov@ilbers.de > http://ilbers.de/ > Commercial register Munich, HRB 214197 > General Manager: Baurzhan Ismagulov -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082