From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6683827867816558592 X-Received: by 2002:ac2:598b:: with SMTP id w11mr1964088lfn.62.1556799260069; Thu, 02 May 2019 05:14:20 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:974e:: with SMTP id f14ls197714ljj.15.gmail; Thu, 02 May 2019 05:14:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqwmT7EPZzEJrza7Ulv3Su3HklFfpMgwrmnzct29ZRJgyZeMGAVY+ky/VFRfd1NWBEm+mNyR X-Received: by 2002:a2e:9547:: with SMTP id t7mr1750494ljh.153.1556799259582; Thu, 02 May 2019 05:14:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556799259; cv=none; d=google.com; s=arc-20160816; b=A/Qk7O8a2ArZPIxXb7Mee93D3el+Qxaq1DTXJQiCp8VdJz7ieThPwth3cTj6FFarGy GXZ/vw7r13RbF7LE9o91AKYEZHfojUwIeOD1R7t6AEro4j53+DOJtjrvR7iDyk/nGFbG roIC+Ol2AnAPtmpm9X9T4OP5YwqV+LrkLBsws0Ur4VSEWsTWo1AfA/4q/WEqH3JQ8oN3 gzJ4yNjoz82yGyWZ0eNv9JldMjmo3tnKz9D633r6gPhUMnsgky/U0emTcppLVejwNujN 3ArtomxsfdoG7p26jc4ZFKQ14IELxJZRXyOtFx8gKBVMS7XN51AqIu8M1Yc7HbVkpS1b 0pwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:cc:to:from:date; bh=JhZT0rT67Rtw7YkRkULAilDLVapRreV0Hz2Il570T7I=; b=G5cQ63Gh2dXJOCqnJBWMvc7sdugShdHyk02BX9s6MtP88PcMbe3deT457CeA9RH952 JZSoD83PYDr4DOTmc7pssMpTzFUo8KBGU6MxkGcr9rNzjmgjyOq9sT2Bo7a6v06jdGSd FlXbvn4Wrd5BkiSWYhAPcqvoaOrPjmK8KGdooj+DWzkVW7rg5wz/j0SnOuEplluPjsN6 u+3HdxdLKQHWAqfor7ACxiVKGSnMgnzxKwASAtxkDC69D+8mQBYhsPnRafhUztsWhCH+ gT2mBG2mo9lcFy/4pZyIUH8GRqEvoZASiADYEQdpgqAM3YA5rrjmQ4liLnWdBoFo6m7S b9VQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id b2si9324lfj.2.2019.05.02.05.14.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2019 05:14:19 -0700 (PDT) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x42CEI7Z028783 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 May 2019 14:14:18 +0200 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.122]) by mail1.sbs.de (8.15.2/8.15.2) with SMTP id x42CEIcJ008680; Thu, 2 May 2019 14:14:18 +0200 Date: Thu, 2 May 2019 14:14:18 +0200 From: Andreas Reichel To: "Maxim Yu. Osipov" Cc: Claudius Heine , claudius.heine.ext@siemens.com, isar-users@googlegroups.com, jan.kiszka@siemens.com Subject: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage Message-ID: <20190502121418.GA13916@iiotirae> References: <20190425134450.13443-1-claudius.heine.ext@siemens.com> <20190425134450.13443-2-claudius.heine.ext@siemens.com> <155626421155.10914.2537647574220599237@ardipi> <89e6b417-265c-b1a6-b151-0938fed5d462@ilbers.de> <20190430093405.GA14335@iiotirae> <70eae983-d513-9ed9-5c54-cc6218a9af3f@ilbers.de> <20190430152246.GA13521@iiotirae> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-TUID: j4ayIEjzbInt On Tue, Apr 30, 2019 at 06:46:33PM +0300, Maxim Yu. Osipov wrote: > On 4/30/19 6:22 PM, Andreas Reichel wrote: > > On Tue, Apr 30, 2019 at 04:30:46PM +0300, Maxim Yu. Osipov wrote: > > > On 4/30/19 12:34 PM, Andreas Reichel wrote: > > > > On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote: > > > > > Hi Claudius, Andreas, > > > > > > > > > > @Andreas > > > > > Your input is very welcome at this topic as you were busy with all this APT > > > > > keys stuff. > > > > > > > > > > > > > Thank you. Well in my eyes, Claudius delivers important changes to Isar > > > > which improve code quality and the build steps as a whole. Also as I > > > > know him, he is never ever interested in any personal "affairs" whatsoever, > > > > which I also learnt from his reviews on my code. He has a sharp mind and > > > > always tries to get out the best of the code up to his knowledge and > > > > techniques. Furthermore, if he may sometimes sound direct or even > > > > annoying to some - this is merely a personal question of how one focuses > > > > on mails. I also did not understand everything he criticized on my code > > > > in the beginning - but after I understood him, it was always great > > > > improvement. So, Maxim, I beg that you do not take anything personal on > > > > any mail, regarding any words or writing style but just focus on the > > > > code as I always try - which always helps to go on further with the > > > > project and to improve it. That's my input. > > > > > > > > Andreas > > > > > > I would prefer to focus on technical aspects of the modification under > > > review. Are you OK with this modification? > > > > > I am OK with these. > > > > However I want MY patch series (version 9) merged before this one, > > because it is now very well reviewed and weeks old. > > And please don't argue with failed CI now. Investigating, understanding > > and fixing CI is a different topic and out of my scope. > > I'll not merge your v9 series - more than one week ago I pointed you to the > problematic test case which is easily reproducible (see forwarded email > below): > > So I expect your feedback/next version of series fixing mentioned problem. > Sorry I overlooked that problem. I just sent the fix with v10. > > -------- Forwarded Message -------- > Subject: Re: [PATCH v9 0/5] Fix usage of additional apt keys and repos > Date: Mon, 22 Apr 2019 14:22:24 +0200 > From: Maxim Yu. Osipov > Organization: ilbers GmbH > To: Andreas J. Reichel , > isar-users@googlegroups.com > > Hi Andreas, > > I've tested your series (with the docker use-case example you described in > last patch in series). It works as described in the default case - without > local apt caching enabled. > > I've tested it with with signed local apt caching feature enabled. > > The first stage - creation of local repo passed OK - > > bitbake -c cache_base_repo multiconfig:qemuarm64-stretch:isar-image-base > > But on the second stage the build failed (see log below). > > I've double checked 'signed local apt caching feature' works fine in the > current 'next'. > > My local.conf is attached for convenience. > > Regards, > Maxim. > > > > > > Regards, > > Andreas > > > > > Regards, > > > Maxim. > > > > > > > > On 4/26/19 9:36 AM, Claudius Heine wrote: > > > > > > Hi Maxim, > > > > > > > > > > > > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59) > > > > > > > On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote: > > > > > > > > From: Claudius Heine > > > > > > > > > > > > > > > > isar-bootstrap-host only supports bootstrapping Debian root file > > > > > > > > systems. Therefore deactivate any DISTRO_APT_KEYS from other > > > > > > > > distributions. > > > > > > > > > > > > > > > > Signed-off-by: Claudius Heine > > > > > > > > --- > > > > > > > > meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++ > > > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > > > > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > > > > > > > > index 08b068f..3e96281 100644 > > > > > > > > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > > > > > > > > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > > > > > > > > @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}" > > > > > > > > ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock" > > > > > > > > require isar-bootstrap.inc > > > > > > > > +# We only build debian host buildchroot environments > > > > > > > > +DISTRO_APT_KEYS = "" > > > > > > > > > > > > > > From the first glance this modification limits functionality. > > > > > > > It looks like a hack and I would suggest to avoid this modification. > > > > > > > > > > > > Well it is a fix and that limited functionality was already present but > > > > > > just implicit, hidden behind some bug and the cleanup just made it > > > > > > appear. > > > > > > > > > > > > > > > Could you please point to this hidden, implicit place where mentioned bug > > > > > persists? > > > > > > > > > > I've looked under meta/recipes-core/isar-bootstrap/ > > > > > > > > > > It seems that keyring stuff is quite symmetrical (in terms of host/target): > > > > > > > > > > isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring * > > > > > isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] = > > > > > "${DISTRO}-${DISTRO_ARCH}" > > > > > isar-bootstrap-host.bb:addtask bootstrap before do_build after > > > > > do_generate_keyring > > > > > isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg" > > > > > isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = "" > > > > > isar-bootstrap.inc: d.setVar("DEBOOTSTRAP_KEYRING", "--keyring > > > > > ${APTKEYRING}") > > > > > isar-bootstrap.inc: d.setVar("DEBOOTSTRAP_KEYRING", "--keyring > > > > > ${APTKEYRING}") > > > > > isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}" > > > > > isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS" > > > > > isar-bootstrap.inc:do_generate_keyring() { > > > > > isar-bootstrap.inc: gpg --no-default-keyring --keyring > > > > > "${APTKEYRING}" \ > > > > > isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack > > > > > isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \ > > > > > isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \ > > > > > isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] = > > > > > "${DISTRO}-${DISTRO_ARCH}" > > > > > isar-bootstrap-target.bb:addtask bootstrap before do_build after > > > > > do_generate_keyring > > > > > isar/meta/recipes-core/isar-bootstrap$ > > > > > > > > > > > > > > > And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc) > > > > > differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing > > > > > regarding > > > > > > > > > > if [ ${IS_HOST} ]; then > > > > > ${DEBOOTSTRAP} $debootstrap_args \ > > > > > ${@get_distro_components_argument(d, True)} \ > > > > > ${DEBOOTSTRAP_KEYRING} \ > > > > > "${@get_distro_suite(d, True)}" \ > > > > > "${ROOTFSDIR}" \ > > > > > "${@get_distro_source(d, True)}" > > > > > > > > > > else > > > > > "${DEBOOTSTRAP}" $debootstrap_args \ > > > > > --arch="${DISTRO_ARCH}" \ > > > > > ${@get_distro_components_argument(d, > > > > > False)} \ > > > > > ${DEBOOTSTRAP_KEYRING} \ > > > > > "${@get_distro_suite(d, False)}" \ > > > > > "${ROOTFSDIR}" \ > > > > > "${@get_distro_source(d, False)}" > > > > > fi > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to > > > > > > > avoid confusion between target and host apt keys. > > > > > > > > > > > > Good idea. But that would be a new feature/improvement. > > > > > > > > > > Yes. But your series is also improvement, isn't? > > > > > > > > > > I need more arguments for introduction of this limitation. > > > > > > > > > > Maxim. > > > > > > > > > > > Also thanks for looking at the code! > > > > > > > > > > > > Claudius > > > > > > > > > > > > > > > > > > > > > > > > > > > Maxim. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > inherit isar-bootstrap-helper > > > > > > > > do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Maxim Osipov > > > > > > > ilbers GmbH > > > > > > > Maria-Merian-Str. 8 > > > > > > > 85521 Ottobrunn > > > > > > > Germany > > > > > > > +49 (151) 6517 6917 > > > > > > > mosipov@ilbers.de > > > > > > > http://ilbers.de/ > > > > > > > Commercial register Munich, HRB 214197 > > > > > > > General Manager: Baurzhan Ismagulov > > > > > > > > > > > > > > -- > > > > > > > You received this message because you are subscribed to the Google Groups "isar-users" group. > > > > > > > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > > > > > > > To post to this group, send email to isar-users@googlegroups.com. > > > > > > > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de. > > > > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > > > -- > > > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > > > > > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > > > > > > Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de > > > > > > > > > > > > PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 > > > > > > Keyserver: hkp://pool.sks-keyservers.net > > > > > > > > > > > > > > > > > > > > > -- > > > > > Maxim Osipov > > > > > ilbers GmbH > > > > > Maria-Merian-Str. 8 > > > > > 85521 Ottobrunn > > > > > Germany > > > > > +49 (151) 6517 6917 > > > > > mosipov@ilbers.de > > > > > http://ilbers.de/ > > > > > Commercial register Munich, HRB 214197 > > > > > General Manager: Baurzhan Ismagulov > > > > > > > > > > > > > -- > > > Maxim Osipov > > > ilbers GmbH > > > Maria-Merian-Str. 8 > > > 85521 Ottobrunn > > > Germany > > > +49 (151) 6517 6917 > > > mosipov@ilbers.de > > > http://ilbers.de/ > > > Commercial register Munich, HRB 214197 > > > General Manager: Baurzhan Ismagulov > > > > > -- > Maxim Osipov > ilbers GmbH > Maria-Merian-Str. 8 > 85521 Ottobrunn > Germany > +49 (151) 6517 6917 > mosipov@ilbers.de > http://ilbers.de/ > Commercial register Munich, HRB 214197 > General Manager: Baurzhan Ismagulov -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082