public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: claudius.heine.ext@siemens.com
To: isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: [PATCH] image.bbclass: remove 'get_image_name' function
Date: Tue, 21 May 2019 16:28:18 +0200	[thread overview]
Message-ID: <20190521142818.25505-1-claudius.heine.ext@siemens.com> (raw)

From: Claudius Heine <ch@denx.de>

This function is only used in 'do_copy_boot_files' where a simple shell
function fits better.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 meta/classes/image.bbclass | 33 ++++++---------------------------
 1 file changed, 6 insertions(+), 27 deletions(-)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 3eb261f..45ed8ba 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -64,29 +64,6 @@ inherit image-postproc-extension
 # Extra space for rootfs in MB
 ROOTFS_EXTRA ?= "64"
 
-def get_image_name(d, name_link):
-    S = d.getVar("IMAGE_ROOTFS", True)
-    path_link = os.path.join(S, name_link)
-
-    # If path_link does not exist, it might be a symlink
-    # in the target rootfs.  This block attempts to resolve
-    # it relative to the rootfs location.
-    if not os.path.exists(path_link):
-        path_link = os.path.join(
-            S,
-            os.path.relpath(
-                os.path.realpath(path_link),
-                "/",
-            ),
-        )
-
-    if os.path.exists(path_link):
-        base = os.path.basename(os.path.realpath(path_link))
-        full = d.getVar("IMAGE_FULLNAME", True) + "." + base
-        return [base, full]
-
-    return ["", ""]
-
 def get_rootfs_size(d):
     import subprocess
     rootfs_extra = int(d.getVar("ROOTFS_EXTRA", True))
@@ -149,12 +126,14 @@ addtask rootfs_install before do_build after do_unpack
 
 do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}"
 do_copy_boot_files() {
-    if [ -n "${KERNEL_IMAGE}" ]; then
-        cp -f ${IMAGE_ROOTFS}/boot/${@get_image_name(d, 'vmlinuz')[0]} ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}
+    kernel="$(realpath -q '${IMAGE_ROOTFS}/vmlinuz')"
+    if [ -n "$kernel" ]; then
+        cp -f "$kernel" '${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE}'
     fi
 
-    if [ -n "${INITRD_IMAGE}" ]; then
-        sudo cp -f ${IMAGE_ROOTFS}/boot/${@get_image_name(d, 'initrd.img')[0]} ${DEPLOY_DIR_IMAGE}/${INITRD_IMAGE}
+    initrd="$(realpath -q '${IMAGE_ROOTFS}/initrd.img')"
+    if [ -n "$initrd" ]; then
+        cp -f "$initrd" '${DEPLOY_DIR_IMAGE}/${INITRD_IMAGE}'
     fi
 
     # Check DTB_FILE via inline python to handle unset case:
-- 
2.20.1


             reply	other threads:[~2019-05-21 14:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 14:28 claudius.heine.ext [this message]
2019-05-23 12:46 ` Henning Schild
2019-05-23 13:36   ` Claudius Heine
2019-05-24 13:06 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521142818.25505-1-claudius.heine.ext@siemens.com \
    --to=claudius.heine.ext@siemens.com \
    --cc=ch@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox