From: claudius.heine.ext@siemens.com
To: isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: [PATCH 2/3] image.bbclass: remove fstab generation
Date: Tue, 28 May 2019 10:58:13 +0200 [thread overview]
Message-ID: <20190528085814.12967-3-claudius.heine.ext@siemens.com> (raw)
In-Reply-To: <20190528085814.12967-1-claudius.heine.ext@siemens.com>
From: Claudius Heine <ch@denx.de>
Generating the fstab is not necessary, since the mounts are either
default [1] or can be described via kernel command line or systemd.mount
files. The current fstab generation mechanism is also to inflexible to
allow easy customization from within an image recipe.
[1] https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems/
Signed-off-by: Claudius Heine <ch@denx.de>
---
meta/classes/image.bbclass | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 1950263..5682134 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -105,22 +105,6 @@ python set_image_size () {
d.setVarFlag('ROOTFS_SIZE', 'export', '1')
}
-ROOTFS_CONFIGURE_COMMAND += "image_configure_fstab"
-image_configure_fstab[weight] = "2"
-image_configure_fstab() {
- sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF
-# Begin /etc/fstab
-/dev/root / auto defaults 0 0
-proc /proc proc nosuid,noexec,nodev 0 0
-sysfs /sys sysfs nosuid,noexec,nodev 0 0
-devpts /dev/pts devpts gid=5,mode=620 0 0
-tmpfs /run tmpfs defaults 0 0
-devtmpfs /dev devtmpfs mode=0755,nosuid 0 0
-
-# End /etc/fstab
-EOF
-}
-
do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}"
do_copy_boot_files() {
kernel="$(realpath -q '${IMAGE_ROOTFS}/vmlinuz')"
--
2.20.1
next prev parent reply other threads:[~2019-05-28 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 8:58 [PATCH 0/3] Filesystem mounting and machine-id fix claudius.heine.ext
2019-05-28 8:58 ` [PATCH 1/3] wks: added 'rw' to kernel arguments claudius.heine.ext
2019-05-28 17:29 ` Henning Schild
2019-05-29 6:38 ` Claudius Heine
2019-05-28 8:58 ` claudius.heine.ext [this message]
2019-05-28 17:34 ` [PATCH 2/3] image.bbclass: remove fstab generation Henning Schild
2019-05-29 6:47 ` Claudius Heine
2019-05-29 11:11 ` Henning Schild
2019-05-28 8:58 ` [PATCH 3/3] image-postproc-extension: add removal of machine-id claudius.heine.ext
2019-05-28 17:44 ` Henning Schild
2019-05-29 7:00 ` Claudius Heine
2019-05-29 11:06 ` Henning Schild
2019-05-28 19:51 ` Henning Schild
2019-05-29 7:00 ` Matthias Luescher
2019-05-29 7:06 ` Claudius Heine
2019-06-06 17:18 ` Maxim Yu. Osipov
2019-06-04 20:09 ` [PATCH 0/3] Filesystem mounting and machine-id fix Maxim Yu. Osipov
2019-06-05 6:45 ` Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528085814.12967-3-claudius.heine.ext@siemens.com \
--to=claudius.heine.ext@siemens.com \
--cc=ch@denx.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox