From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6695999620571463680 X-Received: by 2002:aa7:d711:: with SMTP id t17mr130867490edq.80.1559064598861; Tue, 28 May 2019 10:29:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:987c:: with SMTP id h57ls3597545edb.12.gmail; Tue, 28 May 2019 10:29:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxwQEfhbARwBQ/kIlVBH1au02WbcfGJi5FuueGW+ydBxIyPl9JoTDz0FQ5sZlE6RpkmkSOR X-Received: by 2002:a50:ad42:: with SMTP id z2mr132697893edc.9.1559064598137; Tue, 28 May 2019 10:29:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559064598; cv=none; d=google.com; s=arc-20160816; b=FGxU7XdJWIJvjWw4JY357F4WumwpZqKF1lOHnNRPQq9Px4yn6oPxybJeNnSzN5FMGR 59a4rKTMNs7h8Kr/ZWfXAKERnkp/VNKeSdpPeH8iW00JFmCHC77tDgcwzywZWWSdUapK fv1YmVEJzsZqzBwPjfTkA10AWcMhHf0saryzu975FnP30dXmFHshCewhTdgVdLPhRyDH 5dAxUBLmKz9zkZN4ZtwToY22ZPMd/v2A3hMmgzC0bQiSPIND1weDA8qUbkicoHHTVYpv 9h2UicwFuL3dQHMiYzQREuBSC4skkNYJ8wjvva1nN8nawIFv/vfbxeQBSINP9i2On2Cv V8nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=wMbCWJQoIyFD36ww1KYlNUG8VjoIh8hbws0hEso9nlA=; b=AjTTxrjqSk7Afxvf6GE8tRIwiUNOMw79Qlho64nX/1X8PawyYLnKc19V1hdpntZpsD /LMZMpAMm4Tt8ySobzGzCOPCqP7zJktbzZqBHGzSoJzL2H/tUy6v+du4GOPJZ9iPmUI6 lp5jpPegzB6xwbMcRovOcw6iXnZTCzPQz1xZNgtL628ZXKCDtRpVYGsvSwIQ71V9H7yR 6f296V3h+r8Yyf5cUMX9pw5OR8RdJVwk/Xguq54W69rSKnOHwgB14kDKwhpAwdcx4H5W NoIa2zE5U6GOMBVBtk7zXCne4uNITmZG2yRwlDpZaiBbnzgeLMTtpSWzkYJiKnVnu6bt 3zfA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id z45si877105edc.3.2019.05.28.10.29.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 10:29:58 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x4SHTv6a009504 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 May 2019 19:29:57 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.69.101]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x4SHTv7T004017; Tue, 28 May 2019 19:29:57 +0200 Date: Tue, 28 May 2019 19:29:55 +0200 From: Henning Schild To: "[ext] claudius.heine.ext@siemens.com" Cc: , Claudius Heine Subject: Re: [PATCH 1/3] wks: added 'rw' to kernel arguments Message-ID: <20190528192955.2abcf9e2@md1za8fc.ad001.siemens.net> In-Reply-To: <20190528085814.12967-2-claudius.heine.ext@siemens.com> References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> <20190528085814.12967-2-claudius.heine.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: PhiJ9HQlj7IK Just looked at recent upstream wic. They do not have the "rw" and are probably using their own fstab-stuff. Can you elaborate why this is required? Not that a care about the minimal change in the fork, the patch does not motivate it. And there seems to be a difference which would prevent us from using random wks files from the internet. Henning Am Tue, 28 May 2019 10:58:12 +0200 schrieb "[ext] claudius.heine.ext@siemens.com" : > From: Claudius Heine > > Signed-off-by: Claudius Heine > --- > meta-isar/scripts/lib/wic/canned-wks/bananapi.wks | 2 +- > meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks | 2 +- > meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks > b/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks index > dbec48e..ad8b46f 100644 --- > a/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks +++ > b/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks @@ -2,4 +2,4 @@ > part u-boot --source rawcopy --sourceparams > "file=/usr/lib/u-boot/Bananapi/u-boo part / --source rootfs-u-boot > --ondisk mmcblk0 --fstype ext4 --label platform --align 1024 > -bootloader --append "rootwait" > +bootloader --append "rootwait rw" > diff --git a/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks > b/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks index > e78429c..43107b6 100644 --- > a/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks +++ > b/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks @@ -4,4 > +4,4 @@ > include common-isar.wks.inc > > -bootloader --timeout=0 --append "rootwait rootfstype=ext4 > video=vesafb vga=0x318 console=tty0 console=ttyS0,115200n8" > +bootloader --timeout=0 --append "rootwait rw rootfstype=ext4 > video=vesafb vga=0x318 console=tty0 console=ttyS0,115200n8" diff > --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks > b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks index > 2afa016..f9e49ca 100644 --- > a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks +++ > b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks @@ -6,4 +6,4 > @@ part /boot --source bootimg-efi-isar --sourceparams > "loader=grub-efi" --ondisk s part / --source rootfs --ondisk sda > --fstype ext4 --label platform --align 1024 --use-uuid -bootloader > --ptable gpt --timeout 3 --append "rootwait console=ttyS0,115200 > console=tty0" +bootloader --ptable gpt --timeout 3 --append "rw > rootwait console=ttyS0,115200 console=tty0"