From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6695999620571463680 X-Received: by 2002:adf:9d8a:: with SMTP id p10mr52186148wre.31.1559064865083; Tue, 28 May 2019 10:34:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:eace:: with SMTP id o14ls1668327wrn.6.gmail; Tue, 28 May 2019 10:34:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFTLS8oETB7xlLe2z5gcXdHFdcyUATO39CulwgegnIn4z4i8mZ6YKfNKViYMSi/MmQeqFl X-Received: by 2002:adf:db89:: with SMTP id u9mr41706265wri.294.1559064864703; Tue, 28 May 2019 10:34:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559064864; cv=none; d=google.com; s=arc-20160816; b=pn1QxdCM600n/kE8u9F9jOSMJ/8HOoqfIT+XHu3YpiOAYb1v1DI1WiM52VfXFEwsL7 CvGG9uKk76WDImLwew2/OFC5aRDEn9MVObEu/tUChyUDtijFx3WvcWDukzTxkdKVD7XD q72MP1NXyi+IlvwwFh1rIFT16DBsaBGI5w/BzTukVXKjTGZNz6nTKq9Vyxp+9g3xskYq /yX4YgoSqQbEMR98kmkEVqPEHNd2y+JYhB47UAa5LFxpJvIZpChG3yKh2cbAcPEuCWdq IKwWzd6clUXKry/PcqXHNLlMJdpNqHDXEMv+fY23QxtZ5CjlPWSjJ0KjvUPJqmtWIoAM wUWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=3oKHskr2W+S0ry4xxXG8douVe3YfVFOUw3dx2YYstjw=; b=DzQTibwaque1i5yRnSVDk3VBf2WDjUl6TRoJEnq5b7wQeJngAgu6VDUeuAdYDqBLfy JTp6F0mpJWHdWKlN3ebfN7PCKlLTCGoLHP/At467rX4HYv9DzN3JLaT8DMn5FwACvfgQ f+xogw7QqcIBeGyaB6WmVIR0YCVSOdzeX0Yn4vaMg7CYAJTJzr23y6HkUMzkxJZuEbHC P14KAB4V3KX00soZcsMjQx1GfX2id5aeEtiXcEdQHdDWZZ1ZW9GdEUr198whPFV0rfT0 nswQx/bdJvnV7LW5sbM+cqsZnwphI1dinFq1EHvMpSyO0hd1V81SKZH97BwokKJN6BN3 S4pg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id j129si165031wmj.4.2019.05.28.10.34.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 10:34:24 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x4SHYOxA026735 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 May 2019 19:34:24 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.69.101]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x4SHYOMw018578; Tue, 28 May 2019 19:34:24 +0200 Date: Tue, 28 May 2019 19:34:22 +0200 From: Henning Schild To: "[ext] claudius.heine.ext@siemens.com" Cc: , Claudius Heine Subject: Re: [PATCH 2/3] image.bbclass: remove fstab generation Message-ID: <20190528193422.305051be@md1za8fc.ad001.siemens.net> In-Reply-To: <20190528085814.12967-3-claudius.heine.ext@siemens.com> References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> <20190528085814.12967-3-claudius.heine.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 0t+TqIO/MruZ Systemd might be default, but is not guaranteed to be installed on a working and officially supported debian. Yes we do kind of need it at the moment (for very few features where other inits can be enabled as needed). But we would at least see a conflict. I.e ssh-key-regen is pulling systemd while someone else is pulling sysvinit. With this patch we might create non-bootable images, which is not OK. Henning Am Tue, 28 May 2019 10:58:13 +0200 schrieb "[ext] claudius.heine.ext@siemens.com" : > From: Claudius Heine > > Generating the fstab is not necessary, since the mounts are either > default [1] or can be described via kernel command line or > systemd.mount files. The current fstab generation mechanism is also > to inflexible to allow easy customization from within an image recipe. > > [1] https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems/ > > Signed-off-by: Claudius Heine > --- > meta/classes/image.bbclass | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 1950263..5682134 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -105,22 +105,6 @@ python set_image_size () { > d.setVarFlag('ROOTFS_SIZE', 'export', '1') > } > > -ROOTFS_CONFIGURE_COMMAND += "image_configure_fstab" > -image_configure_fstab[weight] = "2" > -image_configure_fstab() { > - sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF > -# Begin /etc/fstab > -/dev/root / auto > defaults 0 0 > -proc /proc proc > nosuid,noexec,nodev 0 0 > -sysfs /sys sysfs > nosuid,noexec,nodev 0 0 > -devpts /dev/pts devpts > gid=5,mode=620 0 0 > -tmpfs /run tmpfs > defaults 0 0 > -devtmpfs /dev devtmpfs > mode=0755,nosuid 0 0 - -# End /etc/fstab -EOF -} - > do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" do_copy_boot_files() > { kernel="$(realpath -q '${IMAGE_ROOTFS}/vmlinuz')"