From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6695999620571463680 X-Received: by 2002:a5d:43c9:: with SMTP id v9mr10393238wrr.70.1559073097312; Tue, 28 May 2019 12:51:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:544d:: with SMTP id w13ls5014304wrv.16.gmail; Tue, 28 May 2019 12:51:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzvuh6QWbtlxmGAb42rmz1ID2e30WHMhrzuAuIVTwwqZQt+fQ6cAa4F5/YsIz2roDTTv2/Z X-Received: by 2002:a05:6000:120a:: with SMTP id e10mr3593782wrx.171.1559073096891; Tue, 28 May 2019 12:51:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559073096; cv=none; d=google.com; s=arc-20160816; b=V79vJuBzQLFbY0f1O1cc8FPh5boU4GzjMIjw4y4IYJ4LAHs4eDYn8X2YA23ekBQ47k I0eSAad9YPZVhhvpxCAXMfDLIswP34ehPo7Zuq+DmVGDa/ZouodCinPPm+ul5xz05ex5 3vv86L73s4OqMV4vToUxbSy3u8gzOIU8AIDMbTs22v0Nq+WKC4C6QIdZvlU7Wczwg1TJ VmfFr455jYJg6A/yWv4bPTu7jxVqMaaqSz7hmE7+2HaKfW3qTIr1Jvt0FTm3Es6mYidP Qv8vxolrKHGDa/ABA835/1w59wznHCYNxubyuIFz6YfpCIRirZQ5PKCOmLSsMmk8v252 W3yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=18I7GmQsFOI++SnnIJ3Laiw1DmuUz820v37XzjPJVVI=; b=bcj+NVB2VxMVcH0xS8DbGigs9MS/UTIjMHpmwfxh9qjJPusCQNq3he2tlrb26PddLm TxnaFkHnr5OiIjJ13c7ftj/qKAQyLqF4JLyBT2jAFOFiOX0MUcOPCoyWmx7m276sxIo5 l5wxX/WkbRGBbk4mpLfQjjxIAGJUaUL5fNRwT4k2YBCfJBoaXTeglYx0gzS5ltshM/fv pXjQsqODzlwoCBc2Flr/17B0MMVihVSr7t9FEDGI6fKsRh0GmXctWOqv5m42AZu8I4Iu H/Yh90xpSXAOMJlxsTmHUlDhBsgtrl0k2s2M9oIwJgp4PHCjGtE1jdYNHx+sFFSogK2N nL2g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id h189si148836wmh.2.2019.05.28.12.51.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 12:51:36 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x4SJpZ7Y009025 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 May 2019 21:51:35 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.5.213]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x4SJpYXq029545; Tue, 28 May 2019 21:51:34 +0200 Date: Tue, 28 May 2019 21:51:30 +0200 From: Henning Schild To: "[ext] claudius.heine.ext@siemens.com" , Matthias.=?UTF-8?B?TMO8c2NoZXI8bS5sdWVzY2hlckBkYXRhY29tbS5jaD4=?=@mail1.sbs.de Cc: , Claudius Heine Subject: Re: [PATCH 3/3] image-postproc-extension: add removal of machine-id Message-ID: <20190528215130.6b79bd37@md1za8fc.ad001.siemens.net> In-Reply-To: <20190528085814.12967-4-claudius.heine.ext@siemens.com> References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> <20190528085814.12967-4-claudius.heine.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: F1d5W1vwZ+U4 Am Tue, 28 May 2019 10:58:14 +0200 schrieb "[ext] claudius.heine.ext@siemens.com" : > From: Claudius Heine >=20 > The machine-id(5) should contain a unique id of the machine, but since > this file is created by the systemd postinst script, every machine > using the same image would have the same id. >=20 > The file is removed in a postprocessing step and will be regenerated > by systemd on the first boot. Maybe you can add a Reported-by: Matthias L=C3=BCscher He is the maintainer of https://www.get-edi.io/ and mentioned that in a talk i attended before i brought that up for Isar. Matthias let us know if you care. Henning > Signed-off-by: Claudius Heine > --- > meta/classes/image-postproc-extension.bbclass | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) >=20 > diff --git a/meta/classes/image-postproc-extension.bbclass > b/meta/classes/image-postproc-extension.bbclass index > 625ba7d..495eae6 100644 --- > a/meta/classes/image-postproc-extension.bbclass +++ > b/meta/classes/image-postproc-extension.bbclass @@ -26,8 +26,7 @@ > update_etc_os_release() { fi > } > =20 > -ROOTFS_POSTPROCESS_COMMAND =3D+ "image_postprocess_configure > image_postprocess_mark" - > +ROOTFS_POSTPROCESS_COMMAND =3D+ "image_postprocess_configure" > image_postprocess_configure() { > # Configure root filesystem > if [ -n "${DISTRO_CONFIG_SCRIPT}" ]; then > @@ -39,8 +38,16 @@ image_postprocess_configure() { > fi > } > =20 > +ROOTFS_POSTPROCESS_COMMAND =3D+ "image_postprocess_mark" > + > image_postprocess_mark() { > BUILD_ID=3D$(get_build_id) > update_etc_os_release \ > --build-id "${BUILD_ID}" --variant "${DESCRIPTION}" > } > + > +ROOTFS_POSTPROCESS_COMMAND =3D+ "image_postprocess_machine_id" > +image_postprocess_machine_id() { > + # systemd(1) takes care of recreating the machine-id on first > boot > + sudo rm -f '${IMAGE_ROOTFS}/etc/machine-id' > +}