Re: [PATCH 2/3] image.bbclass: remove fstab generation

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 29 May 2019 08:47:39 +0200
schrieb Claudius Heine <claudius.heine.ext@siemens.com>:

> On 28/05/2019 19.34, Henning Schild wrote:
> > Systemd might be default, but is not guaranteed to be installed on a
> > working and officially supported debian.
> > 
> > Yes we do kind of need it at the moment (for very few features where
> > other inits can be enabled as needed). But we would at least see a
> > conflict. I.e ssh-key-regen is pulling systemd while someone else is
> > pulling sysvinit.
> > 
> > With this patch we might create non-bootable images, which is not
> > OK.  
> 
> I would like to support any init system that debian supports as well, 
> but I currently don't have any project that does not use systemd with 
> isar, so for me there is currently no use case.
> 
> But if you would implement a test case for SysV in meta-isar, then I 
> could try to find a solution that works with SysV as well as systemd
> or any other init system we have a test case for (if the workload is
> at a manageable level). As is currently stands though we only test
> systemd and therefor officially only support that in isar.

You are saying it is ok to break a feature because we currently have
no testcase that would detect the problem?

The testcase is really simple, but including it into Isar will grow or
CI even further. For a corner-case. So i would not add a test-case to
keep CI clean of such a corner-case.

The compromise is to manually test the corner-case when introducing
patches that potentially break it. And the test is pretty easy

IMAGE_PREINSTALL += "sysvinit-core"

and make sure nothing pulls in systemd to replace that guy again.

Henning

> Claudius
> 
> > 
> > Henning
> > 
> > Am Tue, 28 May 2019 10:58:13 +0200
> > schrieb "[ext] claudius.heine.ext@siemens.com"
> > <claudius.heine.ext@siemens.com>:
> >   
> >> From: Claudius Heine <ch@denx.de>
> >>
> >> Generating the fstab is not necessary, since the mounts are either
> >> default [1] or can be described via kernel command line or
> >> systemd.mount files. The current fstab generation mechanism is also
> >> to inflexible to allow easy customization from within an image
> >> recipe.
> >>
> >> [1]
> >> https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems/
> >>
> >> Signed-off-by: Claudius Heine <ch@denx.de>
> >> ---
> >>   meta/classes/image.bbclass | 16 ----------------
> >>   1 file changed, 16 deletions(-)
> >>
> >> diff --git a/meta/classes/image.bbclass
> >> b/meta/classes/image.bbclass index 1950263..5682134 100644
> >> --- a/meta/classes/image.bbclass
> >> +++ b/meta/classes/image.bbclass
> >> @@ -105,22 +105,6 @@ python set_image_size () {
> >>       d.setVarFlag('ROOTFS_SIZE', 'export', '1')
> >>   }
> >>   
> >> -ROOTFS_CONFIGURE_COMMAND += "image_configure_fstab"
> >> -image_configure_fstab[weight] = "2"
> >> -image_configure_fstab() {
> >> -    sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF
> >> -# Begin /etc/fstab
> >> -/dev/root	/		auto
> >> defaults		0	0
> >> -proc		/proc		proc
> >> nosuid,noexec,nodev	0	0
> >> -sysfs		/sys		sysfs
> >> nosuid,noexec,nodev	0	0
> >> -devpts		/dev/pts	devpts
> >> gid=5,mode=620		0	0
> >> -tmpfs		/run		tmpfs
> >> defaults		0	0
> >> -devtmpfs	/dev		devtmpfs
> >> mode=0755,nosuid	0	0 - -# End /etc/fstab -EOF -} -
> >> do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}"
> >> do_copy_boot_files() { kernel="$(realpath -q
> >> '${IMAGE_ROOTFS}/vmlinuz')"  
> >   
>