From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6695999620571463680 X-Received: by 2002:a1c:7303:: with SMTP id d3mr6370838wmb.119.1559128321827; Wed, 29 May 2019 04:12:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:eace:: with SMTP id o14ls426245wrn.6.gmail; Wed, 29 May 2019 04:12:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwpOfFk/KF5jPEdm6aBfnwe1ZKmJ21fpCrMxQr8Lx5mQVsLtmAGW0rPkGAkAhEaNnom4FXY X-Received: by 2002:adf:b6a5:: with SMTP id j37mr78667009wre.4.1559128321462; Wed, 29 May 2019 04:12:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559128321; cv=none; d=google.com; s=arc-20160816; b=pk0IF7HFQPqStWI1G9ktHWQktqsXWmt1xgGj5W2ehjWo+t5lER9KX3yFsmm6AT3iaC 1+Fu9iqXyORjA7B6TXypeglYBysylygJU1MTvxZd0Zl6uXth7ueU7CgutrnW6BC4Gvlq 0WKBIdCoCd9J6sy4dJm3gLlG9dVrolkYpjNaZknGr2ockOmWXcPfk9rx4SdUh+Yg4UqZ lOn6gNWRRUPZ+YQtfsx0m9zQX8Pdai3mCsLoUiZdoxEbTs1jOfEw0kVVXf3Hx87a2mdm vMz7zZICYxCKv0Tto447IBGZYurdYtfxkxjhz0yW8yfBonQCUyhJpdBEzxcwMUFzl5oX XxzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=5vFDHkEfJPBJ09/s053rKnwhlA2JCqu/x2gJDT0N89g=; b=kNal2YVZHCoEQcvetLEs2xxNeKjleMsIVV1Uy7jw+Qsa0oqdK9/oJIwKye6z981LsH KNiDSmHMq6M5/cZn8jWwpJedcz+5pmPySZAUiCU8tIxNQHOKP9IYOz65484YKOZKKDhR 0COmSNDyuYIUDvY6RYYafxzjoJ9M/nFg6i24czawBKba36MflfgREUVxZL1u86+jZ8tf tiPD55/MvG57DFZbD3atl99EwNzup6gF685slFHaPKcrckQ7TmPrprTNw0ip3PHd2xKO ZctOGDPfCr72gIjTsm/d6mcY1OHIpxROPbwsEADGD3lE3hzNB8El8vFclOnfCbsY24Y/ qAYA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id w18si25672wrp.5.2019.05.29.04.12.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 04:12:01 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x4TBC052012445 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 May 2019 13:12:00 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.69.101]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x4TBC07d028182; Wed, 29 May 2019 13:12:00 +0200 Date: Wed, 29 May 2019 13:11:59 +0200 From: Henning Schild To: Claudius Heine Cc: , Claudius Heine Subject: Re: [PATCH 2/3] image.bbclass: remove fstab generation Message-ID: <20190529131159.3e5c10a1@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> <20190528085814.12967-3-claudius.heine.ext@siemens.com> <20190528193422.305051be@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: sZHz4RgykM01 Am Wed, 29 May 2019 08:47:39 +0200 schrieb Claudius Heine : > On 28/05/2019 19.34, Henning Schild wrote: > > Systemd might be default, but is not guaranteed to be installed on a > > working and officially supported debian. > > > > Yes we do kind of need it at the moment (for very few features where > > other inits can be enabled as needed). But we would at least see a > > conflict. I.e ssh-key-regen is pulling systemd while someone else is > > pulling sysvinit. > > > > With this patch we might create non-bootable images, which is not > > OK. > > I would like to support any init system that debian supports as well, > but I currently don't have any project that does not use systemd with > isar, so for me there is currently no use case. > > But if you would implement a test case for SysV in meta-isar, then I > could try to find a solution that works with SysV as well as systemd > or any other init system we have a test case for (if the workload is > at a manageable level). As is currently stands though we only test > systemd and therefor officially only support that in isar. You are saying it is ok to break a feature because we currently have no testcase that would detect the problem? The testcase is really simple, but including it into Isar will grow or CI even further. For a corner-case. So i would not add a test-case to keep CI clean of such a corner-case. The compromise is to manually test the corner-case when introducing patches that potentially break it. And the test is pretty easy IMAGE_PREINSTALL += "sysvinit-core" and make sure nothing pulls in systemd to replace that guy again. Henning > Claudius > > > > > Henning > > > > Am Tue, 28 May 2019 10:58:13 +0200 > > schrieb "[ext] claudius.heine.ext@siemens.com" > > : > > > >> From: Claudius Heine > >> > >> Generating the fstab is not necessary, since the mounts are either > >> default [1] or can be described via kernel command line or > >> systemd.mount files. The current fstab generation mechanism is also > >> to inflexible to allow easy customization from within an image > >> recipe. > >> > >> [1] > >> https://www.freedesktop.org/wiki/Software/systemd/APIFileSystems/ > >> > >> Signed-off-by: Claudius Heine > >> --- > >> meta/classes/image.bbclass | 16 ---------------- > >> 1 file changed, 16 deletions(-) > >> > >> diff --git a/meta/classes/image.bbclass > >> b/meta/classes/image.bbclass index 1950263..5682134 100644 > >> --- a/meta/classes/image.bbclass > >> +++ b/meta/classes/image.bbclass > >> @@ -105,22 +105,6 @@ python set_image_size () { > >> d.setVarFlag('ROOTFS_SIZE', 'export', '1') > >> } > >> > >> -ROOTFS_CONFIGURE_COMMAND += "image_configure_fstab" > >> -image_configure_fstab[weight] = "2" > >> -image_configure_fstab() { > >> - sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF > >> -# Begin /etc/fstab > >> -/dev/root / auto > >> defaults 0 0 > >> -proc /proc proc > >> nosuid,noexec,nodev 0 0 > >> -sysfs /sys sysfs > >> nosuid,noexec,nodev 0 0 > >> -devpts /dev/pts devpts > >> gid=5,mode=620 0 0 > >> -tmpfs /run tmpfs > >> defaults 0 0 > >> -devtmpfs /dev devtmpfs > >> mode=0755,nosuid 0 0 - -# End /etc/fstab -EOF -} - > >> do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" > >> do_copy_boot_files() { kernel="$(realpath -q > >> '${IMAGE_ROOTFS}/vmlinuz')" > > >