public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] dpkg-base: Do not fail clean if there are no packages
Date: Mon, 8 Jul 2019 14:40:47 +0200	[thread overview]
Message-ID: <20190708144047.37104f95@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <2f342304-e558-f7e1-7550-116620b5f456@siemens.com>

Am Fri, 5 Jul 2019 20:04:39 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/classes/dpkg-base.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/dpkg-base.bbclass
> b/meta/classes/dpkg-base.bbclass index 3e6ba8c..2e439d6 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -101,7 +101,7 @@ do_build() {
>  CLEANFUNCS += "repo_clean"
>  
>  repo_clean() {
> -    DEBS=$( ls ${S}/../*.deb )
> +    DEBS=$( ls ${S}/../*.deb || true )

That is not a good idea because is ignores too many errors. I would
suggest using find instead.

Henning

>      if [ -n "${DEBS}" ]; then
>          for d in ${DEBS}; do
>              p=$( dpkg-deb --show --showformat '${Package}' ${d} )


  reply	other threads:[~2019-07-08 12:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 18:04 Jan Kiszka
2019-07-08 12:40 ` Henning Schild [this message]
2019-07-09 12:04   ` [PATCH v2] " Jan Kiszka
2019-07-23  8:45     ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708144047.37104f95@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox