Re: [PATCH] image-postproc-extension: empty mechine-id

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 11 Jul 2019 07:34:22 +0200
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> On 11.07.19 06:06, [ext] Su, Bao Cheng wrote:
> > On 7/10/2019 7:44 PM, Schild, Henning (CT RDA IOT SES-DE) wrote:  
> >> Am Wed, 10 Jul 2019 10:48:31 +0200
> >> schrieb Baurzhan Ismagulov <ibr@radix50.net>:
> >>  
> >>> Hello Bao Cheng,
> >>>
> >>> On Mon, Jul 08, 2019 at 10:57:36AM +0000, Su, Bao Cheng wrote:  
> >>>> According to manpage of debian machine-id @
> >>>> https://manpages.debian.org/buster/systemd/machine-id.5.en.html,
> >>>> /etc/machine-id should be empty instead of removing.
> >>>>
> >>>> Also according to above manpage, the dbus machine-id is copied to
> >>>> /etc/machine-id if systemd machine-id is empty. However, the dbus
> >>>> machine-id is also created during isar building, which stays the
> >>>> same for every machine using the same image.
> >>>>
> >>>> So here instead of removing, empty this file, and the mechine id
> >>>> will be regenerated at the first boot. Also remove the dbus
> >>>> machine-id to prevent copying.  
> >>>
> >>> Thanks, applied to next.  
> >>
> >> Mhh the commit message looks pretty ugly. Probably because v2 was
> >> not actually done with git format-patch.
> >>
> >> I would suggest to clean that up and force-push next.
> >>  
> > yeah I saw the ugly message from the github.com. Do I have the 
> > permissions to force-push the next branch? or do I need re-send the
> > patch to mailing list?
> >   
> 
> Baurzhan, please re-commit this one. Rewriting next is now less
> critical as it used to be.

Just re-read CONTRIBUTING.md and indeed there is no work about "next"
being rebasing ... There even is "please base your patches on next".

In this case rebasing (force-pushing) in indeed a no-go. Is that a bug
in the description or does Isar not have a rebasing staging branch?

I still remember the days when master was months behind next, forcing
everyone on next. In these days it was a no-go because master was too
slow, but i always assumed it would be possible.

Henning

> Jan
>