From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6711131604704559104 X-Received: by 2002:a1c:a6d3:: with SMTP id p202mr5167678wme.26.1562863030873; Thu, 11 Jul 2019 09:37:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:53c6:: with SMTP id a6ls2144922wrw.2.gmail; Thu, 11 Jul 2019 09:37:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwNuWtN74cSkw4Arsn7wdFkA3NUfMX8nKoGyDngLrIBL9z+WdNC+ZdoORdfwZoHNVzajGyy X-Received: by 2002:adf:f904:: with SMTP id b4mr6321701wrr.291.1562863030493; Thu, 11 Jul 2019 09:37:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562863030; cv=none; d=google.com; s=arc-20160816; b=NIjr4lG9CJN9lEVmrITdsk4WLkOKXb8mFexn5PLSnhj85/YOl306zh6Rn2EdkNUn4c 2Ayp+d/zUvDWTPqEl4oH8VyxketH0G48pF5dD5zg7kbfQEuSCqaI2N5EBd2fqQz47z6u /aj27kJ696OSTqM/ppiLpvsRRkP0vSs0pqalS1AXecggFSCaEjZGYPUYuAT9ylMgcY0N tifVMERlsKr1r6KCT5fcaUT4aF6GOzpHjz3jcTR5Mv2zW4WfLvgmg2hhB/Icf3VFutsq 4aXVdRkIyu/+EFuQa5p+4g21MQwrUYGpQr28x6cQT1UOg2YZSuY7t3Jie6uPJ1dAw/md E4FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=MWoueoktJoruAVjJlWdSHYy9Mf+BI1bCwx6BFQNuGnI=; b=dTVpF0JB62Enq3g6YNNjjAddOJgScB9SD1+YnchhE1BnbfXZKY0OjZEdHuCdmrTzoe nJKJfbNzQO3SrUJotjQP759LP/Oum21y1veXrX82giWHb81mOLeiIWlRfFNuyA1A+c9W 1woNB6H2FOce/mC41RDI2Y/HdjUVKWXXSJy6+hL4sjM/GbeK5X6SQRQghnNUMe6bQgtf ImIcPFW4vT4Tzk3kcbsMHXRcKyJYtF5+sguQzPRswisRGKGi4cM37zrj1r/gYpgHkoZH FYWG9TTI621zmKTFV6rQsSFHYdJ7bzroojlREGAKxNvs2vj4z9Z/1o7/oyWOO3G6s6PX 9+6A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id v21si636817wmc.1.2019.07.11.09.37.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jul 2019 09:37:10 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x6BGbAeJ018255 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jul 2019 18:37:10 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.68.208]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x6BGb9YE018776; Thu, 11 Jul 2019 18:37:09 +0200 Date: Thu, 11 Jul 2019 18:37:09 +0200 From: Henning Schild To: Jan Kiszka Cc: "[ext] Su, Bao Cheng" , Baurzhan Ismagulov , "isar-users@googlegroups.com" Subject: Re: [PATCH] image-postproc-extension: empty mechine-id Message-ID: <20190711183709.009be9e7@md1za8fc.ad001.siemens.net> In-Reply-To: References: <7a6b3fd0f6414612ab93e8a0044b2d96@siemens.com> <8f32d02f4d6e433fb17bb80cd0ea5a66@siemens.com> <20190710084831.GE8266@yssyq.m.ilbers.de> <20190710134407.318c6842@md1za8fc.ad001.siemens.net> <10e6cb8c30024cecae35c0b1a0f9dbb9@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 4Kg7GzO3Sf9x Am Thu, 11 Jul 2019 07:34:22 +0200 schrieb Jan Kiszka : > On 11.07.19 06:06, [ext] Su, Bao Cheng wrote: > > On 7/10/2019 7:44 PM, Schild, Henning (CT RDA IOT SES-DE) wrote: > >> Am Wed, 10 Jul 2019 10:48:31 +0200 > >> schrieb Baurzhan Ismagulov : > >> > >>> Hello Bao Cheng, > >>> > >>> On Mon, Jul 08, 2019 at 10:57:36AM +0000, Su, Bao Cheng wrote: > >>>> According to manpage of debian machine-id @ > >>>> https://manpages.debian.org/buster/systemd/machine-id.5.en.html, > >>>> /etc/machine-id should be empty instead of removing. > >>>> > >>>> Also according to above manpage, the dbus machine-id is copied to > >>>> /etc/machine-id if systemd machine-id is empty. However, the dbus > >>>> machine-id is also created during isar building, which stays the > >>>> same for every machine using the same image. > >>>> > >>>> So here instead of removing, empty this file, and the mechine id > >>>> will be regenerated at the first boot. Also remove the dbus > >>>> machine-id to prevent copying. > >>> > >>> Thanks, applied to next. > >> > >> Mhh the commit message looks pretty ugly. Probably because v2 was > >> not actually done with git format-patch. > >> > >> I would suggest to clean that up and force-push next. > >> > > yeah I saw the ugly message from the github.com. Do I have the > > permissions to force-push the next branch? or do I need re-send the > > patch to mailing list? > > > > Baurzhan, please re-commit this one. Rewriting next is now less > critical as it used to be. Just re-read CONTRIBUTING.md and indeed there is no work about "next" being rebasing ... There even is "please base your patches on next". In this case rebasing (force-pushing) in indeed a no-go. Is that a bug in the description or does Isar not have a rebasing staging branch? I still remember the days when master was months behind next, forcing everyone on next. In these days it was a no-go because master was too slow, but i always assumed it would be possible. Henning > Jan >