* [PATCH] ubifs-img: Correct function name
@ 2019-07-17 11:32 Quirin Gylstorff
2019-07-17 11:53 ` Henning Schild
2019-07-17 12:31 ` [PATCH v2] " Quirin Gylstorff
0 siblings, 2 replies; 5+ messages in thread
From: Quirin Gylstorff @ 2019-07-17 11:32 UTC (permalink / raw)
To: isar-users; +Cc: Quirin Gylstorff, Henning Schild
Fix python exception:
ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb: Error executing a python functi
on in <code>:
The stack trace of python calls that resulted in this exception/failure was:
File: '<code>', lineno: 5, function: <module>
0001:__anon_125__work_isar_meta_classes_base_bbclass(d)
0002:__anon_144__work_isar_meta_classes_base_bbclass(d)
0003:__anon_34__work_isar_meta_classes_image_bbclass(d)
0004:__anon_20__work_isar_meta_classes_buildchroot_bbclass(d)
*** 0005:__anon_9__work_isar_meta_classes_ubifs_img_bbclass(d)
0006:__anon_9__work_isar_meta_classes_ubi_img_bbclass(d)
File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8, function: __anon_9__work_isar_meta_classes
_ubifs_img_bbclass
0004:# SPDX-License-Identifier: MIT
0005:
0006:python() {
0007: if not d.getVar("MKUBIFS_ARGS"):
*** 0008: raise bb.parse.skiprecipe("mkubifs_args must be set")
0009:}
0010:
0011:UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
0012:
Exception: AttributeError: module 'bb.parse' has no attribute 'skiprecipe'
---
meta/classes/ubifs-img.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
index aeb986c..78926f6 100644
--- a/meta/classes/ubifs-img.bbclass
+++ b/meta/classes/ubifs-img.bbclass
@@ -5,7 +5,7 @@
python() {
if not d.getVar("MKUBIFS_ARGS"):
- raise bb.parse.skiprecipe("mkubifs_args must be set")
+ raise bb.parse.SkipRecipe("mkubifs_args must be set")
}
UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ubifs-img: Correct function name
2019-07-17 11:32 [PATCH] ubifs-img: Correct function name Quirin Gylstorff
@ 2019-07-17 11:53 ` Henning Schild
2019-07-17 12:31 ` [PATCH v2] " Quirin Gylstorff
1 sibling, 0 replies; 5+ messages in thread
From: Henning Schild @ 2019-07-17 11:53 UTC (permalink / raw)
To: Quirin Gylstorff; +Cc: isar-users
The content looks good to me. I think the commit message does not
require the whole trace. And the commit message needs a Signed-Off.
Henning
Am Wed, 17 Jul 2019 13:32:39 +0200
schrieb Quirin Gylstorff <quirin.gylstorff@siemens.com>:
> Fix python exception:
>
> ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb:
> Error executing a python functi on in <code>:
>
> The stack trace of python calls that resulted in this
> exception/failure was: File: '<code>', lineno: 5, function: <module>
> 0001:__anon_125__work_isar_meta_classes_base_bbclass(d)
> 0002:__anon_144__work_isar_meta_classes_base_bbclass(d)
> 0003:__anon_34__work_isar_meta_classes_image_bbclass(d)
> 0004:__anon_20__work_isar_meta_classes_buildchroot_bbclass(d)
> *** 0005:__anon_9__work_isar_meta_classes_ubifs_img_bbclass(d)
> 0006:__anon_9__work_isar_meta_classes_ubi_img_bbclass(d)
> File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8,
> function: __anon_9__work_isar_meta_classes _ubifs_img_bbclass
> 0004:# SPDX-License-Identifier: MIT
> 0005:
> 0006:python() {
> 0007: if not d.getVar("MKUBIFS_ARGS"):
> *** 0008: raise bb.parse.skiprecipe("mkubifs_args must be
> set") 0009:}
> 0010:
> 0011:UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
> 0012:
> Exception: AttributeError: module 'bb.parse' has no attribute
> 'skiprecipe' ---
> meta/classes/ubifs-img.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/ubifs-img.bbclass
> b/meta/classes/ubifs-img.bbclass index aeb986c..78926f6 100644
> --- a/meta/classes/ubifs-img.bbclass
> +++ b/meta/classes/ubifs-img.bbclass
> @@ -5,7 +5,7 @@
>
> python() {
> if not d.getVar("MKUBIFS_ARGS"):
> - raise bb.parse.skiprecipe("mkubifs_args must be set")
> + raise bb.parse.SkipRecipe("mkubifs_args must be set")
> }
>
> UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] ubifs-img: Correct function name
2019-07-17 11:32 [PATCH] ubifs-img: Correct function name Quirin Gylstorff
2019-07-17 11:53 ` Henning Schild
@ 2019-07-17 12:31 ` Quirin Gylstorff
2019-07-24 7:49 ` Henning Schild
2019-07-29 11:39 ` Baurzhan Ismagulov
1 sibling, 2 replies; 5+ messages in thread
From: Quirin Gylstorff @ 2019-07-17 12:31 UTC (permalink / raw)
To: isar-users
Fix python exception:
ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb: Error executing a python functi
on in <code>:
...
File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8, function: __anon_9__work_isar_meta_classes
_ubifs_img_bbclass
...
Exception: AttributeError: module 'bb.parse' has no attribute 'skiprecipe'
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
meta/classes/ubifs-img.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
index aeb986c..78926f6 100644
--- a/meta/classes/ubifs-img.bbclass
+++ b/meta/classes/ubifs-img.bbclass
@@ -5,7 +5,7 @@
python() {
if not d.getVar("MKUBIFS_ARGS"):
- raise bb.parse.skiprecipe("mkubifs_args must be set")
+ raise bb.parse.SkipRecipe("mkubifs_args must be set")
}
UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ubifs-img: Correct function name
2019-07-17 12:31 ` [PATCH v2] " Quirin Gylstorff
@ 2019-07-24 7:49 ` Henning Schild
2019-07-29 11:39 ` Baurzhan Ismagulov
1 sibling, 0 replies; 5+ messages in thread
From: Henning Schild @ 2019-07-24 7:49 UTC (permalink / raw)
To: [ext] Quirin Gylstorff; +Cc: isar-users
Should get merged. The "original" code was probably just a wrongly
resolved merge conflict.
Henning
Am Wed, 17 Jul 2019 14:31:20 +0200
schrieb "[ext] Quirin Gylstorff" <quirin.gylstorff@siemens.com>:
> Fix python exception:
>
> ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb:
> Error executing a python functi on in <code>:
> ...
> File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8,
> function: __anon_9__work_isar_meta_classes _ubifs_img_bbclass
> ...
> Exception: AttributeError: module 'bb.parse' has no attribute
> 'skiprecipe'
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> meta/classes/ubifs-img.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/ubifs-img.bbclass
> b/meta/classes/ubifs-img.bbclass index aeb986c..78926f6 100644
> --- a/meta/classes/ubifs-img.bbclass
> +++ b/meta/classes/ubifs-img.bbclass
> @@ -5,7 +5,7 @@
>
> python() {
> if not d.getVar("MKUBIFS_ARGS"):
> - raise bb.parse.skiprecipe("mkubifs_args must be set")
> + raise bb.parse.SkipRecipe("mkubifs_args must be set")
> }
>
> UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ubifs-img: Correct function name
2019-07-17 12:31 ` [PATCH v2] " Quirin Gylstorff
2019-07-24 7:49 ` Henning Schild
@ 2019-07-29 11:39 ` Baurzhan Ismagulov
1 sibling, 0 replies; 5+ messages in thread
From: Baurzhan Ismagulov @ 2019-07-29 11:39 UTC (permalink / raw)
To: isar-users
On Wed, Jul 17, 2019 at 02:31:20PM +0200, Quirin Gylstorff wrote:
> Exception: AttributeError: module 'bb.parse' has no attribute 'skiprecipe'
Thanks, applied to next.
With kind regards,
Baurzhan.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-29 11:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 11:32 [PATCH] ubifs-img: Correct function name Quirin Gylstorff
2019-07-17 11:53 ` Henning Schild
2019-07-17 12:31 ` [PATCH v2] " Quirin Gylstorff
2019-07-24 7:49 ` Henning Schild
2019-07-29 11:39 ` Baurzhan Ismagulov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox