public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Quirin Gylstorff <quirin.gylstorff@siemens.com>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH] ubifs-img: Correct function name
Date: Wed, 17 Jul 2019 13:53:10 +0200	[thread overview]
Message-ID: <20190717135310.18c8cf62@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20190717113239.15136-1-quirin.gylstorff@siemens.com>

The content looks good to me. I think the commit message does not
require the whole trace. And the commit message needs a Signed-Off.

Henning

Am Wed, 17 Jul 2019 13:32:39 +0200
schrieb Quirin Gylstorff <quirin.gylstorff@siemens.com>:

> Fix python exception:
> 
> ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb:
> Error executing a python functi on in <code>:
> 
> The stack trace of python calls that resulted in this
> exception/failure was: File: '<code>', lineno: 5, function: <module>
>      0001:__anon_125__work_isar_meta_classes_base_bbclass(d)
>      0002:__anon_144__work_isar_meta_classes_base_bbclass(d)
>      0003:__anon_34__work_isar_meta_classes_image_bbclass(d)
>      0004:__anon_20__work_isar_meta_classes_buildchroot_bbclass(d)
>  *** 0005:__anon_9__work_isar_meta_classes_ubifs_img_bbclass(d)
>      0006:__anon_9__work_isar_meta_classes_ubi_img_bbclass(d)
> File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8,
> function: __anon_9__work_isar_meta_classes _ubifs_img_bbclass
>      0004:# SPDX-License-Identifier: MIT
>      0005:
>      0006:python() {
>      0007:    if not d.getVar("MKUBIFS_ARGS"):
>  *** 0008:        raise bb.parse.skiprecipe("mkubifs_args must be
> set") 0009:}
>      0010:
>      0011:UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
>      0012:
> Exception: AttributeError: module 'bb.parse' has no attribute
> 'skiprecipe' ---
>  meta/classes/ubifs-img.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/ubifs-img.bbclass
> b/meta/classes/ubifs-img.bbclass index aeb986c..78926f6 100644
> --- a/meta/classes/ubifs-img.bbclass
> +++ b/meta/classes/ubifs-img.bbclass
> @@ -5,7 +5,7 @@
>  
>  python() {
>      if not d.getVar("MKUBIFS_ARGS"):
> -        raise bb.parse.skiprecipe("mkubifs_args must be set")
> +        raise bb.parse.SkipRecipe("mkubifs_args must be set")
>  }
>  
>  UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"


  reply	other threads:[~2019-07-17 11:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 11:32 Quirin Gylstorff
2019-07-17 11:53 ` Henning Schild [this message]
2019-07-17 12:31 ` [PATCH v2] " Quirin Gylstorff
2019-07-24  7:49   ` Henning Schild
2019-07-29 11:39   ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190717135310.18c8cf62@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox