[PATCH] ubifs-img: Correct function name

[PATCH] ubifs-img: Correct function name

[Quirin Gylstorff]

Fix python exception:

ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb: Error executing a python functi
on in <code>:

The stack trace of python calls that resulted in this exception/failure was:
File: '<code>', lineno: 5, function: <module>
     0001:__anon_125__work_isar_meta_classes_base_bbclass(d)
     0002:__anon_144__work_isar_meta_classes_base_bbclass(d)
     0003:__anon_34__work_isar_meta_classes_image_bbclass(d)
     0004:__anon_20__work_isar_meta_classes_buildchroot_bbclass(d)
 *** 0005:__anon_9__work_isar_meta_classes_ubifs_img_bbclass(d)
     0006:__anon_9__work_isar_meta_classes_ubi_img_bbclass(d)
File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8, function: __anon_9__work_isar_meta_classes
_ubifs_img_bbclass
     0004:# SPDX-License-Identifier: MIT
     0005:
     0006:python() {
     0007:    if not d.getVar("MKUBIFS_ARGS"):
 *** 0008:        raise bb.parse.skiprecipe("mkubifs_args must be set")
     0009:}
     0010:
     0011:UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
     0012:
Exception: AttributeError: module 'bb.parse' has no attribute 'skiprecipe'
---
 meta/classes/ubifs-img.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
index aeb986c..78926f6 100644
--- a/meta/classes/ubifs-img.bbclass
+++ b/meta/classes/ubifs-img.bbclass
@@ -5,7 +5,7 @@
 
 python() {
     if not d.getVar("MKUBIFS_ARGS"):
-        raise bb.parse.skiprecipe("mkubifs_args must be set")
+        raise bb.parse.SkipRecipe("mkubifs_args must be set")
 }
 
 UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
-- 
2.20.1

Re: [PATCH] ubifs-img: Correct function name

[Henning Schild]

The content looks good to me. I think the commit message does not
require the whole trace. And the commit message needs a Signed-Off.

Henning

Am Wed, 17 Jul 2019 13:32:39 +0200
schrieb Quirin Gylstorff <quirin.gylstorff@siemens.com>:

> Fix python exception:
> 
> ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb:
> Error executing a python functi on in <code>:
> 
> The stack trace of python calls that resulted in this
> exception/failure was: File: '<code>', lineno: 5, function: <module>
>      0001:__anon_125__work_isar_meta_classes_base_bbclass(d)
>      0002:__anon_144__work_isar_meta_classes_base_bbclass(d)
>      0003:__anon_34__work_isar_meta_classes_image_bbclass(d)
>      0004:__anon_20__work_isar_meta_classes_buildchroot_bbclass(d)
>  *** 0005:__anon_9__work_isar_meta_classes_ubifs_img_bbclass(d)
>      0006:__anon_9__work_isar_meta_classes_ubi_img_bbclass(d)
> File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8,
> function: __anon_9__work_isar_meta_classes _ubifs_img_bbclass
>      0004:# SPDX-License-Identifier: MIT
>      0005:
>      0006:python() {
>      0007:    if not d.getVar("MKUBIFS_ARGS"):
>  *** 0008:        raise bb.parse.skiprecipe("mkubifs_args must be
> set") 0009:}
>      0010:
>      0011:UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
>      0012:
> Exception: AttributeError: module 'bb.parse' has no attribute
> 'skiprecipe' ---
>  meta/classes/ubifs-img.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/ubifs-img.bbclass
> b/meta/classes/ubifs-img.bbclass index aeb986c..78926f6 100644
> --- a/meta/classes/ubifs-img.bbclass
> +++ b/meta/classes/ubifs-img.bbclass
> @@ -5,7 +5,7 @@
>  
>  python() {
>      if not d.getVar("MKUBIFS_ARGS"):
> -        raise bb.parse.skiprecipe("mkubifs_args must be set")
> +        raise bb.parse.SkipRecipe("mkubifs_args must be set")
>  }
>  
>  UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"

[PATCH v2] ubifs-img: Correct function name

[Quirin Gylstorff]

Fix python exception:

ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb: Error executing a python functi
on in <code>:
...
File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8, function: __anon_9__work_isar_meta_classes
_ubifs_img_bbclass
...
Exception: AttributeError: module 'bb.parse' has no attribute 'skiprecipe'

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
 meta/classes/ubifs-img.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
index aeb986c..78926f6 100644
--- a/meta/classes/ubifs-img.bbclass
+++ b/meta/classes/ubifs-img.bbclass
@@ -5,7 +5,7 @@
 
 python() {
     if not d.getVar("MKUBIFS_ARGS"):
-        raise bb.parse.skiprecipe("mkubifs_args must be set")
+        raise bb.parse.SkipRecipe("mkubifs_args must be set")
 }
 
 UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"
-- 
2.20.1

Re: [PATCH v2] ubifs-img: Correct function name

[Henning Schild]

Should get merged. The "original" code was probably just a wrongly
resolved merge conflict.

Henning

Am Wed, 17 Jul 2019 14:31:20 +0200
schrieb "[ext] Quirin Gylstorff" <quirin.gylstorff@siemens.com>:

> Fix python exception:
> 
> ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb:
> Error executing a python functi on in <code>:
> ...
> File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8,
> function: __anon_9__work_isar_meta_classes _ubifs_img_bbclass
> ...
> Exception: AttributeError: module 'bb.parse' has no attribute
> 'skiprecipe'
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  meta/classes/ubifs-img.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/ubifs-img.bbclass
> b/meta/classes/ubifs-img.bbclass index aeb986c..78926f6 100644
> --- a/meta/classes/ubifs-img.bbclass
> +++ b/meta/classes/ubifs-img.bbclass
> @@ -5,7 +5,7 @@
>  
>  python() {
>      if not d.getVar("MKUBIFS_ARGS"):
> -        raise bb.parse.skiprecipe("mkubifs_args must be set")
> +        raise bb.parse.SkipRecipe("mkubifs_args must be set")
>  }
>  
>  UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"

Re: [PATCH v2] ubifs-img: Correct function name

[Baurzhan Ismagulov]

On Wed, Jul 17, 2019 at 02:31:20PM +0200, Quirin Gylstorff wrote:
> Exception: AttributeError: module 'bb.parse' has no attribute 'skiprecipe'

Thanks, applied to next.

With kind regards,
Baurzhan.