From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6714593733299404800 X-Received: by 2002:a2e:98d7:: with SMTP id s23mr20188608ljj.179.1563364395191; Wed, 17 Jul 2019 04:53:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4c2e:: with SMTP id u14ls1945810lfq.15.gmail; Wed, 17 Jul 2019 04:53:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHUwHilt4uNQ2L3Sf+FNOFmw+PyU5V7wA/xll5K0MFoZiW4sMh1QjLyxxNMW8yHxkjIB+f X-Received: by 2002:a19:ca1e:: with SMTP id a30mr17357225lfg.163.1563364394701; Wed, 17 Jul 2019 04:53:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563364394; cv=none; d=google.com; s=arc-20160816; b=V7kUxAmx+ABnOOsjhEA4k7sbv0NXSN3QWCLrmmpOZTtPejXWPKLtuK0xTkvU0kQ3O5 KBMiQLQZyBtcxKTzXJh8gXvMs6LmaD9AfuaS3ehwDUzfUkJDTkhDgGmvrPJJA4KpSsTu YVUdcawqule8S/G1dRQa1H4qpH+kZzGAJkA9t/E7o4x1yjTVx8UZcX93Thqissl0Cuin W/UzIUuA1HOr7UHIGw9mP+fxQi9FyzlTpYyHe8WnhMuDMfPLLiUCfWTalC5kwEUMWT4B qY8m1TJc9u+Wg/Ot7c8jeoLz9L6BSYu0x78tIrW4QQ9O1gZT/WCf3brMJ5/1NELjgxW/ T6Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=6V49Vf3wVkv5Rwhtl8Q2Q/tB/SST603TrSefZF8HPEs=; b=l3SFjoAzDQ4pWKYDdnEUnzSkPoLNr4wWRlAmpDX24G7qtRsBoML8Py4yrRUgHGXAv6 vQ98nwhAtV0sLGbGWjztULd2VdD2jIgK35lSPjU3bC+PIYs0rfeG0wfnQ2PR1QhXKM// tm2g3UFDu4Pu738suO+X/IHp/gaBi3vb8SJCrnAMoI9d++6Te7j6m+otfZFScGIXm0Lz BMegbIEYhK3b2sGnPmfaYdt9deUWW/j4yXY/qerD/AqbczhO5IetgiuoAbySCcFPiA5l Y1IScjwm3ubeaOeqolvu9Kx/IMA8fPLgeuSqasBM4aqPNjAp6OrR37Sy6D64kAkLY4fV H7xA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id r27si1116527ljn.3.2019.07.17.04.53.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jul 2019 04:53:14 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x6HBrDIO001893 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 17 Jul 2019 13:53:14 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.69.220]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x6HBrDwJ004197; Wed, 17 Jul 2019 13:53:13 +0200 Date: Wed, 17 Jul 2019 13:53:10 +0200 From: Henning Schild To: Quirin Gylstorff Cc: Subject: Re: [PATCH] ubifs-img: Correct function name Message-ID: <20190717135310.18c8cf62@md1za8fc.ad001.siemens.net> In-Reply-To: <20190717113239.15136-1-quirin.gylstorff@siemens.com> References: <20190717113239.15136-1-quirin.gylstorff@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: el16+vaUsI4k The content looks good to me. I think the commit message does not require the whole trace. And the commit message needs a Signed-Off. Henning Am Wed, 17 Jul 2019 13:32:39 +0200 schrieb Quirin Gylstorff : > Fix python exception: > > ERROR: /work/isar-siemens/recipes-core/images/ubi-fit-swu-demo-image.bb: > Error executing a python functi on in : > > The stack trace of python calls that resulted in this > exception/failure was: File: '', lineno: 5, function: > 0001:__anon_125__work_isar_meta_classes_base_bbclass(d) > 0002:__anon_144__work_isar_meta_classes_base_bbclass(d) > 0003:__anon_34__work_isar_meta_classes_image_bbclass(d) > 0004:__anon_20__work_isar_meta_classes_buildchroot_bbclass(d) > *** 0005:__anon_9__work_isar_meta_classes_ubifs_img_bbclass(d) > 0006:__anon_9__work_isar_meta_classes_ubi_img_bbclass(d) > File: '/work/isar/meta/classes/ubifs-img.bbclass', lineno: 8, > function: __anon_9__work_isar_meta_classes _ubifs_img_bbclass > 0004:# SPDX-License-Identifier: MIT > 0005: > 0006:python() { > 0007: if not d.getVar("MKUBIFS_ARGS"): > *** 0008: raise bb.parse.skiprecipe("mkubifs_args must be > set") 0009:} > 0010: > 0011:UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img" > 0012: > Exception: AttributeError: module 'bb.parse' has no attribute > 'skiprecipe' --- > meta/classes/ubifs-img.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/ubifs-img.bbclass > b/meta/classes/ubifs-img.bbclass index aeb986c..78926f6 100644 > --- a/meta/classes/ubifs-img.bbclass > +++ b/meta/classes/ubifs-img.bbclass > @@ -5,7 +5,7 @@ > > python() { > if not d.getVar("MKUBIFS_ARGS"): > - raise bb.parse.skiprecipe("mkubifs_args must be set") > + raise bb.parse.SkipRecipe("mkubifs_args must be set") > } > > UBIFS_IMAGE_FILE ?= "${IMAGE_FULLNAME}.ubifs.img"