Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 25 Apr 2019 08:50:57 +0300
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> On 4/24/19 10:48 AM, Claudius Heine wrote:
> > ping
> > 
> > On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote:  
> >> From: Claudius Heine <ch@denx.de>
> >>
> >> In machines that have not set those variables, it is still
> >> possible that those classes are parsed. The parsing itself should
> >> not fail in that case, instead those recipes should just be
> >> skipped.  
> 
> Rebased and applied to the 'next'.

That rebase actually caused the problem that Quirin just found. The
patch from Claudius does not contain the bug just found.

Henning

> 
> Maxim.
> 
> >> Signed-off-by: Claudius Heine <ch@denx.de>
> >> ---
> >>   meta/classes/ubi-img.bbclass   | 2 +-
> >>   meta/classes/ubifs-img.bbclass | 2 +-
> >>   2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/classes/ubi-img.bbclass
> >> b/meta/classes/ubi-img.bbclass index f61a940..777b8c4 100644
> >> --- a/meta/classes/ubi-img.bbclass
> >> +++ b/meta/classes/ubi-img.bbclass
> >> @@ -5,7 +5,7 @@
> >>   python() {
> >>       if not d.getVar("UBINIZE_ARGS"):
> >> -        bb.fatal("UBINIZE_ARGS must be set")
> >> +        raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
> >>   }
> >>   UBINIZE_CFG ??= "ubinize.cfg"
> >> diff --git a/meta/classes/ubifs-img.bbclass 
> >> b/meta/classes/ubifs-img.bbclass
> >> index ed37357..881d2bb 100644
> >> --- a/meta/classes/ubifs-img.bbclass
> >> +++ b/meta/classes/ubifs-img.bbclass
> >> @@ -5,7 +5,7 @@
> >>   python() {
> >>       if not d.getVar("MKUBIFS_ARGS"):
> >> -        bb.fatal("MKUBIFS_ARGS must be set")
> >> +        raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
> >>   }
> >>   inherit image
> >>  
> >   
> 
>