From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6673096226406137856 X-Received: by 2002:a2e:8681:: with SMTP id l1mr13602183lji.166.1563895771318; Tue, 23 Jul 2019 08:29:31 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:6556:: with SMTP id z83ls4921021ljb.11.gmail; Tue, 23 Jul 2019 08:29:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqz7DBxmZ1mh6B9xYmKliUlf3gfSXv9awYuYTH9TfZt3WqlMUU7PZk5uhmYGQT9X/ERT/jBi X-Received: by 2002:a2e:800c:: with SMTP id j12mr2216047ljg.22.1563895770925; Tue, 23 Jul 2019 08:29:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563895770; cv=none; d=google.com; s=arc-20160816; b=aR2o2t5cT+lwJhFjfXOJ40aVSnzZfi0FnxFbeSYxbXv8Y+VlKDD5XABbcC5yJlGxDt bmEW1c0GryzuFn5H7ke5DD2Wy7vJ76a3Jykt8jui9oJ2dZ+Xs8aU/fy1PDGD5b1XLwa9 rZQ1yCQscXndqDRZsJgGbs9aMqVuAhrwVnFiYO8ajlvi+4CMw9eEMS4FjKYQ7SJv/Khk knoXs4IGL8UxHb8VtIo+6F4wtbEqsUx77nA2SzVUt5ejpEp8lDsAWMma52akstbRzAna vjDBqH7//dfCQWu8P6e9teOn2HVQST2vkYOKZDp1GkLe6kuUkIA4vAcxZ8Df/vcUlSZT oLLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=ucHo7LEL9sphojdGoPZZk7EBj4+oeqIjlhhxPt+6Hiw=; b=CouEaSOpVmGQ0jxlIQvhSZCt7+EM+KgGQsRTcHQ9Iwo4j7nKTW8XDajE8knLS1ZphV oI2KA4wbj+9h7WyrbZuRcLC+JRWG69TWMJl+TdH2ez83xeWuvck6fgNdDgnLo6jtFrdv duNQne2xhlzmHEsXff/6WY1l2ujYvWUV1AUYGina/MBz4GmxCCTJmSQLkQL7xlPtXbGJ wZwbXOeDiw2teSI9WNgym0WF+mXoT/qmxTvevztco4B537nHSno5MqbbrOiVzsjnUUQn eMKvaKjiiWkHpLP7W1X5cwDr9G4pld/AQZMEocP250p0sZ/K+kO9/WeKZO2eAh9PKWgs Yh8A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id v29si2199861lfq.2.2019.07.23.08.29.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jul 2019 08:29:30 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x6NFTTc4027292 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jul 2019 17:29:29 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.69.220]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x6NFTTxT011120; Tue, 23 Jul 2019 17:29:29 +0200 Date: Tue, 23 Jul 2019 17:29:28 +0200 From: Henning Schild To: "Maxim Yu. Osipov" Cc: Claudius Heine , , Claudius Heine , "Gylstorff, Quirin (CT RDA IOT SES-DE)" Subject: Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe Message-ID: <20190723172928.6014ea43@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20190327154124.14663-1-claudius.heine.ext@siemens.com> <20190328075022.29511-1-claudius.heine.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: ehIhzqd+CGZi Am Thu, 25 Apr 2019 08:50:57 +0300 schrieb "Maxim Yu. Osipov" : > On 4/24/19 10:48 AM, Claudius Heine wrote: > > ping > >=20 > > On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote: =20 > >> From: Claudius Heine > >> > >> In machines that have not set those variables, it is still > >> possible that those classes are parsed. The parsing itself should > >> not fail in that case, instead those recipes should just be > >> skipped. =20 >=20 > Rebased and applied to the 'next'. That rebase actually caused the problem that Quirin just found. The patch from Claudius does not contain the bug just found. Henning >=20 > Maxim. >=20 > >> Signed-off-by: Claudius Heine > >> --- > >> =C2=A0 meta/classes/ubi-img.bbclass=C2=A0=C2=A0 | 2 +- > >> =C2=A0 meta/classes/ubifs-img.bbclass | 2 +- > >> =C2=A0 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/meta/classes/ubi-img.bbclass > >> b/meta/classes/ubi-img.bbclass index f61a940..777b8c4 100644 > >> --- a/meta/classes/ubi-img.bbclass > >> +++ b/meta/classes/ubi-img.bbclass > >> @@ -5,7 +5,7 @@ > >> =C2=A0 python() { > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if not d.getVar("UBINIZE_ARGS"): > >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bb.fatal("UBINIZE_ARGS mus= t be set") > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 raise bb.parse.SkipRecipe(= "UBINIZE_ARGS must be set") > >> =C2=A0 } > >> =C2=A0 UBINIZE_CFG ??=3D "ubinize.cfg" > >> diff --git a/meta/classes/ubifs-img.bbclass=20 > >> b/meta/classes/ubifs-img.bbclass > >> index ed37357..881d2bb 100644 > >> --- a/meta/classes/ubifs-img.bbclass > >> +++ b/meta/classes/ubifs-img.bbclass > >> @@ -5,7 +5,7 @@ > >> =C2=A0 python() { > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if not d.getVar("MKUBIFS_ARGS"): > >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bb.fatal("MKUBIFS_ARGS mus= t be set") > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 raise bb.parse.SkipRecipe(= "MKUBIFS_ARGS must be set") > >> =C2=A0 } > >> =C2=A0 inherit image > >> =20 > > =20 >=20 >=20