From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6717496001358200832 X-Received: by 2002:aa7:cf8e:: with SMTP id z14mr75738576edx.40.1564046150554; Thu, 25 Jul 2019 02:15:50 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:7345:: with SMTP id h5ls10413887ejl.16.gmail; Thu, 25 Jul 2019 02:15:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3buqToFqPkWC3m3y3tr3duVB2neRB+SwdGp782q8DoZGZQtFUfCrSrsBylwSf/OMWYVz6 X-Received: by 2002:a17:906:4b18:: with SMTP id y24mr66045921eju.108.1564046149946; Thu, 25 Jul 2019 02:15:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564046149; cv=none; d=google.com; s=arc-20160816; b=DQwKg1lARIpPav7XiRwyW2Q+QIfWrvLHlxgmQC/QVspXtlebArEzFP/+xyO63ExBIu MjqlDSXX6a1yzcEBJ9g9zAAkU+uP/Fn6X5Jmey4bmyiOjd5uUxOKvtwyb9pIwd/Fx6QI gmjlVwQ+Rhk6WSf+QeDGZxLOHMfg/8l11xZOPl6vB4zJuLsmUvKcYDxE2WgPZY0bhR/c Le0/9jzDVXuyO7xzOzJYwWAxXCgSPZiQyfzfOroYtgJXE/X2zK/CWtY3G8PM6WoFV/9L x6OvrgbmS2wy0Qg1ih9luRxSXBssMgaC/14OKIrL/jJRYWM7Je6SJvg7KZ85lyI/G7bJ 3mWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:dkim-signature; bh=NwHDMdcZSmhhLjb+/hsbFH9q+nToNYeMepTye10BSks=; b=BbYSc29i6c+EMTicRng0kWyW6c6RiPqLd7KZ5QQ2AzMNfjnRfWmCKbRUGM/ebDrzJN 6Wu6ggDBONzkh/2AMHXGAGfLHKX5OZr1imihoPww3jqWUAGlJqfSvQ2MwmkSFBsNT8ED pv5YOe9iCuag2YT2d5M8ZlsgYbzTYF73JvontbW0EbqqUJjnEnxH6TmFYSSk6NwW72Pw 9RrH9Bh6iy1hNMY90JWKFlGoCgPrjSA9bsAphO+ckpPN+in6LUqgFHXKltT+Q0u8fyv2 Ewe+THshoAgdIOMyA11ZwFMjD0nwUyn8DqdBWyyyAXOav1eHbNPvtZXLBOnjJ5npfcPf Jn0A== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OpbsAqKX; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com. [2a00:1450:4864:20::441]) by gmr-mx.google.com with ESMTPS id jz14si2119740ejb.0.2019.07.25.02.15.49 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 02:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) client-ip=2a00:1450:4864:20::441; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OpbsAqKX; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wr1-x441.google.com with SMTP id x1so10342wrr.9 for ; Thu, 25 Jul 2019 02:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NwHDMdcZSmhhLjb+/hsbFH9q+nToNYeMepTye10BSks=; b=OpbsAqKXaIEga9orNKwK+WUetWfLP/m7R5ajP3/Xw1jd5qZRuxxyoqfRHjjvLs0cSg qjrAIC2cjg9JnvsYfS0J54uSl4ZJMBWBvqZ1lGeD8Jv/E0s846/lyWB9AjUeZQlbNJz2 Kiypmr6c0UWTugq/NT7cx1BblsQ3UKWLIgI8ZEcaP2dTLVmFIdE9nWoT27jklxOGS253 28pAIjUKwIiTsBaADqYT9fzHSibTs4KVwKGDmlU2XsTKT+Td4fNLkZrD0L3F3Tv44wE3 Y95FUS6fEbRsG6vMheCBADsRpBMECbdvfUCu28V5Fpp1N0IF8vBUNjXs8arvpdsbbZ0l pf+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NwHDMdcZSmhhLjb+/hsbFH9q+nToNYeMepTye10BSks=; b=C5E+c5z1i3mX9xkGzI+1uFz0tggZmohbGeMmkpVQHaNSfG9kHrWwKFBlWo5vmLkKYV UHl/OwRCIR3MveGBZ9pwMo5DLRHMalCBn/jlskZN0VrdHj8Q5YJFcHbod8hWUKlgbulu azKq9McPmcXpSjBEJxKfzQs0zSgswq+mAkCAv/IG78pv281q5jjruQmYwnporaXjYeoD hj0R5NetDfCJCoAyFnTYnYokDoflyw/NRMiH5l19AAmqCDOghw/PD2Aw44I+YDTrlP1x UjGtVdaIvpETQTLB1+BoVffv7OWpNLJ9IwnJZiAfAs8YsM/5Bt61NdiqGOIBkoTysz6a xrMg== X-Gm-Message-State: APjAAAXHtgs4/418dgeDYRFBn5xQt4aKRanQ/nN83XlQhUt8M9o1SlAi DJU7W17dXyVA1A76Dxuz31g= X-Received: by 2002:adf:e552:: with SMTP id z18mr95952514wrm.45.1564046149603; Thu, 25 Jul 2019 02:15:49 -0700 (PDT) Return-Path: Received: from chikyu (nat-sch.mentorg.com. [139.181.36.34]) by smtp.gmail.com with ESMTPSA id 91sm101015066wrp.3.2019.07.25.02.15.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jul 2019 02:15:49 -0700 (PDT) From: Vijai Kumar K X-Google-Original-From: Vijai Kumar K Date: Thu, 25 Jul 2019 14:45:43 +0530 To: Jan Kiszka Cc: vijaikumar.kanagarajan@gmail.com, isar-users@googlegroups.com, henning.schild@siemens.com, claudius.heine.ext@siemens.com Subject: Re: [PATCH v2] export GNUGPHOME for reprepro Message-ID: <20190725091543.GB3995@chikyu> References: <6fc7018b-f58d-99e7-a384-2925ffd86772@denx.de> <20190725090808.4192-1-Vijaikumar_Kangarajan@mentor.com> <4e00bf54-6b30-b87a-bc09-dce4adca35e8@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e00bf54-6b30-b87a-bc09-dce4adca35e8@siemens.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-TUID: AFUqI8/lUfpW On Thu, Jul 25, 2019 at 11:10:25AM +0200, Jan Kiszka wrote: > On 25.07.19 11:08, vijaikumar.kanagarajan@gmail.com wrote: > > From: Vijai Kumar K > > > > Changes in v2 (address comments from Claudius) > > - use -n instead of ! -z > > > >> 8------------------------------------------------------8< > > Comments have to go below the "---" separator. The above is too easy to get > merged as-is on "git am". > > Jan Sure Jan. Noted. Will follow that. Thanks, Vijai Kumar K > > > reprepro doesnot know about GNUPGHOME. If you trigger package feed > > creation in a machine that has GNUPGHOME set, reprepro would not > > know that it should use the new location and might use the keys it > > find in the default ~/.gnupg directory. > > > > Make GNUPGHOME available for reprepro. > > > > Signed-off-by: Vijai Kumar K > > --- > > meta/classes/base-apt-helper.bbclass | 4 ++++ > > meta/classes/dpkg-base.bbclass | 3 +++ > > meta/recipes-devtools/base-apt/base-apt.bb | 3 +++ > > meta/recipes-devtools/isar-apt/isar-apt.bb | 3 +++ > > scripts/isar-buildenv-internal | 3 +++ > > 5 files changed, 16 insertions(+) > > > > diff --git a/meta/classes/base-apt-helper.bbclass b/meta/classes/base-apt-helper.bbclass > > index ba768da..ee43216 100644 > > --- a/meta/classes/base-apt-helper.bbclass > > +++ b/meta/classes/base-apt-helper.bbclass > > @@ -30,6 +30,10 @@ populate_base_apt() { > > compare_pkg_md5sums "$package" "$isar_package" && continue > > fi > > > > + if [ -n "${GNUPGHOME}" ]; then > > + export GNUPGHOME="${GNUPGHOME}" > > + fi > > + > > # Check if this package is already in base-apt > > isar_package=$(find ${REPO_BASE_DIR}/${BASE_DISTRO} -name $base_name) > > if [ -n "$isar_package" ]; then > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > > index 3e6ba8c..e03f1d0 100644 > > --- a/meta/classes/dpkg-base.bbclass > > +++ b/meta/classes/dpkg-base.bbclass > > @@ -120,6 +120,9 @@ repo_clean() { > > > > # Install package to Isar-apt > > do_deploy_deb() { > > + if [ -n "${GNUPGHOME}" ]; then > > + export GNUPGHOME="${GNUPGHOME}" > > + fi > > repo_clean > > reprepro -b ${REPO_ISAR_DIR}/${DISTRO} \ > > --dbdir ${REPO_ISAR_DB_DIR}/${DISTRO} \ > > diff --git a/meta/recipes-devtools/base-apt/base-apt.bb b/meta/recipes-devtools/base-apt/base-apt.bb > > index 1c0b4c6..488a44d 100644 > > --- a/meta/recipes-devtools/base-apt/base-apt.bb > > +++ b/meta/recipes-devtools/base-apt/base-apt.bb > > @@ -28,6 +28,9 @@ do_cache_config() { > > path_databases="${REPO_BASE_DB_DIR}/${BASE_DISTRO}" > > > > if [ ! -d "${path_databases}" ]; then > > + if [ -n "${GNUPGHOME}" ]; then > > + export GNUPGHOME="${GNUPGHOME}" > > + fi > > reprepro -b ${path_cache} \ > > --dbdir ${path_databases} \ > > export ${BASE_DISTRO_CODENAME} > > diff --git a/meta/recipes-devtools/isar-apt/isar-apt.bb b/meta/recipes-devtools/isar-apt/isar-apt.bb > > index a959691..e6f1753 100644 > > --- a/meta/recipes-devtools/isar-apt/isar-apt.bb > > +++ b/meta/recipes-devtools/isar-apt/isar-apt.bb > > @@ -20,6 +20,9 @@ do_cache_config() { > > path_databases="${REPO_ISAR_DB_DIR}/${DISTRO}" > > > > if [ ! -d "${path_databases}" ]; then > > + if [ -n "${GNUPGHOME}" ]; then > > + export GNUPGHOME="${GNUPGHOME}" > > + fi > > reprepro -b ${path_cache} \ > > --dbdir ${path_databases} \ > > export ${DEBDISTRONAME} > > diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv-internal > > index 2476d90..cc9ebcf 100755 > > --- a/scripts/isar-buildenv-internal > > +++ b/scripts/isar-buildenv-internal > > @@ -67,4 +67,7 @@ BBPATH="${BUILDDIR}" > > export BBPATH > > > > BB_ENV_EXTRAWHITE="BUILDDIR ISARROOT http_proxy https_proxy ftp_proxy no_proxy" > > +if [ -n "${GNUPGHOME}" ]; then > > + BB_ENV_EXTRAWHITE="${BB_ENV_EXTRAWHITE} GNUPGHOME" > > +fi > > export BB_ENV_EXTRAWHITE > > > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux