From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6717496001358200832 X-Received: by 2002:ac2:52b7:: with SMTP id r23mr9710806lfm.120.1564039546899; Thu, 25 Jul 2019 00:25:46 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:8854:: with SMTP id z20ls5597496ljj.5.gmail; Thu, 25 Jul 2019 00:25:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNUuYIcRcNE8GTxDIfEy7OrkuGU+nRUbK8/xOD0kX1ISFnyyZbusTZ4VLZf74d99RcgLeD X-Received: by 2002:a05:651c:92:: with SMTP id 18mr36804358ljq.35.1564039546434; Thu, 25 Jul 2019 00:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564039546; cv=none; d=google.com; s=arc-20160816; b=pg9fhgU6WYTFtqai8Bafp8Pi96pLRcb2wFpOGa0itjpNNmhm8t6QunDEgvk9RsEmyo lYJJUOFqoRy2B4jsa+vCQ4f5RvhzCk/iPmUiZHhpt8topfu8vZ+ZcrulpjRMXs5VlguY qizA4KvIpfDq2EADhpn/XqWOigEDSCvSXeuZHgIfyoLJdCmfvWJn8G3LDSJNO9rIledb aSqCG9+HQ5P2S35jNUjufcrbOkRSxf7T2yek1Gak/iSOE5B584/8HhCV44fRJig74W/Z L8mEg5IKd8QcytwI/DlenCV9cdmLmNMTIYTKhDxN3/u8W58H9/A81dnFWZB+9zBOkwV7 QJCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=YDZIUb4zBthangTsy7Wgb8N/geW3KlCjIZQQ7ciLNfs=; b=eyMmfyFQxWFJh7ccqlshl8cf/FIKbRjuMih8sefcJu28Sza1jl+hDzBdfyRTomjIyu p2sszDvOc8g/lJrN1CUXgu1+AnmBog+dtZdvyQTgWYCtYMKK7QWBeqywF6BFsdPyMLCz mx5HeDeUXXwCXc05//DdO2XmHU7oSOMfqrxjiGdSYjwEu0yttDGZjzcQcucYigsKvBTq fIu7/JzGrUCG4BO7bHTcuHEb/m2kFuJdN0/x4S6ocbGTU3MSNqFQNJHPU2gdsVlwVV9b 6mwB1DmQZYoIqA60iJzkhVX1idOEgsJuZUmVS0NtoMsY5pVH74Ai55qnCYDYNszNrDvN kVlw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id b8si2168131lfp.3.2019.07.25.00.25.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 00:25:46 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x6P7Pjmt026249 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jul 2019 09:25:45 +0200 Received: from md1za8fc.ad001.siemens.net ([139.25.68.184]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x6P7PiDi031716; Thu, 25 Jul 2019 09:25:44 +0200 Date: Thu, 25 Jul 2019 09:25:43 +0200 From: Henning Schild To: vijaikumar.kanagarajan@gmail.com Cc: , Vijai Kumar K , "Maxim Yu. Osipov" Subject: Re: [PATCH] export GNUGPHOME for reprepro Message-ID: <20190725092543.3aa826cf@md1za8fc.ad001.siemens.net> In-Reply-To: <20190725071504.24037-1-Vijaikumar_Kangarajan@mentor.com> References: <20190725071504.24037-1-Vijaikumar_Kangarajan@mentor.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: CoSyEW4vV3PU Hi Vijai Kumar, this patch looks good on its own. But again the context is missing. A series that enables proper GPG signing would be more helpful than tiny steps that might not be going in the right direction. That said you already did a lot of research on the topic and did send several good proposals and the full thing might be still far away. This one combined with the one from Maxim would make a step that is very likely going in the right direction. And could be merged if we are in a hurry to merge intermediate steps. Henning Am Thu, 25 Jul 2019 12:45:04 +0530 schrieb : > From: Vijai Kumar K > > reprepro doesnot know about GNUPGHOME. If you trigger package feed > creation in a machine that has GNUPGHOME set, reprepro would not > know that it should use the new location and might use the keys it > find in the default ~/.gnupg directory. > > Make GNUPGHOME available for reprepro. > > Signed-off-by: Vijai Kumar K > --- > meta/classes/base-apt-helper.bbclass | 4 ++++ > meta/classes/dpkg-base.bbclass | 3 +++ > meta/recipes-devtools/base-apt/base-apt.bb | 3 +++ > meta/recipes-devtools/isar-apt/isar-apt.bb | 3 +++ > scripts/isar-buildenv-internal | 3 +++ > 5 files changed, 16 insertions(+) > > diff --git a/meta/classes/base-apt-helper.bbclass > b/meta/classes/base-apt-helper.bbclass index ba768da..a8f2a41 100644 > --- a/meta/classes/base-apt-helper.bbclass > +++ b/meta/classes/base-apt-helper.bbclass > @@ -30,6 +30,10 @@ populate_base_apt() { > compare_pkg_md5sums "$package" "$isar_package" && > continue fi > > + if [ ! -z ${GNUPGHOME} ]; then > + export GNUPGHOME=${GNUPGHOME} > + fi > + > # Check if this package is already in base-apt > isar_package=$(find ${REPO_BASE_DIR}/${BASE_DISTRO} -name > $base_name) if [ -n "$isar_package" ]; then > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass index 3e6ba8c..da13f86 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -120,6 +120,9 @@ repo_clean() { > > # Install package to Isar-apt > do_deploy_deb() { > + if [ ! -z ${GNUPGHOME} ]; then > + export GNUPGHOME=${GNUPGHOME} > + fi > repo_clean > reprepro -b ${REPO_ISAR_DIR}/${DISTRO} \ > --dbdir ${REPO_ISAR_DB_DIR}/${DISTRO} \ > diff --git a/meta/recipes-devtools/base-apt/base-apt.bb > b/meta/recipes-devtools/base-apt/base-apt.bb index 1c0b4c6..ca40b6c > 100644 --- a/meta/recipes-devtools/base-apt/base-apt.bb > +++ b/meta/recipes-devtools/base-apt/base-apt.bb > @@ -28,6 +28,9 @@ do_cache_config() { > path_databases="${REPO_BASE_DB_DIR}/${BASE_DISTRO}" > > if [ ! -d "${path_databases}" ]; then > + if [ ! -z ${GNUPGHOME} ]; then > + export GNUPGHOME=${GNUPGHOME} > + fi > reprepro -b ${path_cache} \ > --dbdir ${path_databases} \ > export ${BASE_DISTRO_CODENAME} > diff --git a/meta/recipes-devtools/isar-apt/isar-apt.bb > b/meta/recipes-devtools/isar-apt/isar-apt.bb index a959691..8f517fe > 100644 --- a/meta/recipes-devtools/isar-apt/isar-apt.bb > +++ b/meta/recipes-devtools/isar-apt/isar-apt.bb > @@ -20,6 +20,9 @@ do_cache_config() { > path_databases="${REPO_ISAR_DB_DIR}/${DISTRO}" > > if [ ! -d "${path_databases}" ]; then > + if [ ! -z ${GNUPGHOME} ]; then > + export GNUPGHOME=${GNUPGHOME} > + fi > reprepro -b ${path_cache} \ > --dbdir ${path_databases} \ > export ${DEBDISTRONAME} > diff --git a/scripts/isar-buildenv-internal > b/scripts/isar-buildenv-internal index 2476d90..7637d41 100755 > --- a/scripts/isar-buildenv-internal > +++ b/scripts/isar-buildenv-internal > @@ -67,4 +67,7 @@ BBPATH="${BUILDDIR}" > export BBPATH > > BB_ENV_EXTRAWHITE="BUILDDIR ISARROOT http_proxy https_proxy > ftp_proxy no_proxy" +if [ ! -z ${GNUPGHOME} ]; then > + BB_ENV_EXTRAWHITE="${BB_ENV_EXTRAWHITE} GNUPGHOME" > +fi > export BB_ENV_EXTRAWHITE