public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
To: isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: [PATCH v3] meta/classes:Add wic tooling for related images
Date: Thu, 25 Jul 2019 12:20:50 +0200	[thread overview]
Message-ID: <20190725102050.3191-1-quirin.gylstorff@siemens.com> (raw)
In-Reply-To: <cf0f291c-e779-400f-c70a-72fcb9d63d4f@siemens.com>

The dependencies for wic are only added if IMAGE_TYPE
is equal to "wic-img". If a image type depends on the
wic-image class it is no longer possible to build a
wic image.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
Changes in v3:
 - remove empty lines
Changes in v2:
 - move below inherit buildchroot

 meta/classes/image-tools-extension.bbclass | 6 ------
 meta/classes/wic-img.bbclass               | 1 +
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/meta/classes/image-tools-extension.bbclass b/meta/classes/image-tools-extension.bbclass
index b8672d5..ca94d49 100644
--- a/meta/classes/image-tools-extension.bbclass
+++ b/meta/classes/image-tools-extension.bbclass
@@ -14,12 +14,6 @@ IMAGER_INSTALL ??= ""
 IMAGER_BUILD_DEPS ??= ""
 DEPENDS += "${IMAGER_BUILD_DEPS}"
 
-python () {
-    if d.getVar('IMAGE_TYPE', True) == 'wic-img':
-        d.appendVar('IMAGER_INSTALL',
-                    ' ' + d.getVar('WIC_IMAGER_INSTALL', True))
-}
-
 do_install_imager_deps[depends] = "buildchroot-target:do_build"
 do_install_imager_deps[deptask] = "do_deploy_deb"
 do_install_imager_deps[lockfiles] += "${REPO_ISAR_DIR}/isar.lock"
diff --git a/meta/classes/wic-img.bbclass b/meta/classes/wic-img.bbclass
index 94f0b02..1ccbe55 100644
--- a/meta/classes/wic-img.bbclass
+++ b/meta/classes/wic-img.bbclass
@@ -78,6 +78,7 @@ python () {
 
 inherit buildchroot
 
+IMAGER_INSTALL += "${WIC_IMAGER_INSTALL}"
 # wic comes with reasonable defaults, and the proper interface is the wks file
 ROOTFS_EXTRA ?= "0"
 
-- 
2.20.1


  reply	other threads:[~2019-07-25 10:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 13:49 [PATCH] " Quirin Gylstorff
2019-07-23 14:18 ` Henning Schild
2019-07-23 14:42   ` Quirin Gylstorff
2019-07-23 14:56     ` Claudius Heine
2019-07-23 15:15     ` Henning Schild
2019-07-23 15:24       ` Jan Kiszka
2019-07-23 15:04 ` [PATCH v2] " Quirin Gylstorff
2019-07-23 15:08   ` Claudius Heine
2019-07-25 10:20     ` Quirin Gylstorff [this message]
2019-08-01  4:26       ` [PATCH v3] " Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190725102050.3191-1-quirin.gylstorff@siemens.com \
    --to=quirin.gylstorff@siemens.com \
    --cc=ch@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox