From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] export GNUGPHOME for reprepro
Date: Thu, 1 Aug 2019 13:48:34 +0200 [thread overview]
Message-ID: <20190801114834.GK14716@yssyq.m.ilbers.de> (raw)
In-Reply-To: <20190801133818.3915d525@md1za8fc.ad001.siemens.net>
On Thu, Aug 01, 2019 at 01:38:18PM +0200, Henning Schild wrote:
> > >> Why did you go for conditional append for that one, while the
> > >> others are unconditional?
> > >
> > > GNUPGHOME might not be set in the host and hence went for the
> > > condition. BTW, I don't think having always would cause issues.
>
> If there is no reason for the condition please drop it.
If I read the patch correctly, all uses of GNUPGHOME are conditional. IIUC, we
need conditions everywhere, because if it is not set in the host environment,
we'd end up setting it to an empty string, which I assume we shouldn't do. Or
have I overlooked anything?
With kind regards,
Baurzhan.
next prev parent reply other threads:[~2019-08-01 11:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 7:15 vijaikumar.kanagarajan
2019-07-25 7:25 ` Henning Schild
2019-07-25 8:59 ` Vijai Kumar K
2019-07-25 7:35 ` Claudius Heine
2019-07-25 9:08 ` [PATCH v2] " vijaikumar.kanagarajan
2019-07-25 9:10 ` Jan Kiszka
2019-07-25 9:15 ` Vijai Kumar K
2019-08-01 11:12 ` [PATCH] " Henning Schild
2019-08-01 11:23 ` vijai kumar
2019-08-01 11:34 ` vijai kumar
2019-08-01 11:38 ` Henning Schild
2019-08-01 11:42 ` vijai kumar
2019-08-01 11:48 ` Baurzhan Ismagulov [this message]
2019-08-01 11:52 ` Henning Schild
2019-08-01 12:09 ` Baurzhan Ismagulov
2019-08-05 10:58 ` [PATCH v2] " vijaikumar.kanagarajan
2019-08-06 8:35 ` [PATCH v2] export GNUPGHOME " Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801114834.GK14716@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox